diff mbox series

[3/4] Revert "efi: Allow easy selection of serial-only operation"

Message ID 20220311121248.2801589-3-trini@konsulko.com
State Accepted
Commit ab366418b51fa883ff780200b127ab4a7ed62fab
Delegated to: Tom Rini
Headers show
Series [1/4] CI: Fix unmigrated symbol test | expand

Commit Message

Tom Rini March 11, 2022, 12:12 p.m. UTC
This commit re-introduced a migrated CONFIG symbol to the board header
file.  These changes should likely be handled via documentation instead,
as well.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 include/configs/efi-x86_app.h | 25 -------------------------
 1 file changed, 25 deletions(-)

Comments

Simon Glass March 16, 2022, 3:13 a.m. UTC | #1
On Fri, 11 Mar 2022 at 05:12, Tom Rini <trini@konsulko.com> wrote:
>
> This commit re-introduced a migrated CONFIG symbol to the board header
> file.  These changes should likely be handled via documentation instead,
> as well.
>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  include/configs/efi-x86_app.h | 25 -------------------------
>  1 file changed, 25 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Sorry, was caught by spam filter. I must remember to check that every
now and then.


- SImon
Tom Rini March 19, 2022, 1:26 a.m. UTC | #2
On Fri, Mar 11, 2022 at 07:12:47AM -0500, Tom Rini wrote:

> This commit re-introduced a migrated CONFIG symbol to the board header
> file.  These changes should likely be handled via documentation instead,
> as well.
> 
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/include/configs/efi-x86_app.h b/include/configs/efi-x86_app.h
index 33afb7ca0f9b..6061a6db0a40 100644
--- a/include/configs/efi-x86_app.h
+++ b/include/configs/efi-x86_app.h
@@ -10,33 +10,8 @@ 
 
 #undef CONFIG_TPM_TIS_BASE_ADDRESS
 
-/*
- * Select the output device: Put an 'x' prefix before one of these to disable it
- */
-
-/*
- * Video output - can normally continue after exit_boot_services has been
- * called, since output to the display does not require EFI services at that
- * point. U-Boot sets up the console memory and does its own drawing.
- */
 #define CONFIG_STD_DEVICES_SETTINGS	"stdin=serial\0" \
 					"stdout=vidconsole\0" \
 					"stderr=vidconsole\0"
 
-/*
- * Serial output with no console. Run qemu with:
- *
- *    -display none -serial mon:stdio
- *
- * This will hang or fail to output on the console after exit_boot_services is
- * called.
- */
-#define xCONFIG_STD_DEVICES_SETTINGS	"stdin=serial\0" \
-					"stdout=serial\0" \
-					"stderr=serial\0"
-
-#undef CONFIG_BOOTCOMMAND
-
-#define CONFIG_BOOTCOMMAND "part list efi 0; fatls efi 0:1"
-
 #endif