| Message ID | 20220226161309.683908-1-aford173@gmail.com |
|---|---|
| State | Accepted |
| Commit | b2356be87d27efc0d2d1ecf0a65b663c59854aed |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | ARM: am3517-evm: Remove more non-DM legacy ethernet reset code | expand |
On Sat, Feb 26, 2022 at 10:13 AM Adam Ford <aford173@gmail.com> wrote: > The ethernet controller is DM compliant, and the device tree > defines it. There is no need to manually handle pulling > the ethernet out of reset. > > Signed-off-by: Adam Ford <aford173@gmail.com> > > diff --git a/board/logicpd/am3517evm/am3517evm.c > b/board/logicpd/am3517evm/am3517evm.c > index f014165928..e787441c74 100644 > --- a/board/logicpd/am3517evm/am3517evm.c > +++ b/board/logicpd/am3517evm/am3517evm.c > @@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void) > */ > int misc_init_r(void) > { > - u32 reset; > - > omap_die_id_display(); > > am3517_evm_musb_init(); > > - /* ensure that the Ethernet module is out of reset */ > - reset = readl(AM3517_IP_SW_RESET); > - reset &= (~CPGMACSS_SW_RST); > - writel(reset, AM3517_IP_SW_RESET); > - > return 0; > } > > @@ -142,7 +135,6 @@ void set_muxconf_regs(void) > MUX_AM3517EVM(); > } > > - > #if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET) > int board_eth_init(struct bd_info *bis) > { > -- > 2.34.1 > > Ethernet continues to work on AM3517 Zoom eXperimenter. Tested-by: Derald D. Woods <woods.technical@gmail.com>
On Sat, Feb 26, 2022 at 10:13:09AM -0600, Adam Ford wrote: > The ethernet controller is DM compliant, and the device tree > defines it. There is no need to manually handle pulling > the ethernet out of reset. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Tested-by: Derald D. Woods <woods.technical@gmail.com> > > diff --git a/board/logicpd/am3517evm/am3517evm.c b/board/logicpd/am3517evm/am3517evm.c > index f014165928..e787441c74 100644 Applied to u-boot/next, thanks!
diff --git a/board/logicpd/am3517evm/am3517evm.c b/board/logicpd/am3517evm/am3517evm.c index f014165928..e787441c74 100644 --- a/board/logicpd/am3517evm/am3517evm.c +++ b/board/logicpd/am3517evm/am3517evm.c @@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void) */ int misc_init_r(void) { - u32 reset; - omap_die_id_display(); am3517_evm_musb_init(); - /* ensure that the Ethernet module is out of reset */ - reset = readl(AM3517_IP_SW_RESET); - reset &= (~CPGMACSS_SW_RST); - writel(reset, AM3517_IP_SW_RESET); - return 0; } @@ -142,7 +135,6 @@ void set_muxconf_regs(void) MUX_AM3517EVM(); } - #if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET) int board_eth_init(struct bd_info *bis) {
The ethernet controller is DM compliant, and the device tree defines it. There is no need to manually handle pulling the ethernet out of reset. Signed-off-by: Adam Ford <aford173@gmail.com>