| Message ID | 20220203014929.486753-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | 9a8996df050dc20ef6954df077186400cb62622e |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | ARM: dts: stm32: Move vdd_io extras into Avenger96 extras | expand |
Hi Marek On 2/3/22 02:49, Marek Vasut wrote: > The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, > as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these > extras to Avenger96 u-boot DT extras. > > Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ > arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > index 4b1dbf08387..dd6be7fc3c7 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > @@ -95,3 +95,7 @@ > u-boot,force-b-session-valid; > hnp-srp-disable; > }; > + > +&vdd_io { > + u-boot,dm-spl; > +}; > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > index ff9ca625bf5..704939d18ae 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > @@ -195,10 +195,6 @@ > u-boot,dm-spl; > }; > > -&vdd_io { > - u-boot,dm-spl; > -}; > - > &vdd_usb { > u-boot,dm-spl; > }; Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
Hi, On 2/3/22 02:49, Marek Vasut wrote: > The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, > as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these > extras to Avenger96 u-boot DT extras. > > Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ > arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 2/10/22 17:32, Patrick DELAUNAY wrote: > Hi, Hi, > On 2/3/22 02:49, Marek Vasut wrote: >> The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, >> as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these >> extras to Avenger96 u-boot DT extras. >> >> Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR >> recovery") >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ >> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- >> 2 files changed, 4 insertions(+), 4 deletions(-) > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> This seems to have been missed and should be part of this upcoming release.
Hi Marek On 3/11/22 10:19, Marek Vasut wrote: > On 2/10/22 17:32, Patrick DELAUNAY wrote: >> Hi, > > Hi, > >> On 2/3/22 02:49, Marek Vasut wrote: >>> The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, >>> as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these >>> extras to Avenger96 u-boot DT extras. >>> >>> Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >>> --- >>> arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ >>> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> >> >> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > This seems to have been missed and should be part of this upcoming release. A pull request will be send next week. Thanks Patrice
On 3/11/22 11:14, Patrice CHOTARD wrote: > Hi Marek Hi, > On 3/11/22 10:19, Marek Vasut wrote: >> On 2/10/22 17:32, Patrick DELAUNAY wrote: >>> Hi, >> >> Hi, >> >>> On 2/3/22 02:49, Marek Vasut wrote: >>>> The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, >>>> as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these >>>> extras to Avenger96 u-boot DT extras. >>>> >>>> Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >>>> --- >>>> arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ >>>> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> >>> >>> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> >> This seems to have been missed and should be part of this upcoming release. > > A pull request will be send next week. Thank you !
Hi Marek On 2/3/22 02:49, Marek Vasut wrote: > The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, > as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these > extras to Avenger96 u-boot DT extras. > > Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ > arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > index 4b1dbf08387..dd6be7fc3c7 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > @@ -95,3 +95,7 @@ > u-boot,force-b-session-valid; > hnp-srp-disable; > }; > + > +&vdd_io { > + u-boot,dm-spl; > +}; > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > index ff9ca625bf5..704939d18ae 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > @@ -195,10 +195,6 @@ > u-boot,dm-spl; > }; > > -&vdd_io { > - u-boot,dm-spl; > -}; > - > &vdd_usb { > u-boot,dm-spl; > }; Applied to u-boot-stm32 Thanks Patrice
On 3/15/22 09:16, Patrice CHOTARD wrote: > Hi Marek > > On 2/3/22 02:49, Marek Vasut wrote: >> The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, >> as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these >> extras to Avenger96 u-boot DT extras. >> >> Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ >> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi >> index 4b1dbf08387..dd6be7fc3c7 100644 >> --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi >> +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi >> @@ -95,3 +95,7 @@ >> u-boot,force-b-session-valid; >> hnp-srp-disable; >> }; >> + >> +&vdd_io { >> + u-boot,dm-spl; >> +}; >> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi >> index ff9ca625bf5..704939d18ae 100644 >> --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi >> +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi >> @@ -195,10 +195,6 @@ >> u-boot,dm-spl; >> }; >> >> -&vdd_io { >> - u-boot,dm-spl; >> -}; >> - >> &vdd_usb { >> u-boot,dm-spl; >> }; > Applied to u-boot-stm32 > This is for current release.
diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi index 4b1dbf08387..dd6be7fc3c7 100644 --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi @@ -95,3 +95,7 @@ u-boot,force-b-session-valid; hnp-srp-disable; }; + +&vdd_io { + u-boot,dm-spl; +}; diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi index ff9ca625bf5..704939d18ae 100644 --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi @@ -195,10 +195,6 @@ u-boot,dm-spl; }; -&vdd_io { - u-boot,dm-spl; -}; - &vdd_usb { u-boot,dm-spl; };
The vdd_io regulator is present only on DHCOR SoM configured for 1V8 IO, as populated on Avenger96, but not present on 3V3 DHCOR SoM. Move these extras to Avenger96 u-boot DT extras. Fixes: 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") Signed-off-by: Marek Vasut <marex@denx.de> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> --- arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 4 ++++ arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)