diff mbox series

[v2,05/25] phy: cadence: Sierra: Move all reset_control_get*() to a separate function

Message ID 20220128081152.14901-6-a-govindraju@ti.com
State Accepted
Commit c1c1b345b1bd06328c9f16225ebbceb6f165bbb2
Delegated to: Tom Rini
Headers show
Series SIERRA: Add support for Mulitlink Configuration | expand

Commit Message

Aswath Govindraju Jan. 28, 2022, 8:11 a.m. UTC 
From: Kishon Vijay Abraham I <kishon@ti.com>

No functional change. Group devm_reset_control_get() and
devm_reset_control_get_optional() to a separate function.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 drivers/phy/cadence/phy-cadence-sierra.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Tom Rini Feb. 8, 2022, 5:34 p.m. UTC | #1 
On Fri, Jan 28, 2022 at 01:41:32PM +0530, Aswath Govindraju wrote:

> From: Kishon Vijay Abraham I <kishon@ti.com>
> 
> No functional change. Group devm_reset_control_get() and
> devm_reset_control_get_optional() to a separate function.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
index d07cf1d97df2..eaa32939c1c2 100644
--- a/drivers/phy/cadence/phy-cadence-sierra.c
+++ b/drivers/phy/cadence/phy-cadence-sierra.c
@@ -480,6 +480,21 @@  static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
 	return 0;
 }
 
+static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
+				      struct udevice *dev)
+{
+	struct reset_control *rst;
+
+	rst = devm_reset_control_get(dev, "sierra_reset");
+	if (IS_ERR(rst)) {
+		dev_err(dev, "failed to get reset\n");
+		return PTR_ERR(rst);
+	}
+	sp->phy_rst = rst;
+
+	return 0;
+}
+
 static int cdns_sierra_phy_probe(struct udevice *dev)
 {
 	struct cdns_sierra_phy *sp = dev_get_priv(dev);
@@ -520,6 +535,10 @@  static int cdns_sierra_phy_probe(struct udevice *dev)
 		return PTR_ERR(sp->phy_rst);
 	}
 
+	ret = cdns_sierra_phy_get_resets(sp, dev);
+	if (ret)
+		return ret;
+
 	ret = clk_prepare_enable(sp->clk);
 	if (ret)
 		return ret;