| Message ID | 20220125094846.14504-1-mibodhi@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver | expand |
On 1/25/22 10:48, Tony Dinh wrote: > The Pogoplug V4 board has the network chip Marvell 88E1118R. So to > properly configure the network, enable CONFIG_PHY_MARVELL to activate > the driver M88E1118R. > > - This patch depends on the series: > https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/ > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> I was wondering, how all this "magically" works without the Marvell PHY driver being involved. ;) So: Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > > configs/pogo_v4_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > index 5490067b9e..1cf409c834 100644 > --- a/configs/pogo_v4_defconfig > +++ b/configs/pogo_v4_defconfig > @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y > CONFIG_MVEBU_MMC=y > CONFIG_MTD=y > CONFIG_MTD_RAW_NAND=y > +CONFIG_PHY_MARVELL=y > CONFIG_DM_ETH=y > CONFIG_MVGBE=y > CONFIG_MII=y Viele Grüße, Stefan Roese
Hi Stefan, On Tue, Jan 25, 2022 at 7:49 AM Stefan Roese <sr@denx.de> wrote: > > On 1/25/22 10:48, Tony Dinh wrote: > > The Pogoplug V4 board has the network chip Marvell 88E1118R. So to > > properly configure the network, enable CONFIG_PHY_MARVELL to activate > > the driver M88E1118R. > > > > - This patch depends on the series: > > https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/ > > > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> > > I was wondering, how all this "magically" works without the Marvell PHY > driver being involved. ;) So: I was wondering the same thing :) so I traced the mvgbe uclass code calling sequence. It sets up the network in the same way for Marvell network chips used in Kirkwood boards so the network was brought up successfully. And it is because the driver .config hook falls back to the genphy_config() in drivers/net/phy/phy.c. And there is enough there for the network configuration. Hypothetically, if we encountered an unknown chip, it still works in Gbit mode. However, the specific settings such as RGMII and LED are done by the driver .config and .startup hook if the Marvell PHY driver is enabled. Initially, I thought if there is info in the DTS (or we could add more), then this mvgbe uclass could do the work as the same as the driver, too. But things such as phy-mode, speed, and duplex... must be added to the DTS to make that happen. And it is counterproductive when we already have the driver for that. And thank you, Marek, and Pali for reviewing and critics. After many years of absence from u-boot, I got up to speed again a lot easier thanks to your comments! Thanks, Tony > Reviewed-by: Stefan Roese <sr@denx.de> > > Thanks, > Stefan > > > --- > > > > configs/pogo_v4_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > > index 5490067b9e..1cf409c834 100644 > > --- a/configs/pogo_v4_defconfig > > +++ b/configs/pogo_v4_defconfig > > @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y > > CONFIG_MVEBU_MMC=y > > CONFIG_MTD=y > > CONFIG_MTD_RAW_NAND=y > > +CONFIG_PHY_MARVELL=y > > CONFIG_DM_ETH=y > > CONFIG_MVGBE=y > > CONFIG_MII=y > > Viele Grüße, > Stefan Roese > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
On 1/25/22 10:48, Tony Dinh wrote: > The Pogoplug V4 board has the network chip Marvell 88E1118R. So to > properly configure the network, enable CONFIG_PHY_MARVELL to activate > the driver M88E1118R. > > - This patch depends on the series: > https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/ > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> Applied to u-boot-marvell/master Thanks, Stefan > --- > > configs/pogo_v4_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > index 5490067b9e..1cf409c834 100644 > --- a/configs/pogo_v4_defconfig > +++ b/configs/pogo_v4_defconfig > @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y > CONFIG_MVEBU_MMC=y > CONFIG_MTD=y > CONFIG_MTD_RAW_NAND=y > +CONFIG_PHY_MARVELL=y > CONFIG_DM_ETH=y > CONFIG_MVGBE=y > CONFIG_MII=y Viele Grüße, Stefan Roese
diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig index 5490067b9e..1cf409c834 100644 --- a/configs/pogo_v4_defconfig +++ b/configs/pogo_v4_defconfig @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y CONFIG_MVEBU_MMC=y CONFIG_MTD=y CONFIG_MTD_RAW_NAND=y +CONFIG_PHY_MARVELL=y CONFIG_DM_ETH=y CONFIG_MVGBE=y CONFIG_MII=y
The Pogoplug V4 board has the network chip Marvell 88E1118R. So to properly configure the network, enable CONFIG_PHY_MARVELL to activate the driver M88E1118R. - This patch depends on the series: https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/ Signed-off-by: Tony Dinh <mibodhi@gmail.com> --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+)