diff mbox series

[v2,2/2] doc: board: avoid ambiguous names for axy17lte

Message ID 20220111180647.73181-2-henrik@grimler.se
State Accepted
Delegated to: Minkyu Kang
Headers show
Series [v2,1/2] board: samsung: fix menu entries for a{3,7}y17lte | expand

Commit Message

Henrik Grimler Jan. 11, 2022, 6:06 p.m. UTC
Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to
SM-J{3,5,7}20 or SM-T{3,5,7}20.

Also fix a5y17lte->a7y17lte for SM-A720.

Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
of 2017 (a5y17lte)")
Signed-off-by: Henrik Grimler <henrik@grimler.se>
Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes since v1: fix a5y17lte->a7y17lte, pointed out by Dzmitry, and
add reviewed-by tag.
---
 doc/board/samsung/axy17lte.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jaehoon Chung Jan. 11, 2022, 11:07 p.m. UTC | #1
On 1/12/22 3:06 AM, Henrik Grimler wrote:
> Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to
> SM-J{3,5,7}20 or SM-T{3,5,7}20.
> 
> Also fix a5y17lte->a7y17lte for SM-A720.
> 
> Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
> of 2017 (a5y17lte)")
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> Changes since v1: fix a5y17lte->a7y17lte, pointed out by Dzmitry, and
> add reviewed-by tag.
> ---
>  doc/board/samsung/axy17lte.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/board/samsung/axy17lte.rst b/doc/board/samsung/axy17lte.rst
> index 511cd57a22f5..b13a19af8a35 100644
> --- a/doc/board/samsung/axy17lte.rst
> +++ b/doc/board/samsung/axy17lte.rst
> @@ -14,7 +14,7 @@ It is loaded as an Android boot image through SBOOT.
>  
>  Phone specs
>  -----------
> -A3 (SM-320) (a3y17lte)
> +A3 (SM-A320) (a3y17lte)
>  ^^^^^^^^^^^^^^^^^^^^^^
>  - 4.7 AMOLED display
>  - Exynos 7870 SoC
> @@ -23,7 +23,7 @@ A3 (SM-320) (a3y17lte)
>  
>  .. A3 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
>  
> -A5 (SM-520) (a5y17lte)
> +A5 (SM-A520) (a5y17lte)
>  ^^^^^^^^^^^^^^^^^^^^^^
>  - 5.2 AMOLED display
>  - Exynos 7880 SoC
> @@ -32,7 +32,7 @@ A5 (SM-520) (a5y17lte)
>  
>  .. A5 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
>  
> -A7 (SM-720) (a5y17lte)
> +A7 (SM-A720) (a7y17lte)
>  ^^^^^^^^^^^^^^^^^^^^^^
>  - 5.7 AMOLED display
>  - Exynos 7880 SoC
>
Minkyu Kang Jan. 13, 2022, 5:38 a.m. UTC | #2
Dear Henrik Grmler,

On Wed, 12 Jan 2022 at 08:07, Jaehoon Chung <jh80.chung@samsung.com> wrote:

> On 1/12/22 3:06 AM, Henrik Grimler wrote:
> > Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to
> > SM-J{3,5,7}20 or SM-T{3,5,7}20.
> >
> > Also fix a5y17lte->a7y17lte for SM-A720.
> >
> > Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
> > of 2017 (a5y17lte)")
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com>
>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> Best Regards,
> Jaehoon Chung
>
>
applied to u-boot-samsung.
diff mbox series

Patch

diff --git a/doc/board/samsung/axy17lte.rst b/doc/board/samsung/axy17lte.rst
index 511cd57a22f5..b13a19af8a35 100644
--- a/doc/board/samsung/axy17lte.rst
+++ b/doc/board/samsung/axy17lte.rst
@@ -14,7 +14,7 @@  It is loaded as an Android boot image through SBOOT.
 
 Phone specs
 -----------
-A3 (SM-320) (a3y17lte)
+A3 (SM-A320) (a3y17lte)
 ^^^^^^^^^^^^^^^^^^^^^^
 - 4.7 AMOLED display
 - Exynos 7870 SoC
@@ -23,7 +23,7 @@  A3 (SM-320) (a3y17lte)
 
 .. A3 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
 
-A5 (SM-520) (a5y17lte)
+A5 (SM-A520) (a5y17lte)
 ^^^^^^^^^^^^^^^^^^^^^^
 - 5.2 AMOLED display
 - Exynos 7880 SoC
@@ -32,7 +32,7 @@  A5 (SM-520) (a5y17lte)
 
 .. A5 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
 
-A7 (SM-720) (a5y17lte)
+A7 (SM-A720) (a7y17lte)
 ^^^^^^^^^^^^^^^^^^^^^^
 - 5.7 AMOLED display
 - Exynos 7880 SoC