Message ID | 20220111180647.73181-1-henrik@grimler.se |
---|---|
State | Accepted |
Commit | 00809bd4e9e933bcb3c9b8fbd0e456cff18497b1 |
Delegated to: | Minkyu Kang |
Headers | show |
Series | [v2,1/2] board: samsung: fix menu entries for a{3,7}y17lte | expand |
On 1/12/22 3:06 AM, Henrik Grimler wrote: > a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also > should select PINCTRL_EXYNOS78x0, not the (non-existent) > PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880. > > Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series > of 2017 (a5y17lte)") > Signed-off-by: Henrik Grimler <henrik@grimler.se> > Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > Changes since v1: none, added Dzmitry's reviewed-by tag. > --- > arch/arm/mach-exynos/Kconfig | 6 +++--- > board/samsung/axy17lte/Kconfig | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 7f3aee571290..32b81728c389 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -161,7 +161,7 @@ config TARGET_A5Y17LTE > select SUPPORT_SPL > > config TARGET_A7Y17LTE > - bool "Samsung SM-A520F board" > + bool "Samsung SM-A720F board" > select ARM64 > select CLK_EXYNOS > select OF_CONTROL > @@ -170,12 +170,12 @@ config TARGET_A7Y17LTE > select SUPPORT_SPL > > config TARGET_A3Y17LTE > - bool "Samsung SM-A520F board" > + bool "Samsung SM-A320F board" > select ARM64 > select CLK_EXYNOS > select OF_CONTROL > select PINCTRL > - select PINCTRL_EXYNOS7880 > + select PINCTRL_EXYNOS78x0 > select SUPPORT_SPL > > endchoice > diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig > index 2abf8e7acfca..a018547ff5d4 100644 > --- a/board/samsung/axy17lte/Kconfig > +++ b/board/samsung/axy17lte/Kconfig > @@ -27,7 +27,7 @@ if TARGET_A7Y17LTE > config SYS_BOARD > default "axy17lte" > help > - a5y17lte is a production board for SM-A520F phone on Exynos7880 SoC. > + a7y17lte is a production board for SM-A720F phone on Exynos7880 SoC. > > config SYS_VENDOR > default "samsung" > @@ -44,7 +44,7 @@ if TARGET_A3Y17LTE > config SYS_BOARD > default "axy17lte" > help > - a3y17lte is a production board for SM-A520F phone on Exynos7880 SoC. > + a3y17lte is a production board for SM-A320F phone on Exynos7870 SoC. > > config SYS_VENDOR > default "samsung" > > base-commit: a14af7216a220fe8f1b2a5308ed632abe6f9f97f >
Dear Henrik Grimler On Wed, 12 Jan 2022 at 08:06, Jaehoon Chung <jh80.chung@samsung.com> wrote: > On 1/12/22 3:06 AM, Henrik Grimler wrote: > > a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also > > should select PINCTRL_EXYNOS78x0, not the (non-existent) > > PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880. > > > > Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series > > of 2017 (a5y17lte)") > > Signed-off-by: Henrik Grimler <henrik@grimler.se> > > Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > Best Regards, > Jaehoon Chung > > > --- > > Changes since v1: none, added Dzmitry's reviewed-by tag. > > --- > > arch/arm/mach-exynos/Kconfig | 6 +++--- > > board/samsung/axy17lte/Kconfig | 4 ++-- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > applied to u-boot-samsung.
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 7f3aee571290..32b81728c389 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -161,7 +161,7 @@ config TARGET_A5Y17LTE select SUPPORT_SPL config TARGET_A7Y17LTE - bool "Samsung SM-A520F board" + bool "Samsung SM-A720F board" select ARM64 select CLK_EXYNOS select OF_CONTROL @@ -170,12 +170,12 @@ config TARGET_A7Y17LTE select SUPPORT_SPL config TARGET_A3Y17LTE - bool "Samsung SM-A520F board" + bool "Samsung SM-A320F board" select ARM64 select CLK_EXYNOS select OF_CONTROL select PINCTRL - select PINCTRL_EXYNOS7880 + select PINCTRL_EXYNOS78x0 select SUPPORT_SPL endchoice diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig index 2abf8e7acfca..a018547ff5d4 100644 --- a/board/samsung/axy17lte/Kconfig +++ b/board/samsung/axy17lte/Kconfig @@ -27,7 +27,7 @@ if TARGET_A7Y17LTE config SYS_BOARD default "axy17lte" help - a5y17lte is a production board for SM-A520F phone on Exynos7880 SoC. + a7y17lte is a production board for SM-A720F phone on Exynos7880 SoC. config SYS_VENDOR default "samsung" @@ -44,7 +44,7 @@ if TARGET_A3Y17LTE config SYS_BOARD default "axy17lte" help - a3y17lte is a production board for SM-A520F phone on Exynos7880 SoC. + a3y17lte is a production board for SM-A320F phone on Exynos7870 SoC. config SYS_VENDOR default "samsung"