diff mbox series

[v2,2/3] misc: atsha204a: add delay after sending the message

Message ID 20220111180531.168596-3-adrian.fiergolski@fastree3d.com
State Accepted
Commit e4662716fbbe4ce717cbf9f193564943ffe355f8
Delegated to: Heiko Schocher
Headers show
Series misc: atsha204a: bug fixes | expand

Commit Message

Adrian Fiergolski Jan. 11, 2022, 6:05 p.m. UTC
Once request is sent, and before receiving a response, the delay is required.
This patch fixes missing delay for before first response try.

Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
---
 drivers/misc/atsha204a-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek BehĂșn Jan. 11, 2022, 6:54 p.m. UTC | #1
On Tue, 11 Jan 2022 19:05:30 +0100
Adrian Fiergolski <adrian.fiergolski@fastree3d.com> wrote:

> Once request is sent, and before receiving a response, the delay is required.
> This patch fixes missing delay for before first response try.
> 
> Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>

Reviewed-by: Marek BehĂșn <marek.behun@nic.cz>
diff mbox series

Patch

diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
index 9d069fb33c..d264477927 100644
--- a/drivers/misc/atsha204a-i2c.c
+++ b/drivers/misc/atsha204a-i2c.c
@@ -280,6 +280,7 @@  static int atsha204a_transaction(struct udevice *dev, struct atsha204a_req *req,
 	}
 
 	do {
+		udelay(ATSHA204A_EXECTIME);
 		res = atsha204a_recv_resp(dev, resp);
 		if (!res || res == -EMSGSIZE || res == -EBADMSG)
 			break;
@@ -287,7 +288,6 @@  static int atsha204a_transaction(struct udevice *dev, struct atsha204a_req *req,
 		debug("ATSHA204A transaction polling for response "
 		      "(timeout = %d)\n", timeout);
 
-		udelay(ATSHA204A_EXECTIME);
 		timeout -= ATSHA204A_EXECTIME;
 	} while (timeout > 0);