imx8mm_beacon/imx8mn_beacon: Update build instructions

With binman generating flash.bin, it's not longer necessary to
specify either the location of ATF nor is it necessary to
specify building flash.bin, so let's update the build instructions
to remove those.  While in here, update the revision of ATF and
DDR firmware so both Mini and Nano reference the same revision.

Signed-off-by: Adam Ford <aford173@gmail.com>

Hello Adam,

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Adam Ford
> Sent: Tuesday, January 11, 2022 2:51 PM
> To: u-boot@lists.denx.de
> Cc: sbabic@denx.de; trini@konsulko.com; aford@beaconembedded.com; Adam Ford
> <aford173@gmail.com>
> Subject: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> 
> With binman generating flash.bin, it's not longer necessary to
> specify either the location of ATF nor is it necessary to
> specify building flash.bin, so let's update the build instructions
> to remove those.  While in here, update the revision of ATF and
> DDR firmware so both Mini and Nano reference the same revision.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/board/beacon/imx8mm/README b/board/beacon/imx8mm/README
> index 03d9412f0d..200549d924 100644
> --- a/board/beacon/imx8mm/README
> +++ b/board/beacon/imx8mm/README
> @@ -12,21 +12,21 @@ Get and Build the ARM Trusted firmware
>  Note: $(srctree) is U-Boot source directory
> 
>  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> -$ git checkout imx_5.4.70_2.3.0
> +$ git checkout lf_v2.4

Perhaps, it's better to advise the [lf-5.10.72-2.2.0] tag here instead of branch?

>  $ make PLAT=imx8mm bl31 CROSS_COMPILE=aarch64-linux-gnu-
>  $ cp build/imx8mm/release/bl31.bin $(srctree)
> 
>  Get the DDR firmware
>  ====================
> -$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.5.bin
> -$ chmod +x firmware-imx-8.5.bin
> -$ ./firmware-imx-8.5
> -$ cp firmware-imx-8.5/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> +$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin

There is a newer version of DDR firmware available from NXP (8.14), perhaps
you can recommend it here instead of 8.9.

Link: https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.14.bin

> +$ chmod +x firmware-imx-8.9.bin
> +$ ./firmware-imx-8.9
> +$ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> 
>  Build U-Boot
>  ============
>  $ make imx8mm_beacon_defconfig
> -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu-
> +$ make CROSS_COMPILE=aarch64-linux-gnu-
> 
>  Burn U-Boot to microSD Card
>  ===========================
> diff --git a/board/beacon/imx8mn/README b/board/beacon/imx8mn/README
> index a9eddd4e64..7e5d1545e6 100644
> --- a/board/beacon/imx8mn/README
> +++ b/board/beacon/imx8mn/README
> @@ -12,7 +12,7 @@ Get and Build the ARM Trusted firmware
>  Note: $(srctree) is U-Boot source directory
> 
>  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> -$ git checkout imx_5.4.47_2.2.0
> +$ git checkout lf_v2.4

Same as for Mini above.

>  $ make PLAT=imx8mn bl31 CROSS_COMPILE=aarch64-linux-gnu-
>  $ cp build/imx8mm/release/bl31.bin $(srctree)
> 
> @@ -26,7 +26,7 @@ $ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin
> $(srctree)
>  Build U-Boot
>  ============
>  $ make imx8mn_beacon_defconfig
> -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x960000
> +$ make CROSS_COMPILE=aarch64-linux-gnu-
> 
>  Burn U-Boot to microSD Card
>  ===========================
> --
> 2.32.0

-- andrey

Hi Andrey

On Tue, 2022-01-11 at 14:23 +0000, ZHIZHIKIN Andrey wrote:
> Hello Adam,
> 
> > -----Original Message-----
> > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Adam Ford
> > Sent: Tuesday, January 11, 2022 2:51 PM
> > To: u-boot@lists.denx.de
> > Cc: sbabic@denx.de; trini@konsulko.com; aford@beaconembedded.com; Adam Ford
> > <aford173@gmail.com>
> > Subject: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> > 
> > With binman generating flash.bin, it's not longer necessary to
> > specify either the location of ATF nor is it necessary to
> > specify building flash.bin, so let's update the build instructions
> > to remove those.  While in here, update the revision of ATF and
> > DDR firmware so both Mini and Nano reference the same revision.
> > 
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > 
> > diff --git a/board/beacon/imx8mm/README b/board/beacon/imx8mm/README
> > index 03d9412f0d..200549d924 100644
> > --- a/board/beacon/imx8mm/README
> > +++ b/board/beacon/imx8mm/README
> > @@ -12,21 +12,21 @@ Get and Build the ARM Trusted firmware
> >  Note: $(srctree) is U-Boot source directory
> > 
> >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > -$ git checkout imx_5.4.70_2.3.0
> > +$ git checkout lf_v2.4
> 
> Perhaps, it's better to advise the [lf-5.10.72-2.2.0] tag here instead of branch?
> 
> >  $ make PLAT=imx8mm bl31 CROSS_COMPILE=aarch64-linux-gnu-
> >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > 
> >  Get the DDR firmware
> >  ====================
> > -$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.5.bin
> > -$ chmod +x firmware-imx-8.5.bin
> > -$ ./firmware-imx-8.5
> > -$ cp firmware-imx-8.5/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > +$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin
> 
> There is a newer version of DDR firmware available from NXP (8.14), perhaps
> you can recommend it here instead of 8.9.
> 
> Link: https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.14.bin

I don't think anything about the DDR firmware actually changed in a long time. There are other parts within
that firmware-imx package which did change. However, they are irrelevant for U-Boot.

> > +$ chmod +x firmware-imx-8.9.bin
> > +$ ./firmware-imx-8.9
> > +$ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > 
> >  Build U-Boot
> >  ============
> >  $ make imx8mm_beacon_defconfig
> > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu-
> > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > 
> >  Burn U-Boot to microSD Card
> >  ===========================
> > diff --git a/board/beacon/imx8mn/README b/board/beacon/imx8mn/README
> > index a9eddd4e64..7e5d1545e6 100644
> > --- a/board/beacon/imx8mn/README
> > +++ b/board/beacon/imx8mn/README
> > @@ -12,7 +12,7 @@ Get and Build the ARM Trusted firmware
> >  Note: $(srctree) is U-Boot source directory
> > 
> >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > -$ git checkout imx_5.4.47_2.2.0
> > +$ git checkout lf_v2.4
> 
> Same as for Mini above.
> 
> >  $ make PLAT=imx8mn bl31 CROSS_COMPILE=aarch64-linux-gnu-
> >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > 
> > @@ -26,7 +26,7 @@ $ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin
> > $(srctree)
> >  Build U-Boot
> >  ============
> >  $ make imx8mn_beacon_defconfig
> > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x960000
> > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > 
> >  Burn U-Boot to microSD Card
> >  ===========================
> > --
> > 2.32.0
> 
> -- andrey

Cheers

Marcel

Hello Marcel,

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Marcel Ziswiler
> Sent: Wednesday, January 12, 2022 10:28 AM
> To: aford173@gmail.com; u-boot@lists.denx.de; andrey.zhizhikin@leica-
> geosystems.com
> Cc: trini@konsulko.com; aford@beaconembedded.com; sbabic@denx.de
> Subject: Re: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> 
> Hi Andrey
> 
> On Tue, 2022-01-11 at 14:23 +0000, ZHIZHIKIN Andrey wrote:
> > Hello Adam,
> >
> > > -----Original Message-----
> > > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Adam Ford
> > > Sent: Tuesday, January 11, 2022 2:51 PM
> > > To: u-boot@lists.denx.de
> > > Cc: sbabic@denx.de; trini@konsulko.com; aford@beaconembedded.com; Adam Ford
> > > <aford173@gmail.com>
> > > Subject: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> > >
> > > With binman generating flash.bin, it's not longer necessary to
> > > specify either the location of ATF nor is it necessary to
> > > specify building flash.bin, so let's update the build instructions
> > > to remove those.  While in here, update the revision of ATF and
> > > DDR firmware so both Mini and Nano reference the same revision.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/board/beacon/imx8mm/README b/board/beacon/imx8mm/README
> > > index 03d9412f0d..200549d924 100644
> > > --- a/board/beacon/imx8mm/README
> > > +++ b/board/beacon/imx8mm/README
> > > @@ -12,21 +12,21 @@ Get and Build the ARM Trusted firmware
> > >  Note: $(srctree) is U-Boot source directory
> > >
> > >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > > -$ git checkout imx_5.4.70_2.3.0
> > > +$ git checkout lf_v2.4
> >
> > Perhaps, it's better to advise the [lf-5.10.72-2.2.0] tag here instead of
> branch?
> >
> > >  $ make PLAT=imx8mm bl31 CROSS_COMPILE=aarch64-linux-gnu-
> > >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > >
> > >  Get the DDR firmware
> > >  ====================
> > > -$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.5.bin
> > > -$ chmod +x firmware-imx-8.5.bin
> > > -$ ./firmware-imx-8.5
> > > -$ cp firmware-imx-8.5/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > > +$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin
> >
> > There is a newer version of DDR firmware available from NXP (8.14), perhaps
> > you can recommend it here instead of 8.9.
> >
> > Link: https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.14.bin
> 
> I don't think anything about the DDR firmware actually changed in a long time.
> There are other parts within
> that firmware-imx package which did change. However, they are irrelevant for U-
> Boot.

True, I've just compared SHA256 for all lpddr4* files from 8.5, 8.9 and 8.14 - they
do match.

This suggestion would be valid only if the consistency with Yocto image is desired
(Yocto does use the firmware version based on the archive name), but technically it
is not required to use the latest drop from NXP here. If this is not needed - this
comment of mine is irrelevant here.

> 
> > > +$ chmod +x firmware-imx-8.9.bin
> > > +$ ./firmware-imx-8.9
> > > +$ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > >
> > >  Build U-Boot
> > >  ============
> > >  $ make imx8mm_beacon_defconfig
> > > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu-
> > > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > >
> > >  Burn U-Boot to microSD Card
> > >  ===========================
> > > diff --git a/board/beacon/imx8mn/README b/board/beacon/imx8mn/README
> > > index a9eddd4e64..7e5d1545e6 100644
> > > --- a/board/beacon/imx8mn/README
> > > +++ b/board/beacon/imx8mn/README
> > > @@ -12,7 +12,7 @@ Get and Build the ARM Trusted firmware
> > >  Note: $(srctree) is U-Boot source directory
> > >
> > >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > > -$ git checkout imx_5.4.47_2.2.0
> > > +$ git checkout lf_v2.4
> >
> > Same as for Mini above.
> >
> > >  $ make PLAT=imx8mn bl31 CROSS_COMPILE=aarch64-linux-gnu-
> > >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > >
> > > @@ -26,7 +26,7 @@ $ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin
> > > $(srctree)
> > >  Build U-Boot
> > >  ============
> > >  $ make imx8mn_beacon_defconfig
> > > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x960000
> > > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > >
> > >  Burn U-Boot to microSD Card
> > >  ===========================
> > > --
> > > 2.32.0
> >
> > -- andrey
> 
> Cheers
> 
> Marcel

-- andrey

On Wed, Jan 12, 2022 at 5:10 AM ZHIZHIKIN Andrey
<andrey.zhizhikin@leica-geosystems.com> wrote:
>
> Hello Marcel,
>
> > -----Original Message-----
> > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Marcel Ziswiler
> > Sent: Wednesday, January 12, 2022 10:28 AM
> > To: aford173@gmail.com; u-boot@lists.denx.de; andrey.zhizhikin@leica-
> > geosystems.com
> > Cc: trini@konsulko.com; aford@beaconembedded.com; sbabic@denx.de
> > Subject: Re: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> >
> > Hi Andrey
> >
> > On Tue, 2022-01-11 at 14:23 +0000, ZHIZHIKIN Andrey wrote:
> > > Hello Adam,
> > >
> > > > -----Original Message-----
> > > > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Adam Ford
> > > > Sent: Tuesday, January 11, 2022 2:51 PM
> > > > To: u-boot@lists.denx.de
> > > > Cc: sbabic@denx.de; trini@konsulko.com; aford@beaconembedded.com; Adam Ford
> > > > <aford173@gmail.com>
> > > > Subject: [PATCH] imx8mm_beacon/imx8mn_beacon: Update build instructions
> > > >
> > > > With binman generating flash.bin, it's not longer necessary to
> > > > specify either the location of ATF nor is it necessary to
> > > > specify building flash.bin, so let's update the build instructions
> > > > to remove those.  While in here, update the revision of ATF and
> > > > DDR firmware so both Mini and Nano reference the same revision.
> > > >
> > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > >
> > > > diff --git a/board/beacon/imx8mm/README b/board/beacon/imx8mm/README
> > > > index 03d9412f0d..200549d924 100644
> > > > --- a/board/beacon/imx8mm/README
> > > > +++ b/board/beacon/imx8mm/README
> > > > @@ -12,21 +12,21 @@ Get and Build the ARM Trusted firmware
> > > >  Note: $(srctree) is U-Boot source directory
> > > >
> > > >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > > > -$ git checkout imx_5.4.70_2.3.0
> > > > +$ git checkout lf_v2.4
> > >
> > > Perhaps, it's better to advise the [lf-5.10.72-2.2.0] tag here instead of
> > branch?

Using a tag makes sense.

> > >
> > > >  $ make PLAT=imx8mm bl31 CROSS_COMPILE=aarch64-linux-gnu-
> > > >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > > >
> > > >  Get the DDR firmware
> > > >  ====================
> > > > -$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.5.bin
> > > > -$ chmod +x firmware-imx-8.5.bin
> > > > -$ ./firmware-imx-8.5
> > > > -$ cp firmware-imx-8.5/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > > > +$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin
> > >
> > > There is a newer version of DDR firmware available from NXP (8.14), perhaps
> > > you can recommend it here instead of 8.9.
> > >
> > > Link: https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.14.bin
> >
> > I don't think anything about the DDR firmware actually changed in a long time.
> > There are other parts within
> > that firmware-imx package which did change. However, they are irrelevant for U-
> > Boot.
>
> True, I've just compared SHA256 for all lpddr4* files from 8.5, 8.9 and 8.14 - they
> do match.
>
> This suggestion would be valid only if the consistency with Yocto image is desired
> (Yocto does use the firmware version based on the archive name), but technically it
> is not required to use the latest drop from NXP here. If this is not needed - this
> comment of mine is irrelevant here.

For my purposes, I do not care about Yocto.
>
> >
> > > > +$ chmod +x firmware-imx-8.9.bin
> > > > +$ ./firmware-imx-8.9
> > > > +$ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
> > > >
> > > >  Build U-Boot
> > > >  ============
> > > >  $ make imx8mm_beacon_defconfig
> > > > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu-
> > > > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > > >
> > > >  Burn U-Boot to microSD Card
> > > >  ===========================
> > > > diff --git a/board/beacon/imx8mn/README b/board/beacon/imx8mn/README
> > > > index a9eddd4e64..7e5d1545e6 100644
> > > > --- a/board/beacon/imx8mn/README
> > > > +++ b/board/beacon/imx8mn/README
> > > > @@ -12,7 +12,7 @@ Get and Build the ARM Trusted firmware
> > > >  Note: $(srctree) is U-Boot source directory
> > > >
> > > >  $ git clone https://source.codeaurora.org/external/imx/imx-atf
> > > > -$ git checkout imx_5.4.47_2.2.0
> > > > +$ git checkout lf_v2.4
> > >
> > > Same as for Mini above.
> > >
> > > >  $ make PLAT=imx8mn bl31 CROSS_COMPILE=aarch64-linux-gnu-
> > > >  $ cp build/imx8mm/release/bl31.bin $(srctree)
> > > >
> > > > @@ -26,7 +26,7 @@ $ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin
> > > > $(srctree)
> > > >  Build U-Boot
> > > >  ============
> > > >  $ make imx8mn_beacon_defconfig
> > > > -$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x960000
> > > > +$ make CROSS_COMPILE=aarch64-linux-gnu-
> > > >
> > > >  Burn U-Boot to microSD Card
> > > >  ===========================
> > > > --
> > > > 2.32.0
> > >
> > > -- andrey
> >
> > Cheers
> >
> > Marcel
>
> -- andrey