| Message ID | 20220109152600.6076-3-jbx6244@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [v1,1/3] rockchip: serial: restyle the serial_rockchip.c driver | expand |
On Sun, 9 Jan 2022 at 08:26, Johan Jonker <jbx6244@gmail.com> wrote: > > The Rockchip serial driver depends on an enabled NS16550 driver, > so add select SYS_NS16550 to config ROCKCHIP_SERIAL. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > drivers/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Sun, Jan 9, 2022 at 8:56 PM Johan Jonker <jbx6244@gmail.com> wrote: > > The Rockchip serial driver depends on an enabled NS16550 driver, > so add select SYS_NS16550 to config ROCKCHIP_SERIAL. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > drivers/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > index 6c8fdda9..054bd21e 100644 > --- a/drivers/serial/Kconfig > +++ b/drivers/serial/Kconfig > @@ -737,6 +737,7 @@ config PL01X_SERIAL > config ROCKCHIP_SERIAL > bool "Rockchip on-chip UART support" > depends on DM_SERIAL && SPL_OF_PLATDATA > + select SYS_NS16550 Other places of rockchip code are implying and selecting the SYS_NS16550, so removing those would be part of this global select. Jagan.
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 6c8fdda9..054bd21e 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -737,6 +737,7 @@ config PL01X_SERIAL config ROCKCHIP_SERIAL bool "Rockchip on-chip UART support" depends on DM_SERIAL && SPL_OF_PLATDATA + select SYS_NS16550 help Select this to enable a debug UART for Rockchip devices when using CONFIG_SPL_OF_PLATDATA (i.e. a compiled-in device tree replacemenmt).
The Rockchip serial driver depends on an enabled NS16550 driver, so add select SYS_NS16550 to config ROCKCHIP_SERIAL. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)