diff mbox series

[v1,2/3] rockchip: serial: move driver alias to serial_rockchip.c

Message ID 20220109152600.6076-2-jbx6244@gmail.com
State Superseded
Delegated to: Kever Yang
Headers show
Series [v1,1/3] rockchip: serial: restyle the serial_rockchip.c driver | expand

Commit Message

Johan Jonker Jan. 9, 2022, 3:25 p.m. UTC
The Rockchip uart DT nodes have "snps,dw-apb-uart" as
fall back string. The driver ns16550.c has CONFIG_IS_ENABLED(OF_REAL)
as condition to of_match and does not copy dtplat data.
For TPL/SPL the driver serial_rockchip.c
is used. Move driver alias to correct driver.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 drivers/serial/ns16550.c         | 2 --
 drivers/serial/serial_rockchip.c | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Jan. 12, 2022, 8:04 p.m. UTC | #1
On Sun, 9 Jan 2022 at 08:26, Johan Jonker <jbx6244@gmail.com> wrote:
>
> The Rockchip uart DT nodes have "snps,dw-apb-uart" as
> fall back string. The driver ns16550.c has CONFIG_IS_ENABLED(OF_REAL)
> as condition to of_match and does not copy dtplat data.
> For TPL/SPL the driver serial_rockchip.c
> is used. Move driver alias to correct driver.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  drivers/serial/ns16550.c         | 2 --
>  drivers/serial/serial_rockchip.c | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 796ff165..a4220fd0 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -624,8 +624,6 @@  U_BOOT_DRIVER(ns16550_serial) = {
 #endif
 };
 
-DM_DRIVER_ALIAS(ns16550_serial, rockchip_rk3328_uart)
-DM_DRIVER_ALIAS(ns16550_serial, rockchip_rk3368_uart)
 DM_DRIVER_ALIAS(ns16550_serial, ti_da830_uart)
 #endif
 #endif /* SERIAL_PRESENT */
diff --git a/drivers/serial/serial_rockchip.c b/drivers/serial/serial_rockchip.c
index 0d1d9fff..22c7ac90 100644
--- a/drivers/serial/serial_rockchip.c
+++ b/drivers/serial/serial_rockchip.c
@@ -51,3 +51,5 @@  U_BOOT_DRIVER(rockchip_rk3288_uart) = {
 };
 DM_DRIVER_ALIAS(rockchip_rk3288_uart, rockchip_rk3066_uart)
 DM_DRIVER_ALIAS(rockchip_rk3288_uart, rockchip_rk3188_uart)
+DM_DRIVER_ALIAS(rockchip_rk3288_uart, rockchip_rk3328_uart)
+DM_DRIVER_ALIAS(rockchip_rk3288_uart, rockchip_rk3368_uart)