From patchwork Mon Jan 3 12:47:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1574752 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=HQlJ0pNb; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JSFvP3Xggz9tjv for ; Mon, 3 Jan 2022 23:49:53 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 64B0783515; Mon, 3 Jan 2022 13:48:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="HQlJ0pNb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 83C1380F68; Mon, 3 Jan 2022 13:48:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 84709830B9 for ; Mon, 3 Jan 2022 13:48:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoNdR6maVaEi0ceExVJMdMYy0KoPwwDL+eejg5zT8k1Kp+25cXW++1nGXvDf9eZQp0mTOOPBN/S9nhLqgnK6aLAttAqZsSvHol7GuNeA4Ug2lkWK8/65vfRqkDgFFD1jS7+y8MTE4her1lBNusK2vS3pLesqmwSmyMWx/Gc+4DEDuQSOihuuKOgG9f4TmXOT//f58WTSmkDeZ46BE3XLXXrqPS83d2FOm4XJF/7bp2Vzq4yQoNHcj+J5+5AOIzL6o4jKBbZQd27Onl/Xdam8H5OnSvb1HIG3aUHV69l5nHUS1vH2OxCHHrjM4d2RW9CbiOJLslLtSn8XYetAhFSeNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWCWOlFNouVH5ezN0q6TOC+H9o1LATNIznJmWZs6cV0=; b=f5Nn5cQOe7D2jUsAl0YQaIcnk7WzaUJs+p9Xw/E00MZiI2z+86kQ0I2eExREhK0o/wWCpjMfwqdeim8u8J9kQBcCxmtbuiI36DbPPUptbq9gSQkLWGtYXRPqfJF6P0wWcWurXIxNKyEx77T27myxmf0w5u3LL+STUP/7ud8nPluWKuZEPB1RQH38wj8cx2+/C1HEk54OTSIv42XpEDi8P0B91U5wmakjbt/GqlkX3fVlA8i+O+uP5oJBzx3zeMMoqeykRdx3Gb/PEzYkSTYOdSRgS04ruLj4g50pXYyZm99iEdeMN+II7mme6GQmDvKDPtV3idEqtMZgqWdVfcC1QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWCWOlFNouVH5ezN0q6TOC+H9o1LATNIznJmWZs6cV0=; b=HQlJ0pNbqBFI9pjX3yTK13HELl40fdMZKx/RKfaO23IuHgM0hB0LOfltL7UomMiGXHgKNCpTeEYHc0AXynAAIlOVZjmsA2TkX6JQkzq09BAYPfREgFX5oiMMxbIph04cBmBjGswjMWYQJmXBAmDxSoEmag5TvN//SnS0b3gmcb4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3711.eurprd04.prod.outlook.com (2603:10a6:803:18::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 3 Jan 2022 12:48:03 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::c84:1f0b:cc79:9226]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::c84:1f0b:cc79:9226%3]) with mapi id 15.20.4844.016; Mon, 3 Jan 2022 12:48:03 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Michael Walle , Tom Rini , Priyanka Jain , Li Yang , Biwen Li , Ramon Fried Subject: [PATCH v3 11/16] arm: dts: ls1028a-rdb: sync Ethernet device tree nodes with Linux Date: Mon, 3 Jan 2022 14:47:32 +0200 Message-Id: <20220103124737.1407985-12-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220103124737.1407985-1-vladimir.oltean@nxp.com> References: <20220103124737.1407985-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: AS9PR04CA0056.eurprd04.prod.outlook.com (2603:10a6:20b:46a::24) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf66dd54-18af-4cfe-5987-08d9ceb747d7 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3711:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:334; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OLshDKQEpMGDih3Csqean+kA/VvZjr54Vuq269Xipt47wuMKRM3UrEe1MdUrGC6upJPeYk/Se2XnBLguIbbKDwBYPThTzSjObGZQF6vWDDNch8+vEGW9Fal2GlXxu/DmsCCTDYYGenpJLvv1FjRm1pG3Y9/FyT4QIUDwCBLoMM5lNs8uTAlfCyhvxQxPOmv43IWehS8iKcrNwgrZVKjEvA5M2EY8jiDcroQfqdo28/SFaaKM79VveHulcwK7V6WekEgp+dEUPDgF/l5LtGcryFzMoEVzcWANKvgdnTx/uyf0zAgsTPt2rhmkIb2Ph6F3m89i/ETkTcOssKYTi0rhmukwqmlx0fJUf9SXKzhg32DdNGI8HVyM7uVu61jPf7yyTUS2TAf7sen6HituDXvgOeNpMuKf7UXirQLfJ35dZX8MbR9JJ16Exh+CtId/hJri0m6NS1ekRtxouFy3F15X70H0T2reD0eNNnQzqtq9wCI9QErKMo6ta8HhVXLS1CWmovq3CXA5XPSvIIZqT6hctb/v7BwaY+kgRuRypvpj4BKOjhsF7qCs53bOw3d1V/mwgMeH9ZL3LLOCltuQNXW4DNcGOzq5fFImvd916Cb4WGTqYYXOIgTER8/eD8iX5tfZ9e712fKfvjJzjPMMbFQaAr2lMsG3c63FFTUBrEWuAeYBuOJuanver5YgTFP3HfamblPbykQPshNnK1D1osah8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(44832011)(26005)(6512007)(8676002)(8936002)(316002)(2616005)(83380400001)(6486002)(4326008)(508600001)(6506007)(6916009)(186003)(2906002)(38350700002)(66556008)(66946007)(38100700002)(5660300002)(86362001)(52116002)(54906003)(1076003)(36756003)(6666004)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4TAiW2sN9tU8zNEbcmRZxAB1zUQqUOVdTy2uDNkrNXDDy8wxwk90qs9t2ZsRUTOYtNdf4YowA/ec8lU7IYIbXXzTyfPfRX3RY317P/kTBG8tvFvhN16lB/cOe7/8YTM0qttgGyur3VwAQhwcvgb5mgNC4PpzOBdi3E0kiafZT41CLELgQMl978/DaJUIVVLcQEXpBirIsHllzquxMlvP1vGaZihfn46mAqBp5KqeWZqx2igdK2a+CfO1IzoV04TjAmIanGKSRXme2CFIF5VhJAovtIscv6S6vsFVmXAy1V1lpBNmICq6B+MPRu+vAcftySFVGuLkEE1zh6NnB2RKMszpZNxlWS8S9/zsCo3fe8JBa7pumim4UU5ge+kJ+M8j4TV6EPE1AqXPHpoooASrYbMJ56XrJtqfe9vNSf5z8MZFujAS+KnsgY5amISe1CSXR3ugdSnWhV/Rc/ELTbklIYLdo+NidRK7uur0JjY1SgJ+PTbTgz6a8mp8s4mhxO88twnvHVRWnxF5TW+nylKVxtmCwrN2WFcjPHhmyEyKwQu6U8Dpm1MXoBvN/1+4kN1no00PcgzIO7i8iSzBoAhYJAVLJuKZLurjr3BzV7pe0MQ87y48Mf/gv4D9YgeTBVuMY4SYIK5UDhq2LcIXTQSCKCzxnKjOgUTn9FWQmBNfTRPiWTCYjJhQTXpoibfNJKMNf79sIm5MVCe/GBTzyBYEPeVexntGGwjd8v5oMfica5T6+2I0XOgxGZGUNvPJOOdGKRFL1FeMzm1kPwOWSBndmd2HhHJ0LCdMstXl7f3AzZPdLfeTNo1fA0Fr6to2fGwdxWDOrD+s+IqPXnzoR4HWeuHSj0nFYWIiVyXjVXBPLPdvb5F/4EqL5LZ51vTqsb31c7yWGtsqocqNP4F11YdPQtbPqHnUmR/RO8pwFXli2RzahhpHA3vYPVx3MPimvfh0XJCCs1a5rm8uNLKsZ58GYH0uB8PA+t3AM2cPmhcgrZxcU7HtyGg2i5mnqVgSgymaYuNaMWud+vqUXcpE16hyLQnR6a036sBamZzSOGj9+rpSG8F8Bd7/fz0Ghvh7087gOaLeouJOuMX/eKPs3v0nw0vDih8GLCDVYGJ7AovPcGrlqT4MSzzNVBQSxZ+iEYHXxP4DhQ6+njNeYzfQ/e7YtZz69lMxh2osqoJqbDedTeUrEpWonJfDpfwcew0pedBpXjBI5H9ZIQir4Zcw3K5UQdXL4G1kVzCQworwX410A3RtoEWnR8WkkF8oExJA7wow5TPbQJLfmf36vUqqkn5UDRrmn4WyVGQKeEaj1MgBAdShKcI6LIUOeJxcaJqTyHQfqvSAbTeMDQbzumMlwxIlxBL79lOI96tdFUXY2j72GjFWBMRJMvr6H8jHE5GBnOvR8/9wPfHH0t8SwUNhWPHHfn39H4/jljRAel9vw0sy8OY5B+J3jcsDOSvnrLttITLU5+h3Bimg+EFjaRTjYzm4B4mwF3XU9pO9l+Rd6wzUNAft1fiSeNTqJM7xJC/BA5W/QmkHU75UnZ3/9GBHBFz87sB8+XRur3wiK/T0gA5Gg+jvSNy+fLn4rPg9OnGMb6t2S5o3s+1TNpz8OJ6916UeDQssr1lX/EbtiuTYv/E8pZQ= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf66dd54-18af-4cfe-5987-08d9ceb747d7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 12:48:03.1299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RA+T1yHaUkb7Y6d+MMJ6IEa8sJTl/qpY99VS5v6vIjD1ZREP13QbBYT9XETxe/90D6nvzE5Zn6IBSDwZ1Bgj/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3711 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean In a bit of a blunder, the blamed commit in the Fixes: tag below made the mscc_felix switch driver look at the 'managed = "in-band-status"' device tree property, forgetting that the U-Boot device tree had not been updated to include that property, whereas the Linux one does. The switch is therefore described in the device tree as not requiring in-band autoneg, but the PHY driver for VSC8514 (drivers/net/phy/mscc.c) still enables that feature. This results in a mismatch => no traffic. This patch is a copy-paste of the Ethernet device tree nodes from Linux, which resolves that issue. The device tree update also renames the Ethernet PHY labels. Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info") Cc: Ramon Fried Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-rdb.dts | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/arch/arm/dts/fsl-ls1028a-rdb.dts b/arch/arm/dts/fsl-ls1028a-rdb.dts index 11bf7e5f627d..b5e56b1c1f15 100644 --- a/arch/arm/dts/fsl-ls1028a-rdb.dts +++ b/arch/arm/dts/fsl-ls1028a-rdb.dts @@ -45,33 +45,33 @@ }; &enetc_mdio_pf3 { - status = "okay"; - rdb_phy0: phy@2 { - reg = <2>; + sgmii_phy0: ethernet-phy@2 { + reg = <0x2>; }; - /* VSC8514 QSGMII PHY */ - sw_phy0: phy@10 { + /* VSC8514 QSGMII quad PHY */ + qsgmii_phy0: ethernet-phy@10 { reg = <0x10>; }; - sw_phy1: phy@11 { + qsgmii_phy1: ethernet-phy@11 { reg = <0x11>; }; - sw_phy2: phy@12 { + qsgmii_phy2: ethernet-phy@12 { reg = <0x12>; }; - sw_phy3: phy@13 { + qsgmii_phy3: ethernet-phy@13 { reg = <0x13>; }; }; &enetc_port0 { - status = "okay"; + phy-handle = <&sgmii_phy0>; phy-mode = "sgmii"; - phy-handle = <&rdb_phy0>; + managed = "in-band-status"; + status = "okay"; }; &enetc_port2 { @@ -158,28 +158,32 @@ &mscc_felix_port0 { label = "swp0"; - phy-handle = <&sw_phy0>; + managed = "in-band-status"; + phy-handle = <&qsgmii_phy0>; phy-mode = "qsgmii"; status = "okay"; }; &mscc_felix_port1 { label = "swp1"; - phy-handle = <&sw_phy1>; + managed = "in-band-status"; + phy-handle = <&qsgmii_phy1>; phy-mode = "qsgmii"; status = "okay"; }; &mscc_felix_port2 { label = "swp2"; - phy-handle = <&sw_phy2>; + managed = "in-band-status"; + phy-handle = <&qsgmii_phy2>; phy-mode = "qsgmii"; status = "okay"; }; &mscc_felix_port3 { label = "swp3"; - phy-handle = <&sw_phy3>; + managed = "in-band-status"; + phy-handle = <&qsgmii_phy3>; phy-mode = "qsgmii"; status = "okay"; };