| Message ID | 20211217110919.658831-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | e195550bfd00b84f3ba90c2ab8631c89c8190495 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [v2] ARM: dts: imx6ull: Use the correct name for ESAI_TX0 | expand |
On 2021/12/17 19:09, Fabio Estevam wrote: > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > have the ESAI_TX0 functionality, not ESAI_T0. > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly. > > There are no devicetree users in mainline that use the old name, > so just remove the old entry. > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > Reported-by: George Makarov <georgemakarov1@gmail.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> Acked-by: Peng Fan <peng.fan@nxp.com> > --- > Changes since v2: > - Use the linux-version fix: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/imx6ull-pinfunc.h?h=next-20211216&id=737e65c7956795b3553781fb7bc82fce1c39503f > > arch/arm/dts/imx6ull-pinfunc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/imx6ull-pinfunc.h b/arch/arm/dts/imx6ull-pinfunc.h > index eb025a9d4759..7328d4ef8559 100644 > --- a/arch/arm/dts/imx6ull-pinfunc.h > +++ b/arch/arm/dts/imx6ull-pinfunc.h > @@ -82,6 +82,6 @@ > #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0 > #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0 > #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0 > -#define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0 > +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0 > > #endif /* __DTS_IMX6ULL_PINFUNC_H */ >
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > have the ESAI_TX0 functionality, not ESAI_T0. > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly. > There are no devicetree users in mainline that use the old name, > so just remove the old entry. > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > Reported-by: George Makarov <georgemakarov1@gmail.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > Acked-by: Peng Fan <peng.fan@nxp.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/dts/imx6ull-pinfunc.h b/arch/arm/dts/imx6ull-pinfunc.h index eb025a9d4759..7328d4ef8559 100644 --- a/arch/arm/dts/imx6ull-pinfunc.h +++ b/arch/arm/dts/imx6ull-pinfunc.h @@ -82,6 +82,6 @@ #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0 #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0 #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0 -#define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0 +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0 #endif /* __DTS_IMX6ULL_PINFUNC_H */
According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may have the ESAI_TX0 functionality, not ESAI_T0. Also, NXP's i.MX Config Tools 10.0 generates dtsi with the MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly. There are no devicetree users in mainline that use the old name, so just remove the old entry. Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") Reported-by: George Makarov <georgemakarov1@gmail.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v2: - Use the linux-version fix: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/imx6ull-pinfunc.h?h=next-20211216&id=737e65c7956795b3553781fb7bc82fce1c39503f arch/arm/dts/imx6ull-pinfunc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)