From patchwork Fri Dec 17 05:07:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javad Rahimipetroudi X-Patchwork-Id: 1569753 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Pn8WP/Pv; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JFcSl1f1xz9t2p for ; Fri, 17 Dec 2021 16:08:20 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 405F58305D; Fri, 17 Dec 2021 06:08:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Pn8WP/Pv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 53D248305E; Fri, 17 Dec 2021 06:08:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33FB783003 for ; Fri, 17 Dec 2021 06:07:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=javad321javad@gmail.com Received: by mail-ed1-x52f.google.com with SMTP id o20so3291952eds.10 for ; Thu, 16 Dec 2021 21:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gkPBAMRDvP8fMhNt2Y9E3wQmSFdUyk0jcjbn9vPQ+Rg=; b=Pn8WP/Pv2mGZjrFQ34chWX7hwb1J9ju2cnzs/uVhD3SeTNABjL4M9ASP/0fTGr77Up R1uF6j/HMJUNpjfLquIB5ckMjn2CFw641cCPJblpsWLkJUZbxt/7VwFQDUfL//Ub6TZY eorzdvcMmPBXy1VBXrviY66No97c4yxHJRkWqYzx6fugzCk/dX//8fApYjYMxTZomwgh m3EchtGdhCy0qy14akiFAhwI6M/SBa6rFM0qnZxi7oTORnHV62avs/GbFM1ex7YuaAG7 +2tHuYrXDaf25yooeDsy8C3UmNrSTJKgisFGeBYMlrRiZ66Dj4hMme6X3SSpYntHXZnb p27A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gkPBAMRDvP8fMhNt2Y9E3wQmSFdUyk0jcjbn9vPQ+Rg=; b=6Fii0K1oj1X9pC6KTn3aY0AuO/hI3oYyrvthThg5XixJXxc3yIywQABTes3FcwswGk +HhQoTIYAE+OObmvQ1x0L9oNvgHNN5NaJm4bw1uWveJr9iDPcWwY1Hz+7BMXRFfWMCXj K2ckpmh9jgyhQQm59Ky1iffGCUInMG1QQmkKLmuRgQE5h1uiEOr2zEGzBkYrZPuwhxVb n0+EYdtwST1Ck/MQQeOq9yZ2fnu8wbdsMHjD6sIcDxTsqCwK3vOOCix5raDCyGA5FkC1 Qd/G8BQblVSZJezkqcQaclCIHZCrvSWhrleNmGf7rCkOfWd1vkKiYfYalAeqK6jeju4g ZABg== X-Gm-Message-State: AOAM533OgB9AUGuMavAmH3NGKdSMZmFFCpJ228IAiJ/CH9wlkiOQQ3Bm IrQ1tRCNL6rYEviSNu6q3jfHolnueSDtE6ukUDc= X-Google-Smtp-Source: ABdhPJwg9KWKnB35J7qWbC4dmqxA3klbSDI+hipyPKAPxsLWb4F9rGQMukhsw1O2rr9zfSGLfZrNFQ== X-Received: by 2002:a17:906:399a:: with SMTP id h26mr1145531eje.131.1639717678425; Thu, 16 Dec 2021 21:07:58 -0800 (PST) Received: from localhost.localdomain ([2.181.68.80]) by smtp.gmail.com with ESMTPSA id h10sm3136558edj.1.2021.12.16.21.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 21:07:57 -0800 (PST) From: Javad Rahimi To: u-boot@lists.denx.de Cc: jagan@amarulasolutions.com, hdegoede@redhat.com, andre.przywara@arm.com, Javad Rahimi Subject: [Cubieboard2 PATCH v1] Enable early LED support Date: Fri, 17 Dec 2021 08:37:52 +0330 Message-Id: <20211217050752.7686-1-javad321javad@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This patch removes the "status_led_init_done" global variable. By removing that variable, it is possible to use LEDs early in SPL, in architectures where .BSS is placed in DRAM area. (For example A20 series) Signed-off-by: Javad Rahimi --- Changes in v1: - "state" variable is used as initialization flag - Helper macros defined for initialization - Initialization is checked at begining of LED operations drivers/misc/status_led.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/misc/status_led.c b/drivers/misc/status_led.c index a6e9c03a02..23d932ec6e 100644 --- a/drivers/misc/status_led.c +++ b/drivers/misc/status_led.c @@ -69,17 +69,22 @@ led_dev_t led_dev[] = { }; #define MAX_LED_DEV (sizeof(led_dev)/sizeof(led_dev_t)) +#define LED_INITIALIZED_BIT 0x8 +#define LED_STATE_MASK 0x3 -static int status_led_init_done = 0; +#define LED_IS_INITIALIZED(x) (!!((x) & LED_INITIALIZED_BIT)) +#define LED_INITIALIZE(x) ((x) |= (LED_INITIALIZED_BIT)) +#define LED_GET_STATE(x) ((x) & LED_STATE_MASK) void status_led_init(void) { led_dev_t *ld; int i; - for (i = 0, ld = led_dev; i < MAX_LED_DEV; i++, ld++) + for (i = 0, ld = led_dev; i < MAX_LED_DEV; i++, ld++) { __led_init (ld->mask, ld->state); - status_led_init_done = 1; + LED_INITIALIZE(ld->state); + } } void status_led_tick(ulong timestamp) @@ -87,11 +92,11 @@ void status_led_tick(ulong timestamp) led_dev_t *ld; int i; - if (!status_led_init_done) - status_led_init(); - for (i = 0, ld = led_dev; i < MAX_LED_DEV; i++, ld++) { + if (!LED_IS_INITIALIZED(ld->state)) + status_led_init(); + if (ld->state != CONFIG_LED_STATUS_BLINKING) continue; @@ -99,7 +104,6 @@ void status_led_tick(ulong timestamp) __led_toggle (ld->mask); ld->cnt -= ld->period; } - } } @@ -110,12 +114,12 @@ void status_led_set(int led, int state) if (led < 0 || led >= MAX_LED_DEV) return; - if (!status_led_init_done) - status_led_init(); - ld = &led_dev[led]; - ld->state = state; + if (!LED_IS_INITIALIZED(ld->state)) + status_led_init(); + + ld->state = LED_GET_STATE(ld->state); if (state == CONFIG_LED_STATUS_BLINKING) { ld->cnt = 0; /* always start with full period */ state = CONFIG_LED_STATUS_ON; /* always start with LED _ON_ */