| Message ID | 20211202145409.2482099-9-vladimir.oltean@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | Sync NXP LS1028A-RDB device trees between U-Boot and Linux | expand |
Hi Vladimir, On Thu, 2 Dec 2021 at 07:54, Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > Now that all in-tree boards have been converted to the compatible > strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > Cc: Simon Glass <sjg@chromium.org> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/rtc/pcf2127.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> This seems to still be used in the tree. I assume there are other patches that fix that. git grep pcf2127-rtc arch/arm/dts/fsl-ls1028a-qds.dtsi: compatible = "pcf2127-rtc"; arch/arm/dts/fsl-ls1028a-rdb.dts: compatible = "pcf2127-rtc"; arch/arm/dts/fsl-ls1088a-qds.dtsi: compatible = "pcf2127-rtc"; arch/arm/dts/fsl-ls1088a-rdb.dts: compatible = "pcf2127-rtc"; arch/arm/dts/fsl-lx2160a-qds.dtsi: compatible = "pcf2127-rtc"; arch/arm/dts/fsl-lx2160a-rdb.dts: compatible = "pcf2127-rtc"; drivers/rtc/pcf2127.c: { .compatible = "pcf2127-rtc" }, Regards, Simon
Hi Simon, On Fri, Dec 03, 2021 at 01:13:15PM -0700, Simon Glass wrote: > Hi Vladimir, > > On Thu, 2 Dec 2021 at 07:54, Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > > > Now that all in-tree boards have been converted to the compatible > > strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > > > Cc: Simon Glass <sjg@chromium.org> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > --- > > drivers/rtc/pcf2127.c | 1 - > > 1 file changed, 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> Thanks for the review! > This seems to still be used in the tree. I assume there are other > patches that fix that. > > git grep pcf2127-rtc > arch/arm/dts/fsl-ls1028a-qds.dtsi: compatible = "pcf2127-rtc"; > arch/arm/dts/fsl-ls1028a-rdb.dts: > compatible = "pcf2127-rtc"; > arch/arm/dts/fsl-ls1088a-qds.dtsi: > compatible = "pcf2127-rtc"; > arch/arm/dts/fsl-ls1088a-rdb.dts: > compatible = "pcf2127-rtc"; > arch/arm/dts/fsl-lx2160a-qds.dtsi: > compatible = "pcf2127-rtc"; > arch/arm/dts/fsl-lx2160a-rdb.dts: compatible = "pcf2127-rtc"; > drivers/rtc/pcf2127.c: { .compatible = "pcf2127-rtc" }, Yes, indeed there are: https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-4-vladimir.oltean@nxp.com/ https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-5-vladimir.oltean@nxp.com/ https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-6-vladimir.oltean@nxp.com/ https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-7-vladimir.oltean@nxp.com/ https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-8-vladimir.oltean@nxp.com/ I didn't want to spam your mailbox with those.
On Fri, 3 Dec 2021 at 15:09, Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > Hi Simon, > > On Fri, Dec 03, 2021 at 01:13:15PM -0700, Simon Glass wrote: > > Hi Vladimir, > > > > On Thu, 2 Dec 2021 at 07:54, Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > > > > > Now that all in-tree boards have been converted to the compatible > > > strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > > > > > Cc: Simon Glass <sjg@chromium.org> > > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > > --- > > > drivers/rtc/pcf2127.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Thanks for the review! > > > This seems to still be used in the tree. I assume there are other > > patches that fix that. > > > > git grep pcf2127-rtc > > arch/arm/dts/fsl-ls1028a-qds.dtsi: compatible = "pcf2127-rtc"; > > arch/arm/dts/fsl-ls1028a-rdb.dts: > > compatible = "pcf2127-rtc"; > > arch/arm/dts/fsl-ls1088a-qds.dtsi: > > compatible = "pcf2127-rtc"; > > arch/arm/dts/fsl-ls1088a-rdb.dts: > > compatible = "pcf2127-rtc"; > > arch/arm/dts/fsl-lx2160a-qds.dtsi: > > compatible = "pcf2127-rtc"; > > arch/arm/dts/fsl-lx2160a-rdb.dts: compatible = "pcf2127-rtc"; > > drivers/rtc/pcf2127.c: { .compatible = "pcf2127-rtc" }, > > Yes, indeed there are: > https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-4-vladimir.oltean@nxp.com/ > https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-5-vladimir.oltean@nxp.com/ > https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-6-vladimir.oltean@nxp.com/ > https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-7-vladimir.oltean@nxp.com/ > https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-8-vladimir.oltean@nxp.com/ > I didn't want to spam your mailbox with those. Very kind :-) - Simon
>-----Original Message----- >From: Vladimir Oltean <vladimir.oltean@nxp.com> >Sent: Thursday, December 2, 2021 8:24 PM >To: u-boot@lists.denx.de >Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>; >Priyanka Jain <priyanka.jain@nxp.com>; Leo Li <leoyang.li@nxp.com>; Simon >Glass <sjg@chromium.org> >Subject: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string > >Now that all in-tree boards have been converted to the compatible strings >from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > >Cc: Simon Glass <sjg@chromium.org> >Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >--- > drivers/rtc/pcf2127.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index >291ef0329a3e..2f3fafb4968f 100644 >--- a/drivers/rtc/pcf2127.c >+++ b/drivers/rtc/pcf2127.c >@@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = { }; > > static const struct udevice_id pcf2127_rtc_ids[] = { >- { .compatible = "pcf2127-rtc" }, > { .compatible = "nxp,pcf2127" }, > { .compatible = "nxp,pcf2129" }, > { .compatible = "nxp,pca2129" }, >-- >2.25.1 Kindly confirm no existing platform uses this? Is build tested pass for all platforms? Regards Priyanka
On Tue, Dec 07, 2021 at 04:53:11AM +0000, Priyanka Jain wrote: > >-----Original Message----- > >From: Vladimir Oltean <vladimir.oltean@nxp.com> > >Sent: Thursday, December 2, 2021 8:24 PM > >To: u-boot@lists.denx.de > >Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>; > >Priyanka Jain <priyanka.jain@nxp.com>; Leo Li <leoyang.li@nxp.com>; Simon > >Glass <sjg@chromium.org> > >Subject: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string > > > >Now that all in-tree boards have been converted to the compatible strings > >from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > > >Cc: Simon Glass <sjg@chromium.org> > >Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > >--- > > drivers/rtc/pcf2127.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index > >291ef0329a3e..2f3fafb4968f 100644 > >--- a/drivers/rtc/pcf2127.c > >+++ b/drivers/rtc/pcf2127.c > >@@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = { }; > > > > static const struct udevice_id pcf2127_rtc_ids[] = { > >- { .compatible = "pcf2127-rtc" }, > > { .compatible = "nxp,pcf2127" }, > > { .compatible = "nxp,pcf2129" }, > > { .compatible = "nxp,pca2129" }, > >-- > >2.25.1 > > Kindly confirm no existing platform uses this? > Is build tested pass for all platforms? I don't know how to trigger a build test for all platforms, sorry. But I ran a "grep" across the whole tree for "pcf2127-rtc". In fact I noticed just now that there is one extra occurrence at the time of this patch in fsl-ls1028a-rdb.dts (the board itself whose dts is synced with Linux in the next to last patch). I definitely meant to change the fsl-ls1028a-rdb.dts RTC compatible string as part of a separate patch as well, but it appears that I missed it and I'm doing it as part of the dts sync patch. I'll change this in the next series. Hopefully the fact that there aren't any remaining occurrences of the string in the tree is sufficient proof?
On Tue, Dec 07, 2021 at 02:06:29PM +0000, Vladimir Oltean wrote: > On Tue, Dec 07, 2021 at 04:53:11AM +0000, Priyanka Jain wrote: > > >-----Original Message----- > > >From: Vladimir Oltean <vladimir.oltean@nxp.com> > > >Sent: Thursday, December 2, 2021 8:24 PM > > >To: u-boot@lists.denx.de > > >Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>; > > >Priyanka Jain <priyanka.jain@nxp.com>; Leo Li <leoyang.li@nxp.com>; Simon > > >Glass <sjg@chromium.org> > > >Subject: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string > > > > > >Now that all in-tree boards have been converted to the compatible strings > > >from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > > > > >Cc: Simon Glass <sjg@chromium.org> > > >Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > >--- > > > drivers/rtc/pcf2127.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > >diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index > > >291ef0329a3e..2f3fafb4968f 100644 > > >--- a/drivers/rtc/pcf2127.c > > >+++ b/drivers/rtc/pcf2127.c > > >@@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = { }; > > > > > > static const struct udevice_id pcf2127_rtc_ids[] = { > > >- { .compatible = "pcf2127-rtc" }, > > > { .compatible = "nxp,pcf2127" }, > > > { .compatible = "nxp,pcf2129" }, > > > { .compatible = "nxp,pca2129" }, > > >-- > > >2.25.1 > > > > Kindly confirm no existing platform uses this? > > Is build tested pass for all platforms? > > I don't know how to trigger a build test for all platforms, sorry. FWIW, and this is documented in doc/develop/ci_testing.rst, anyone can trigger an Azure CI world build via a github PR against https://github.com/u-boot/u-boot.git
On Tue, Dec 07, 2021 at 09:46:37AM -0500, Tom Rini wrote: > On Tue, Dec 07, 2021 at 02:06:29PM +0000, Vladimir Oltean wrote: > > On Tue, Dec 07, 2021 at 04:53:11AM +0000, Priyanka Jain wrote: > > > >-----Original Message----- > > > >From: Vladimir Oltean <vladimir.oltean@nxp.com> > > > >Sent: Thursday, December 2, 2021 8:24 PM > > > >To: u-boot@lists.denx.de > > > >Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>; > > > >Priyanka Jain <priyanka.jain@nxp.com>; Leo Li <leoyang.li@nxp.com>; Simon > > > >Glass <sjg@chromium.org> > > > >Subject: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string > > > > > > > >Now that all in-tree boards have been converted to the compatible strings > > > >from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. > > > > > > > >Cc: Simon Glass <sjg@chromium.org> > > > >Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > > >--- > > > > drivers/rtc/pcf2127.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > >diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index > > > >291ef0329a3e..2f3fafb4968f 100644 > > > >--- a/drivers/rtc/pcf2127.c > > > >+++ b/drivers/rtc/pcf2127.c > > > >@@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = { }; > > > > > > > > static const struct udevice_id pcf2127_rtc_ids[] = { > > > >- { .compatible = "pcf2127-rtc" }, > > > > { .compatible = "nxp,pcf2127" }, > > > > { .compatible = "nxp,pcf2129" }, > > > > { .compatible = "nxp,pca2129" }, > > > >-- > > > >2.25.1 > > > > > > Kindly confirm no existing platform uses this? > > > Is build tested pass for all platforms? > > > > I don't know how to trigger a build test for all platforms, sorry. > > FWIW, and this is documented in doc/develop/ci_testing.rst, anyone can > trigger an Azure CI world build via a github PR against > https://github.com/u-boot/u-boot.git Thanks, in this case I'll submit a pull request there with the contents of v2 before sending it out.
diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index 291ef0329a3e..2f3fafb4968f 100644 --- a/drivers/rtc/pcf2127.c +++ b/drivers/rtc/pcf2127.c @@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = { }; static const struct udevice_id pcf2127_rtc_ids[] = { - { .compatible = "pcf2127-rtc" }, { .compatible = "nxp,pcf2127" }, { .compatible = "nxp,pcf2129" }, { .compatible = "nxp,pca2129" },
Now that all in-tree boards have been converted to the compatible strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. Cc: Simon Glass <sjg@chromium.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/rtc/pcf2127.c | 1 - 1 file changed, 1 deletion(-)