From patchwork Wed Dec 1 19:51:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1562379 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ltOPGf6H; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J48pr3hZWz9sR4 for ; Thu, 2 Dec 2021 06:51:16 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA334830C4; Wed, 1 Dec 2021 20:51:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ltOPGf6H"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 76F1C830DF; Wed, 1 Dec 2021 20:51:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A263830C4 for ; Wed, 1 Dec 2021 20:51:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x731.google.com with SMTP id t83so32287102qke.8 for ; Wed, 01 Dec 2021 11:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qp7CfvvvN/USmZ34fNc6raqKTnKraBjXXK6CvaNEM/o=; b=ltOPGf6HdGcQcZZjvVs/ECWAmSFvY2/NwDaD/ofF/Pt3AtkpNJdhElMaAT6cWGTjCS Dcnku+i0vbFrFylYvg6w+rvWlc5COpao0a56FPCcNT2A69F1qfAAUeREBO61u7lvZSh6 3zbrkDBjle01VC6G/9Q9aK1fPksD04/GJ7rVBAcxNYMMiufo18Y2JKItFU7iL/lhK1Qh N9rGJCqG4mZ3mq6t6+WvpVgMd5bwA9W6r9IyYCgaBMerrP9gQPFWXN7QEylFZKey5t0x Y5d1Ki3TNsesnFJ0VHsavu7gxXg3xzQ0lTf7iAB68XcDsX+HaL6H9XIrh7+ulp8Imgr6 1XZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qp7CfvvvN/USmZ34fNc6raqKTnKraBjXXK6CvaNEM/o=; b=xJH8w8sr0TnyS7OaJstBbBw6q1fcg8nZVwIzvjpC9duIIMban458ig6iFXEzp5xLBD 0CummWfMhNGLfXh8NVZ3h1qXwJxUS4SoR/VacOLpAEuAP0aPM3ATV9aFkaiEnwAYqDzc msWSjAvTuIUde8q0B2fHPSsTru5CY44NxPIwipwogKo71vCkus5Z+F+HSe/j7nOkf34L 4N9ltnBky+sPvORMjryadw34qeeyOCBHemsJWHJ6KgJ+/jqWnwuUwn32WWz7di0AB4rV cvDpL9gZRbtUrCacUaLrc5FINcAfuaWQcmcTJdSRowTLxBo5EM3E0sIW2QLoNX/gen5v gLKg== X-Gm-Message-State: AOAM531jxp7fk2IA/6flu9fe2MLcQxXE6jcJTSfuJrzG0qkwLjOPNw4o cfmiNNGtsJmYO20BReKXJpwx76v6Rpo= X-Google-Smtp-Source: ABdhPJyZIg20Qs/zTaKt9Q+dX0Wwnd5porj+EzuuTweYhxmo9D8iNZX8afjfWvejy1MDCvMNo+Td6Q== X-Received: by 2002:a05:620a:44c1:: with SMTP id y1mr8286164qkp.647.1638388265004; Wed, 01 Dec 2021 11:51:05 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.gmail.com with ESMTPSA id d11sm358282qtj.4.2021.12.01.11.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 11:51:04 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Lukasz Majewski , Simon Glass , Dario Binacchi , Tero Kristo , Sean Anderson Subject: [PATCH] clk: Remove no-op request and rfree callbacks Date: Wed, 1 Dec 2021 14:51:00 -0500 Message-Id: <20211201195100.2173465-1-seanga2@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean These callbacks are optional. Remove ones which do nothing. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- drivers/clk/ics8n3qv01.c | 6 ------ drivers/clk/tegra/tegra-car-clk.c | 9 --------- drivers/clk/ti/clk-sci.c | 14 -------------- 3 files changed, 29 deletions(-) diff --git a/drivers/clk/ics8n3qv01.c b/drivers/clk/ics8n3qv01.c index 6bc1b8ba9d..33fb6ed0c7 100644 --- a/drivers/clk/ics8n3qv01.c +++ b/drivers/clk/ics8n3qv01.c @@ -180,11 +180,6 @@ static ulong ics8n3qv01_set_rate(struct clk *clk, ulong fout) return 0; } -static int ics8n3qv01_request(struct clk *clock) -{ - return 0; -} - static ulong ics8n3qv01_get_rate(struct clk *clk) { struct ics8n3qv01_priv *priv = dev_get_priv(clk->dev); @@ -203,7 +198,6 @@ static int ics8n3qv01_disable(struct clk *clk) } static const struct clk_ops ics8n3qv01_ops = { - .request = ics8n3qv01_request, .get_rate = ics8n3qv01_get_rate, .set_rate = ics8n3qv01_set_rate, .enable = ics8n3qv01_enable, diff --git a/drivers/clk/tegra/tegra-car-clk.c b/drivers/clk/tegra/tegra-car-clk.c index 09a7cf470c..c5214b9b3e 100644 --- a/drivers/clk/tegra/tegra-car-clk.c +++ b/drivers/clk/tegra/tegra-car-clk.c @@ -30,14 +30,6 @@ static int tegra_car_clk_request(struct clk *clk) return 0; } -static int tegra_car_clk_free(struct clk *clk) -{ - debug("%s(clk=%p) (dev=%p, id=%lu)\n", __func__, clk, clk->dev, - clk->id); - - return 0; -} - static ulong tegra_car_clk_get_rate(struct clk *clk) { enum clock_id parent; @@ -82,7 +74,6 @@ static int tegra_car_clk_disable(struct clk *clk) static struct clk_ops tegra_car_clk_ops = { .request = tegra_car_clk_request, - .rfree = tegra_car_clk_free, .get_rate = tegra_car_clk_get_rate, .set_rate = tegra_car_clk_set_rate, .enable = tegra_car_clk_enable, diff --git a/drivers/clk/ti/clk-sci.c b/drivers/clk/ti/clk-sci.c index acb9eadf03..74df5a397b 100644 --- a/drivers/clk/ti/clk-sci.c +++ b/drivers/clk/ti/clk-sci.c @@ -64,18 +64,6 @@ static int ti_sci_clk_of_xlate(struct clk *clk, return 0; } -static int ti_sci_clk_request(struct clk *clk) -{ - debug("%s(clk=%p)\n", __func__, clk); - return 0; -} - -static int ti_sci_clk_free(struct clk *clk) -{ - debug("%s(clk=%p)\n", __func__, clk); - return 0; -} - static ulong ti_sci_clk_get_rate(struct clk *clk) { struct ti_sci_clk_data *data = dev_get_priv(clk->dev); @@ -208,8 +196,6 @@ static const struct udevice_id ti_sci_clk_of_match[] = { static struct clk_ops ti_sci_clk_ops = { .of_xlate = ti_sci_clk_of_xlate, - .request = ti_sci_clk_request, - .rfree = ti_sci_clk_free, .get_rate = ti_sci_clk_get_rate, .set_rate = ti_sci_clk_set_rate, .set_parent = ti_sci_clk_set_parent,