diff mbox series

clk: Remove no-op request and rfree callbacks

Message ID 20211201195100.2173465-1-seanga2@gmail.com
State Accepted
Commit ea5f44325ab6e8e47d299d52991f1ca6089a1592
Delegated to: Sean Anderson
Headers show
Series clk: Remove no-op request and rfree callbacks | expand

Commit Message

Sean Anderson Dec. 1, 2021, 7:51 p.m. UTC 
These callbacks are optional. Remove ones which do nothing.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

 drivers/clk/ics8n3qv01.c          |  6 ------
 drivers/clk/tegra/tegra-car-clk.c |  9 ---------
 drivers/clk/ti/clk-sci.c          | 14 --------------
 3 files changed, 29 deletions(-)

Comments

Simon Glass Dec. 2, 2021, 1:27 p.m. UTC | #1 
On Wed, 1 Dec 2021 at 12:51, Sean Anderson <seanga2@gmail.com> wrote:
>
> These callbacks are optional. Remove ones which do nothing.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>
>  drivers/clk/ics8n3qv01.c          |  6 ------
>  drivers/clk/tegra/tegra-car-clk.c |  9 ---------
>  drivers/clk/ti/clk-sci.c          | 14 --------------
>  3 files changed, 29 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Sean Anderson Jan. 15, 2022, 8:40 p.m. UTC | #2 
On Wed, 1 Dec 2021 14:51:00 -0500, Sean Anderson wrote:
> These callbacks are optional. Remove ones which do nothing.
> 
> 

Applied, thanks!

[1/1] clk: Remove no-op request and rfree callbacks
      commit: 460970faec567f9285199140c6e5dbe2112bb843

Best regards,
diff mbox series

Patch

diff --git a/drivers/clk/ics8n3qv01.c b/drivers/clk/ics8n3qv01.c
index 6bc1b8ba9d..33fb6ed0c7 100644
--- a/drivers/clk/ics8n3qv01.c
+++ b/drivers/clk/ics8n3qv01.c
@@ -180,11 +180,6 @@  static ulong ics8n3qv01_set_rate(struct clk *clk, ulong fout)
 	return 0;
 }
 
-static int ics8n3qv01_request(struct clk *clock)
-{
-	return 0;
-}
-
 static ulong ics8n3qv01_get_rate(struct clk *clk)
 {
 	struct ics8n3qv01_priv *priv = dev_get_priv(clk->dev);
@@ -203,7 +198,6 @@  static int ics8n3qv01_disable(struct clk *clk)
 }
 
 static const struct clk_ops ics8n3qv01_ops = {
-	.request = ics8n3qv01_request,
 	.get_rate = ics8n3qv01_get_rate,
 	.set_rate = ics8n3qv01_set_rate,
 	.enable = ics8n3qv01_enable,
diff --git a/drivers/clk/tegra/tegra-car-clk.c b/drivers/clk/tegra/tegra-car-clk.c
index 09a7cf470c..c5214b9b3e 100644
--- a/drivers/clk/tegra/tegra-car-clk.c
+++ b/drivers/clk/tegra/tegra-car-clk.c
@@ -30,14 +30,6 @@  static int tegra_car_clk_request(struct clk *clk)
 	return 0;
 }
 
-static int tegra_car_clk_free(struct clk *clk)
-{
-	debug("%s(clk=%p) (dev=%p, id=%lu)\n", __func__, clk, clk->dev,
-	      clk->id);
-
-	return 0;
-}
-
 static ulong tegra_car_clk_get_rate(struct clk *clk)
 {
 	enum clock_id parent;
@@ -82,7 +74,6 @@  static int tegra_car_clk_disable(struct clk *clk)
 
 static struct clk_ops tegra_car_clk_ops = {
 	.request = tegra_car_clk_request,
-	.rfree = tegra_car_clk_free,
 	.get_rate = tegra_car_clk_get_rate,
 	.set_rate = tegra_car_clk_set_rate,
 	.enable = tegra_car_clk_enable,
diff --git a/drivers/clk/ti/clk-sci.c b/drivers/clk/ti/clk-sci.c
index acb9eadf03..74df5a397b 100644
--- a/drivers/clk/ti/clk-sci.c
+++ b/drivers/clk/ti/clk-sci.c
@@ -64,18 +64,6 @@  static int ti_sci_clk_of_xlate(struct clk *clk,
 	return 0;
 }
 
-static int ti_sci_clk_request(struct clk *clk)
-{
-	debug("%s(clk=%p)\n", __func__, clk);
-	return 0;
-}
-
-static int ti_sci_clk_free(struct clk *clk)
-{
-	debug("%s(clk=%p)\n", __func__, clk);
-	return 0;
-}
-
 static ulong ti_sci_clk_get_rate(struct clk *clk)
 {
 	struct ti_sci_clk_data *data = dev_get_priv(clk->dev);
@@ -208,8 +196,6 @@  static const struct udevice_id ti_sci_clk_of_match[] = {
 
 static struct clk_ops ti_sci_clk_ops = {
 	.of_xlate = ti_sci_clk_of_xlate,
-	.request = ti_sci_clk_request,
-	.rfree = ti_sci_clk_free,
 	.get_rate = ti_sci_clk_get_rate,
 	.set_rate = ti_sci_clk_set_rate,
 	.set_parent = ti_sci_clk_set_parent,