diff mbox series

[09/17] binman: Drop the filename property in entry_Section

Message ID 20211123180354.615946-10-sjg@chromium.org
State Accepted
Commit b6caf0ebcabd20499f3171e12bcbee01a0b3d724
Delegated to: Simon Glass
Headers show
Series binman: Various tidy-ups and refactors | expand

Commit Message

Simon Glass Nov. 23, 2021, 6:03 p.m. UTC 
This is not used and does nothing. Drop it.

Add a tweak to avoid reducing the pylint score.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/binman/etype/section.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Simon Glass Dec. 2, 2021, 9:18 p.m. UTC | #1 
This is not used and does nothing. Drop it.

Add a tweak to avoid reducing the pylint score.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/binman/etype/section.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Applied to u-boot-dm/next, thanks!
diff mbox series

Patch

diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index 281a228cd0e..952c01de186 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -81,9 +81,6 @@  class Entry_section(Entry):
                 self._skip_at_start = 0
         self._name_prefix = fdt_util.GetString(self._node, 'name-prefix')
         self.align_default = fdt_util.GetInt(self._node, 'align-default', 0)
-        filename = fdt_util.GetString(self._node, 'filename')
-        if filename:
-            self._filename = filename
 
         self.ReadEntries()
 
@@ -661,7 +658,7 @@  class Entry_section(Entry):
         return data
 
     def ReadChildData(self, child, decomp=True):
-        tout.Debug("ReadChildData for child '%s'" % child.GetPath())
+        tout.Debug(f"ReadChildData for child '{child.GetPath()}'")
         parent_data = self.ReadData(True)
         offset = child.offset - self._skip_at_start
         tout.Debug("Extract for child '%s': offset %#x, skip_at_start %#x, result %#x" %