| Message ID | 20211123062800.14386-1-ms@dev.tdt.de |
|---|---|
| State | Accepted |
| Commit | c702cfc7f224617ed4e8e97571442d08d659d637 |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | board: ls1043ardb: force PCI device enumeration | expand |
> -----Original Message----- > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin Schiller > Sent: Tuesday, November 23, 2021 8:28 > To: u-boot@lists.denx.de > Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain > <priyanka.jain@nxp.com>; Camelia Alexandra Groza > <camelia.groza@nxp.com> > Subject: [PATCH] board: ls1043ardb: force PCI device enumeration > > Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB") > resulted in the PCI bus no longer being implicitly enumerated. > > However, this is necessary for the fdt pcie fixups to work. > > Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb: > transition to DM_ETH"), pci_init() is now called in the board_init() > routine when CONFIG_DM_ETH is active. > > Signed-off-by: Martin Schiller <ms@dev.tdt.de> > CC: Priyanka Jain <priyanka.jain@nxp.com> > CC: Camelia Groza <camelia.groza@nxp.com> > --- > board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/board/freescale/ls1043ardb/ls1043ardb.c > b/board/freescale/ls1043ardb/ls1043ardb.c > index beef26b084..1764c9336c 100644 > --- a/board/freescale/ls1043ardb/ls1043ardb.c > +++ b/board/freescale/ls1043ardb/ls1043ardb.c > @@ -219,6 +219,10 @@ int board_init(void) > ppa_init(); > #endif > > +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH) > + pci_init(); > +#endif > + > #ifdef CONFIG_U_QE > u_qe_init(); > #endif Thanks for the fix. Acked-by: Camelia Groza <camelia.groza@nxp.com>
>-----Original Message----- >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Camelia Alexandra >Groza (OSS) >Sent: Tuesday, November 23, 2021 4:04 PM >To: Martin Schiller <ms@dev.tdt.de>; u-boot@lists.denx.de >Cc: Priyanka Jain <priyanka.jain@nxp.com> >Subject: RE: [PATCH] board: ls1043ardb: force PCI device enumeration > >> -----Original Message----- >> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin >> Schiller >> Sent: Tuesday, November 23, 2021 8:28 >> To: u-boot@lists.denx.de >> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain >> <priyanka.jain@nxp.com>; Camelia Alexandra Groza >> <camelia.groza@nxp.com> >> Subject: [PATCH] board: ls1043ardb: force PCI device enumeration >> >> Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB") >> resulted in the PCI bus no longer being implicitly enumerated. >> >> However, this is necessary for the fdt pcie fixups to work. >> >> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb: >> transition to DM_ETH"), pci_init() is now called in the board_init() >> routine when CONFIG_DM_ETH is active. >> >> Signed-off-by: Martin Schiller <ms@dev.tdt.de> >> CC: Priyanka Jain <priyanka.jain@nxp.com> >> CC: Camelia Groza <camelia.groza@nxp.com> >> --- >> board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/board/freescale/ls1043ardb/ls1043ardb.c >> b/board/freescale/ls1043ardb/ls1043ardb.c >> index beef26b084..1764c9336c 100644 >> --- a/board/freescale/ls1043ardb/ls1043ardb.c >> +++ b/board/freescale/ls1043ardb/ls1043ardb.c >> @@ -219,6 +219,10 @@ int board_init(void) >> ppa_init(); >> #endif >> >> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH) >> + pci_init(); >> +#endif >> + >> #ifdef CONFIG_U_QE >> u_qe_init(); >> #endif > >Thanks for the fix. > >Acked-by: Camelia Groza <camelia.groza@nxp.com> Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
diff --git a/board/freescale/ls1043ardb/ls1043ardb.c b/board/freescale/ls1043ardb/ls1043ardb.c index beef26b084..1764c9336c 100644 --- a/board/freescale/ls1043ardb/ls1043ardb.c +++ b/board/freescale/ls1043ardb/ls1043ardb.c @@ -219,6 +219,10 @@ int board_init(void) ppa_init(); #endif +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH) + pci_init(); +#endif + #ifdef CONFIG_U_QE u_qe_init(); #endif
Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB") resulted in the PCI bus no longer being implicitly enumerated. However, this is necessary for the fdt pcie fixups to work. Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb: transition to DM_ETH"), pci_init() is now called in the board_init() routine when CONFIG_DM_ETH is active. Signed-off-by: Martin Schiller <ms@dev.tdt.de> CC: Priyanka Jain <priyanka.jain@nxp.com> CC: Camelia Groza <camelia.groza@nxp.com> --- board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++ 1 file changed, 4 insertions(+)