| Message ID | 20211118100605.1139255-1-festevam@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | ARM: dts: imx6ull: Use the correct name for ESAI_TX0 | expand |
Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam <festevam@gmail.com> escreveu: > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > have the ESAI_TX0 functionality, not ESAI_T0. > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > Add an entry for the correct name and still keep the old one to > avoid potential breakage. > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > Reported-by: George Makarov <georgemakarov1@gmail.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> Have you verified if there is any use of the old name in the three? if so, a patch converting it would be good.
Hi Otavio, On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador <otavio.salvador@ossystems.com.br> wrote: > > Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam > <festevam@gmail.com> escreveu: > > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > > have the ESAI_TX0 functionality, not ESAI_T0. > > > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > > > Add an entry for the correct name and still keep the old one to > > avoid potential breakage. > > > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > > Reported-by: George Makarov <georgemakarov1@gmail.com> > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Have you verified if there is any use of the old name in the three? if > so, a patch converting it would be good. There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot and in the kernel.
Hello Fabio, Em qui., 18 de nov. de 2021 às 08:36, Fabio Estevam <festevam@gmail.com> escreveu: > On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador > <otavio.salvador@ossystems.com.br> wrote: > > > > Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam > > <festevam@gmail.com> escreveu: > > > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > > > have the ESAI_TX0 functionality, not ESAI_T0. > > > > > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > > > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > > > > > Add an entry for the correct name and still keep the old one to > > > avoid potential breakage. > > > > > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > > > Reported-by: George Makarov <georgemakarov1@gmail.com> > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > > > Have you verified if there is any use of the old name in the three? if > > so, a patch converting it would be good. > > There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot > and in the kernel. Awesome. Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
diff --git a/arch/arm/dts/imx6ull-pinfunc.h b/arch/arm/dts/imx6ull-pinfunc.h index eb025a9d4759..b492164e8cfb 100644 --- a/arch/arm/dts/imx6ull-pinfunc.h +++ b/arch/arm/dts/imx6ull-pinfunc.h @@ -82,6 +82,11 @@ #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0 #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0 #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0 +/* + * As per the Reference Manual the correct name is ESAI_TX0. + * Keep the old name here to avoid breakage. + */ #define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0 +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0 #endif /* __DTS_IMX6ULL_PINFUNC_H */
According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may have the ESAI_TX0 functionality, not ESAI_T0. Also, NXP's i.MX Config Tools 10.0 generates dtsi with the MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. Add an entry for the correct name and still keep the old one to avoid potential breakage. Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") Reported-by: George Makarov <georgemakarov1@gmail.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Hi, I have also sent this patch to the Linux upstream dts: http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/697319.html arch/arm/dts/imx6ull-pinfunc.h | 5 +++++ 1 file changed, 5 insertions(+)