diff mbox series

[V2,10/17] arm: dts: k3-j721e-r5-common-proc-board: Do not use power-domains for I2C

Message ID 20211102140558.32460-11-sinthu.raja@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Add support for J721E SK | expand

Commit Message

Sinthu Raja Nov. 2, 2021, 2:05 p.m. UTC
From: Sinthu Raja <sinthu.raja@ti.com>

Board ID I2C EEPROM will be probed before SYSFW is available.
So drop the power-domains property for wakup_i2c0 on which
board ID EEPROM is connected.

Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---

No Changes in V2.

 arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Tom Rini Nov. 8, 2021, 3:46 p.m. UTC | #1
On Tue, Nov 02, 2021 at 07:35:51PM +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> Board ID I2C EEPROM will be probed before SYSFW is available.
> So drop the power-domains property for wakup_i2c0 on which
> board ID EEPROM is connected.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
> 
> No Changes in V2.
> 
>  arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> index 4b2362a5dd..88a69bf066 100644
> --- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> +++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> @@ -361,3 +361,8 @@
>  &mcu_udmap {
>  	ti,sci = <&dm_tifs>;
>  };
> +
> +/* EEPROM might be read before SYSFW is available */
> +&wkup_i2c0 {
> +	/delete-property/ power-domains;
> +};

Has this been queued up for linux-next or similar yet?
Sinthu Raja Nov. 12, 2021, 11:58 a.m. UTC | #2
Hi Tom,

On Mon, Nov 8, 2021 at 9:16 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Nov 02, 2021 at 07:35:51PM +0530, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > Board ID I2C EEPROM will be probed before SYSFW is available.
> > So drop the power-domains property for wakup_i2c0 on which
> > board ID EEPROM is connected.
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >
> > No Changes in V2.
> >
> >  arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > index 4b2362a5dd..88a69bf066 100644
> > --- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > +++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > @@ -361,3 +361,8 @@
> >  &mcu_udmap {
> >       ti,sci = <&dm_tifs>;
> >  };
> > +
> > +/* EEPROM might be read before SYSFW is available */
> > +&wkup_i2c0 {
> > +     /delete-property/ power-domains;
> > +};
>
> Has this been queued up for linux-next or similar yet?
Yes, this is queued in linux-next [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/ti/k3-j721e-sk.dts

>
> --
> Tom
Tom Rini Nov. 12, 2021, 2:42 p.m. UTC | #3
On Fri, Nov 12, 2021 at 05:28:07PM +0530, Sinthu Raja M wrote:
> Hi Tom,
> 
> On Mon, Nov 8, 2021 at 9:16 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 02, 2021 at 07:35:51PM +0530, Sinthu Raja wrote:
> > > From: Sinthu Raja <sinthu.raja@ti.com>
> > >
> > > Board ID I2C EEPROM will be probed before SYSFW is available.
> > > So drop the power-domains property for wakup_i2c0 on which
> > > board ID EEPROM is connected.
> > >
> > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > ---
> > >
> > > No Changes in V2.
> > >
> > >  arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > > index 4b2362a5dd..88a69bf066 100644
> > > --- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > > +++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> > > @@ -361,3 +361,8 @@
> > >  &mcu_udmap {
> > >       ti,sci = <&dm_tifs>;
> > >  };
> > > +
> > > +/* EEPROM might be read before SYSFW is available */
> > > +&wkup_i2c0 {
> > > +     /delete-property/ power-domains;
> > > +};
> >
> > Has this been queued up for linux-next or similar yet?
> Yes, this is queued in linux-next [1].
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/ti/k3-j721e-sk.dts

OK, since all of the dts stuff is queued up, that's good and important
as it will also be re-synced later directly from kernel.org so anything
not there must be in -u-boot.dtsi files and with very good reasoning.
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
index 4b2362a5dd..88a69bf066 100644
--- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
+++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
@@ -361,3 +361,8 @@ 
 &mcu_udmap {
 	ti,sci = <&dm_tifs>;
 };
+
+/* EEPROM might be read before SYSFW is available */
+&wkup_i2c0 {
+	/delete-property/ power-domains;
+};