diff mbox series

[v8,01/12] image: fit: Fix parameter name for hash algorithm

Message ID 20211027061735.2298498-2-chiawei_wang@aspeedtech.com
State Awaiting Upstream
Delegated to: Tom Rini
Headers show
Series aspeed: Support secure boot chain with FIT image verification | expand

Commit Message

ChiaWei Wang Oct. 27, 2021, 6:17 a.m. UTC 
Fix inconsistent function parameter name of the hash algorithm.

Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in calculate_hash()")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 common/image-fit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini Nov. 18, 2021, 7:16 p.m. UTC | #1 
On Wed, Oct 27, 2021 at 02:17:24PM +0800, Chia-Wei Wang wrote:

> Fix inconsistent function parameter name of the hash algorithm.
> 
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in calculate_hash()")
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Reviewed-by: Simon Glass <sjg@chromium.org>

For the series, applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/common/image-fit.c b/common/image-fit.c
index 33b4a46028..b629339f4e 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1202,7 +1202,7 @@  int fit_set_timestamp(void *fit, int noffset, time_t timestamp)
  * calculate_hash - calculate and return hash for provided input data
  * @data: pointer to the input data
  * @data_len: data length
- * @algo: requested hash algorithm
+ * @name: requested hash algorithm name
  * @value: pointer to the char, will hold hash value data (caller must
  * allocate enough free space)
  * value_len: length of the calculated hash
@@ -1230,7 +1230,7 @@  int calculate_hash(const void *data, int data_len, const char *name,
 		return -1;
 	}
 
-	hash_algo = hash_algo_lookup_by_name(algo);
+	hash_algo = hash_algo_lookup_by_name(name);
 	if (hash_algo == HASH_ALGO_INVALID) {
 		debug("Unsupported hash algorithm\n");
 		return -1;