diff mbox series

[v1,5/5] doc: board: Update Microchip MPFS Icicle Kit doc

Message ID 20211022085648.134655-6-padmarao.begari@microchip.com
State Superseded
Delegated to: Andes
Headers show
Series Update Microchip PolarFire SoC support | expand

Commit Message

Padmarao Begari Oct. 22, 2021, 8:56 a.m. UTC
UART1 uses for U-BOOT and Linux console instead of UART0 and
UART0 is reserved for Hart Software Services(HSS).

Signed-off-by: Padmarao Begari <padmarao.begari@microchip.com>
---
 doc/board/microchip/mpfs_icicle.rst | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Leo Liang Nov. 1, 2021, 8:33 a.m. UTC | #1
On Fri, Oct 22, 2021 at 02:26:48PM +0530, Padmarao Begari wrote:
> UART1 uses for U-BOOT and Linux console instead of UART0 and
> UART0 is reserved for Hart Software Services(HSS).
> 
> Signed-off-by: Padmarao Begari <padmarao.begari@microchip.com>
> ---
>  doc/board/microchip/mpfs_icicle.rst | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Bin Meng Nov. 1, 2021, 8:46 a.m. UTC | #2
On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari
<padmarao.begari@microchip.com> wrote:
>
> UART1 uses for U-BOOT and Linux console instead of UART0 and

nits: s/U-BOOT/U-Boot

> UART0 is reserved for Hart Software Services(HSS).
>
> Signed-off-by: Padmarao Begari <padmarao.begari@microchip.com>
> ---
>  doc/board/microchip/mpfs_icicle.rst | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst
> index c71c2f3cab..d7af542c0e 100644
> --- a/doc/board/microchip/mpfs_icicle.rst
> +++ b/doc/board/microchip/mpfs_icicle.rst
> @@ -18,8 +18,9 @@ The support for following drivers are already enabled:
>
>  1. NS16550 UART Driver.
>  2. Microchip Clock Driver.
> -3. Cadence MACB ethernet driver for networking support.
> -4. Cadence MMC Driver for eMMC/SD support.
> +3. Microchip I2C Driver.

nits: can we just insert this after the existing entries?

> +4. Cadence MACB ethernet driver for networking support.
> +5. Cadence MMC Driver for eMMC/SD support.
>
>  Booting from eMMC using HSS
>  ---------------------------
> @@ -214,7 +215,8 @@ GPT partition.
>  Booting
>  ~~~~~~~
>
> -You should see the U-Boot prompt on UART0.
> +You should see the U-Boot prompt on UART1.
> +(Note: UART0 is reserved for HSS)
>
>  Sample boot log from MPFS Icicle Kit
>  ''''''''''''''''''''''''''''''''''''
> @@ -451,7 +453,8 @@ copied payload and Linux image.
>
>      sudo dd if=<payload_binary> of=/dev/sdX2 bs=512
>
> -You should see the U-Boot prompt on UART0.
> +You should see the U-Boot prompt on UART1.
> +(Note: UART0 is reserved for HSS)
>
>  GUID type
>  ~~~~~~~~~

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin
Padmarao Begari Nov. 2, 2021, 11:04 a.m. UTC | #3
Hi Bin,

On Mon, Nov 1, 2021 at 2:16 PM Bin Meng <bmeng.cn@gmail.com> wrote:

> On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari
> <padmarao.begari@microchip.com> wrote:
> >
> > UART1 uses for U-BOOT and Linux console instead of UART0 and
>
> nits: s/U-BOOT/U-Boot
>
>
ok

> > UART0 is reserved for Hart Software Services(HSS).
> >
> > Signed-off-by: Padmarao Begari <padmarao.begari@microchip.com>
> > ---
> >  doc/board/microchip/mpfs_icicle.rst | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/board/microchip/mpfs_icicle.rst
> b/doc/board/microchip/mpfs_icicle.rst
> > index c71c2f3cab..d7af542c0e 100644
> > --- a/doc/board/microchip/mpfs_icicle.rst
> > +++ b/doc/board/microchip/mpfs_icicle.rst
> > @@ -18,8 +18,9 @@ The support for following drivers are already enabled:
> >
> >  1. NS16550 UART Driver.
> >  2. Microchip Clock Driver.
> > -3. Cadence MACB ethernet driver for networking support.
> > -4. Cadence MMC Driver for eMMC/SD support.
> > +3. Microchip I2C Driver.
>
> nits: can we just insert this after the existing entries?
>
>
ok

Regards
Padmarao

> > +4. Cadence MACB ethernet driver for networking support.
> > +5. Cadence MMC Driver for eMMC/SD support.
> >
> >  Booting from eMMC using HSS
> >  ---------------------------
> > @@ -214,7 +215,8 @@ GPT partition.
> >  Booting
> >  ~~~~~~~
> >
> > -You should see the U-Boot prompt on UART0.
> > +You should see the U-Boot prompt on UART1.
> > +(Note: UART0 is reserved for HSS)
> >
> >  Sample boot log from MPFS Icicle Kit
> >  ''''''''''''''''''''''''''''''''''''
> > @@ -451,7 +453,8 @@ copied payload and Linux image.
> >
> >      sudo dd if=<payload_binary> of=/dev/sdX2 bs=512
> >
> > -You should see the U-Boot prompt on UART0.
> > +You should see the U-Boot prompt on UART1.
> > +(Note: UART0 is reserved for HSS)
> >
> >  GUID type
> >  ~~~~~~~~~
>
> Otherwise,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Regards,
> Bin
>
diff mbox series

Patch

diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst
index c71c2f3cab..d7af542c0e 100644
--- a/doc/board/microchip/mpfs_icicle.rst
+++ b/doc/board/microchip/mpfs_icicle.rst
@@ -18,8 +18,9 @@  The support for following drivers are already enabled:
 
 1. NS16550 UART Driver.
 2. Microchip Clock Driver.
-3. Cadence MACB ethernet driver for networking support.
-4. Cadence MMC Driver for eMMC/SD support.
+3. Microchip I2C Driver.
+4. Cadence MACB ethernet driver for networking support.
+5. Cadence MMC Driver for eMMC/SD support.
 
 Booting from eMMC using HSS
 ---------------------------
@@ -214,7 +215,8 @@  GPT partition.
 Booting
 ~~~~~~~
 
-You should see the U-Boot prompt on UART0.
+You should see the U-Boot prompt on UART1.
+(Note: UART0 is reserved for HSS)
 
 Sample boot log from MPFS Icicle Kit
 ''''''''''''''''''''''''''''''''''''
@@ -451,7 +453,8 @@  copied payload and Linux image.
 
     sudo dd if=<payload_binary> of=/dev/sdX2 bs=512
 
-You should see the U-Boot prompt on UART0.
+You should see the U-Boot prompt on UART1.
+(Note: UART0 is reserved for HSS)
 
 GUID type
 ~~~~~~~~~