| Message ID | 20211013134012.9204-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | 91f27f3ba854409a3575a5b2d6e3f31526092f2b |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | mxs: power: Change sequence of enabling DCDC switches | expand |
On 10/13/21 10:40 PM, Lukasz Majewski wrote: > The imx28 uses following voltage supplies hierarchy: > > VDD_5V (VDD_BAT) -> VDDIO -> VDDA -> VDDMEM > \-----> VDDD > > One shall first enable DCDC on the parent source (VDDIO) and then > follow with its children. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c > index 35ea71a5ba8..c33170f06d3 100644 > --- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c > @@ -627,11 +627,11 @@ static void mxs_power_enable_4p2(void) > > mxs_power_init_dcdc_4p2_source(); > > - writel(vdddctrl, &power_regs->hw_power_vdddctrl); > + writel(vddioctrl, &power_regs->hw_power_vddioctrl); > early_delay(20); > writel(vddactrl, &power_regs->hw_power_vddactrl); > early_delay(20); > - writel(vddioctrl, &power_regs->hw_power_vddioctrl); > + writel(vdddctrl, &power_regs->hw_power_vdddctrl); > > /* > * Check if FET is enabled on either powerout and if so, >
On Wed, Oct 13, 2021 at 10:40 AM Lukasz Majewski <lukma@denx.de> wrote: > > The imx28 uses following voltage supplies hierarchy: > > VDD_5V (VDD_BAT) -> VDDIO -> VDDA -> VDDMEM > \-----> VDDD > > One shall first enable DCDC on the parent source (VDDIO) and then > follow with its children. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> The imx28 uses following voltage supplies hierarchy: > VDD_5V (VDD_BAT) -> VDDIO -> VDDA -> VDDMEM > \-----> VDDD > One shall first enable DCDC on the parent source (VDDIO) and then > follow with its children. > Signed-off-by: Lukasz Majewski <lukma@denx.de> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c index 35ea71a5ba8..c33170f06d3 100644 --- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c +++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c @@ -627,11 +627,11 @@ static void mxs_power_enable_4p2(void) mxs_power_init_dcdc_4p2_source(); - writel(vdddctrl, &power_regs->hw_power_vdddctrl); + writel(vddioctrl, &power_regs->hw_power_vddioctrl); early_delay(20); writel(vddactrl, &power_regs->hw_power_vddactrl); early_delay(20); - writel(vddioctrl, &power_regs->hw_power_vddioctrl); + writel(vdddctrl, &power_regs->hw_power_vdddctrl); /* * Check if FET is enabled on either powerout and if so,
The imx28 uses following voltage supplies hierarchy: VDD_5V (VDD_BAT) -> VDDIO -> VDDA -> VDDMEM \-----> VDDD One shall first enable DCDC on the parent source (VDDIO) and then follow with its children. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)