From patchwork Sun Oct 10 16:12:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 1539036 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=s7y4J5dR; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HS7B30tfVz9sRN for ; Mon, 11 Oct 2021 03:46:51 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5C7A836B4; Sun, 10 Oct 2021 18:46:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="s7y4J5dR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 91C1683694; Sun, 10 Oct 2021 18:12:50 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6C79383578 for ; Sun, 10 Oct 2021 18:12:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maninder.singh_1@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdaCLHlz0iSGMBaRxnVFD5QNJ3wRSrirD7i/5R4wwXCwHzP+DL9psBnPTkLFRgrgrB16ULufWJjlGBE9VakUWaXmDj+5q3elWALPpMD79aj+mcCvZQ/4rP9ViY+76xII8GcOXPbm8D0f2aPopqQCCrzfmQzKWUvp2I/sL2hcKVhQTLtm6nz5faeAkRtbE1hbPXb6jAQNsgQgf5C4e2cV8QZNS9p6WhhOT+2Uh3ePhaHChSPgQIDxy8qJnmwvxxlbHy1DanlHyRWN+ela2axDmuHIH67ACMA0AkZAEbSznraMQysXi9Rknm/RqLrKQKl1f+0hweHSGFhbGLUqAjwkLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ls3/WQOhZIQodWZFkjP/nlJCGiuFJJmmqVKqUcGCJ2I=; b=HwL3/DgwcxKykgTkZUAdw+EjEJS7vRl2i5SHYHzjMcSuJPG8tMd9oqCK21BMYRmrTGFVhPFiusCScC3I6MIZhRMRBxi/tN9rcse/oLhUApmt7jZj4IbUBAJTpu2718UryQfssVsnWIBvcIG6DT20rESrqjCTl8MzK7I+rH3ecRv0lVWOprJRJXDIwbKNU6071BFAMwkVkw/e/LMDzAFIGbwSekp26hlaASOQ+pi259DuaRM9ORP6eVpBB79Dh8OdLjlYq8J0S1KCGG0ldwLcE82aVGzdA7AqcVPUa6+a9YJwxnVYNbhomMAjHKqPTvQ2xbRY9lIQeA/58oWd7W9q7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ls3/WQOhZIQodWZFkjP/nlJCGiuFJJmmqVKqUcGCJ2I=; b=s7y4J5dR+o+HeQZNbMWipgmlETkI9kAFwDXk3rQl5bhwlW01AwHVIX68SUrGsd3r3eTVVneVMOTrigEEtpgLecMvEFAuDOq2xykS1KhU+sdWAL/7ZQ7++zrDTIuEH7Q5HHVxnqXR5SluPlXvEbjFa+zHKE2TnSfPRIg0jTeUy3Y= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4910.eurprd04.prod.outlook.com (2603:10a6:803:5c::17) by VI1PR04MB4432.eurprd04.prod.outlook.com (2603:10a6:803:69::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Sun, 10 Oct 2021 16:12:44 +0000 Received: from VI1PR04MB4910.eurprd04.prod.outlook.com ([fe80::11c1:63e6:86d3:26da]) by VI1PR04MB4910.eurprd04.prod.outlook.com ([fe80::11c1:63e6:86d3:26da%7]) with mapi id 15.20.4587.025; Sun, 10 Oct 2021 16:12:44 +0000 From: Maninder Singh To: u-boot@lists.denx.de, Priyanka Jain Cc: Maninder Singh Subject: [PATCH] drivers: ddr: lc_common_dimm_params.c : Fix Divison by zero issue Date: Sun, 10 Oct 2021 09:12:16 -0700 Message-Id: <20211010161216.6105-1-maninder.singh_1@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SJ0PR13CA0012.namprd13.prod.outlook.com (2603:10b6:a03:2c0::17) To VI1PR04MB4910.eurprd04.prod.outlook.com (2603:10a6:803:5c::17) MIME-Version: 1.0 Received: from lsv07131.swis.us-cdc01.nxp.com (192.88.158.246) by SJ0PR13CA0012.namprd13.prod.outlook.com (2603:10b6:a03:2c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Sun, 10 Oct 2021 16:12:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fac460ca-47d1-403f-8611-08d98c08cae7 X-MS-TrafficTypeDiagnostic: VI1PR04MB4432: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QMslvBYgnuAA5CFJeJ6BsehKXucfgEJFYZcPw5K+nhs3uyHv85gv9MakZht8pT1b+CnmqZmMraJ3KRQ92N0HawB2QAsk+/8xUdBhaSYC7RYMa/e1QBGVraQBsVxLbw0id00TPcCkgyBov6JLASPsvnXu96WYFrPDRdPS+nhLAp0DQ7OJNJUWFaU8pMVSKVxMqVLC6mK+UGK616tlyz731Dl2byTycXkZiUn6UO6uhMmxlceR7JeWzq5V1ENakz0fE6TuA1qXe5f+gLP8oWFY4iiQHmHxg+FkymEQlz2Pr/S6EHTT6J8dgvlkr54H15BFtdEtYXWJZZB75dc7mNy7xsh8h6N0FTWGXx+3fMwxjCm7d8WVpLq53uwQmAhg/iBRNXbd3x1qQCXFWtf5vS+tUOo7oOKTi2UnkS0nvDLLQRYt7UreD9lmoOSaEMRY5vTrhtgtPWxkGOvat08+8zly+isqFZ9BlfwGYpKXjNHUiWbjKuq0ekAgQ9p+VoSOBYIF4WZf3Nk/g/68MacRvL/vJdYqIWW/xmSZC2OUTUlVf7MjV+UO7inRJtMi4kcAO+7kvAz36xF9LF+1scQKyzOjX4nNCBaU38//peHMm1Xh9cgsuvVlvLNh+VnBGfdk/kMNya+FSbyVdbfCZs0KCrkeaCiKlJnlAOeC0W8Y86e3FMlN9bKQX7Auf4gZo2LYjaJHXDsfZe3wRJg3vyHlJ4UUVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4910.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(52116002)(7696005)(38350700002)(38100700002)(36756003)(6666004)(4326008)(508600001)(6636002)(5660300002)(66946007)(316002)(1076003)(37006003)(83380400001)(8936002)(2906002)(66556008)(6486002)(66476007)(86362001)(6862004)(26005)(2616005)(956004)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XMP4NA3+SXIOwopTyadc4qj0BfKQ2ASBC+SehGj3/Kw6dsh+rnvO2QOOFTH7tBAtcvOWNcEVKyEMQuKfAkQt8fHyyKA7vR/aT2txp3u0C/m9XFuuzFwxwVsXJrAGvOZyki5KDgb89i2uFpS5F/quJQSCTDhF+rdJDEg7a1YvlfuW0sz7YFFhUZxvBF2X5ZsgVr6JlxNkrK8Ya1YGKWUpiObNcP5xlVtRxcZDcXjrs/cJpfn1MiaQ4qQfxwLYtwxgmkBEajQCqPMDEsrm2E+e7F1csr1HT8UrErEkesKg94YiguRNHUNrjPlxrhNvGquelGXzz8RR1hYTxJZpL5rFb/VFyZaGiO/uah/60B3zvWTPMRK5GBOkYjqOxjeUwwJ4KE/YiiugRXAGWXHAvfXknF9py7vRpr02Kx/0LB03fVi7w5/gIbEKGyadEtsCdEXb2dumL5a2m0jxVAPAUM1iwuFGihBjv4QB9dQ618sv72piazPRqW7zc0rohhIShh9Fe28sLrKLkc9+jqMmwpu4BvqkCnuiQwRwdr3t1+pTWrB4FyD5ehfMcTl2DHvtXWQMcOK9Px+LDmZSh7e0+eBdtsqOU7y+x0bpGmoGulGWrLF1AsX5UXqzyWAfJUC3Q70Nhd0wbh3mTJC2C0YVutjAyMqviJBHlaJjoBgrATgwdJx7MYpWWvk+G5vA1y1klkp8SWSDG0AxXebDanF62vAxs8GN1d2QSv8EpjzoVJtvqrN7HJBe2r8JtSebVHxdhOT6KKbDXOY92HHhkC50sAJnSgCROtYHok1xNS+6b0J4i9Q9xvW+y2d/mPnM54sjXDHd3oYIlxDRnO31EE1UTgz2DdtmAwLhb60MC6dQKs22gApxCIt5zupKLSIks4eQ77A58X65bYNYHlJxaO7EgNnh35urwL5mICNb7tFQ6GhSxvoFx3JZSLsqcS/CmGGl7vb1o8PE72pBoQpp9G3KJIZ1doyldmgjNCDE36E4WgkeiwTCE2tZz0DsVAl+2d/9ouF+RcK1NRL8yY0o9QYiyB3g5PA7YJBOphs/IkxAVTFccMfUzsmKF1kVeQzmuzNdsAQc7vclwbwThKL4rrdfKM2vBRD8NaVAEQigEG9JPE1r2QPmigsJzkYxuWr+j6k4+EwMLAOcqoXzEkTQ7yfbeHADNbWwT/W2rZCb3fW2qdwAQsO/AZZmsKtKof5UtkScRfTBpGrPN9OvvkvCQomjtOVO7IdXywQ3RFdQ6uiPR8mIE2KzMHc086oB5KtRacfVue8ghjgR37WNn9VK9rm8C8GJPEDrEed1bYJUNbpD21+9EPtVsl6HexPZBa1iCAvCr1SN X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fac460ca-47d1-403f-8611-08d98c08cae7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4910.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2021 16:12:44.3252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 65luCTmcNlNGkUARvnvDDK9LiRtuyln20tNl6UCgyDImYq0q+rdgvs4rflqwQtd/ju3nmKOOrklOakELAbnpAcq7ME8YwsqPCfgxSuWhOC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4432 X-Mailman-Approved-At: Sun, 10 Oct 2021 18:46:19 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Adds check for memory clock variable before calculating caslat_actual. Set mclk_ps to slowest DIMM supported if mclk_ps is found zero. Signed-off-by: Maninder Singh --- drivers/ddr/fsl/lc_common_dimm_params.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/ddr/fsl/lc_common_dimm_params.c b/drivers/ddr/fsl/lc_common_dimm_params.c index d299d763db..d738ae3a7c 100644 --- a/drivers/ddr/fsl/lc_common_dimm_params.c +++ b/drivers/ddr/fsl/lc_common_dimm_params.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* * Copyright 2008-2016 Freescale Semiconductor, Inc. - * Copyright 2017-2018 NXP Semiconductor + * Copyright 2017-2021 NXP Semiconductor */ #include @@ -23,7 +23,7 @@ compute_cas_latency(const unsigned int ctrl_num, unsigned int caslat_actual; unsigned int retry = 16; unsigned int tmp = ~0; - const unsigned int mclk_ps = get_memory_clk_period_ps(ctrl_num); + unsigned int mclk_ps = get_memory_clk_period_ps(ctrl_num); #ifdef CONFIG_SYS_FSL_DDR3 const unsigned int taamax = 20000; #else @@ -37,6 +37,12 @@ compute_cas_latency(const unsigned int ctrl_num, } common_caslat = tmp; + if (!mclk_ps) { + printf("DDR clock (MCLK cycle was 0 ps), So setting it to slowest DIMM(s) (tCKmin %u ps).\n", + outpdimm->tckmin_x_ps); + mclk_ps = outpdimm->tckmin_x_ps; + } + /* validate if the memory clk is in the range of dimms */ if (mclk_ps < outpdimm->tckmin_x_ps) { printf("DDR clock (MCLK cycle %u ps) is faster than "