diff mbox series

[25/25] scripts: ensure the cocci script for miiphy_register does not leak the MDIO bus

Message ID 20210927112205.301876-26-vladimir.oltean@nxp.com
State Accepted
Commit 4df9f5e39fb224a4857c3411b4cbe419e4d339e8
Delegated to: Ramon Fried
Headers show
Series Fix some non-NULL terminated strings in the networking subsystem | expand

Commit Message

Vladimir Oltean Sept. 27, 2021, 11:22 a.m. UTC 
When mdio_register fails, mdio_free should be called on the mdiodev that
was previously allocated with mdio_alloc.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 scripts/coccinelle/net/mdio_register.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/scripts/coccinelle/net/mdio_register.cocci b/scripts/coccinelle/net/mdio_register.cocci
index 31a40360f99e..7d11281f4678 100644
--- a/scripts/coccinelle/net/mdio_register.cocci
+++ b/scripts/coccinelle/net/mdio_register.cocci
@@ -21,7 +21,7 @@  identifier readfunc, writefunc;
 + mdiodev->write = writefunc;
 + 
 + retval = mdio_register(mdiodev);
-+ if (retval < 0) return retval;
++ if (retval < 0) { mdio_free(mdiodev); return retval; }
 
 @ update_read_sig @
 identifier mii_reg.readfunc;