From patchwork Mon Sep 27 11:22:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1533288 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=qx24vn1n; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HJ0jm2Ftrz9tk7 for ; Mon, 27 Sep 2021 21:27:40 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CC69F83676; Mon, 27 Sep 2021 13:27:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="qx24vn1n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8C9A1835B6; Mon, 27 Sep 2021 13:23:16 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on061b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::61b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6CBCD83627 for ; Mon, 27 Sep 2021 13:22:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LoBkDQOw/dbP5qZ93ouio1fEoqV5otkGg9ChFEvVEUA3B9rMx4RWnH0cQ/qM2n4ftU0IP0NshWSpYmcMb4X2vRu/fPxcjumzQO/p+NcoK1oIbxLgrbO5b4Pf12qiIi9aki94qgbXYNQdKurW+sLIMgt7EJaUtsawYl3Of3TyQXCx99X/QUBCab3uERLrM3JLnP4i5cPJK1/kqmfqgwqZbPG0+LwoPhRzWvAhimJdanKt86J5NlKcHrQLXAa7Lpt/P5mJGik46u5InaWbPV5qSwTw2AnEQJzh5JqAeMGzMopLNxbZdHOLyBH1pQA4gE7lfvPfrrfblxiQhyVF7bHdkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wMCXjz7846Fyf61daBsihT7aBAuJy8XAryv/TZASuRw=; b=Jw7zyW/vx4kmhAMpR3nzAPhEMYZtfwaNfTA3PCZpCjtQyYZs7ZbHx29Y/z1OEyFEKIOampjuCJmjc1lPKhmZEq43KTMcM5ziQmuMVnV7et+pq5drha57S4vZQCQSXedUjCKCFY1RlIUIQSFz7W2t4p1nPU/xaEW+FuLCNCZm4V0LJz5OyhOL3r2ROKy3aNNaqZrPA6khYGiam+vjsk4Y9UzWjkGaKHxrqg1OxE1ppUQ4R01ayv+KoI0Bzonx88qhJSvAyTwvnnVvHDLELb0XeLeR+poaQssEyDHrYXqdqw6rq+RJQRrrJno3I6ssyIlX1TWS4DHkl/ImG7qE1icsRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMCXjz7846Fyf61daBsihT7aBAuJy8XAryv/TZASuRw=; b=qx24vn1nRy66VVBpZAwuYCIhcdjWiSpBjFlv9GZPlMmVfubwArBD9lZG5haPXcS6mi3HnElVLwjIyWePbdoV64HEpDJex+NuM1Cv0y6t7zdppxZWH/mb4vnRa1hHTnPmYDGyxEZwRc5MUi7/1U1qSQgrPoJXaWWyBNoMdNyB8Uk= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:31 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:31 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 20/25] net: mdio-uclass: rewrite dm_mdio_post_probe using strlcpy Date: Mon, 27 Sep 2021 14:22:00 +0300 Message-Id: <20210927112205.301876-21-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26954e48-d3eb-4841-86cf-08d981a918f3 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:409; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +aJLrNDkpJ2h3WemFiaaD2v6BAzy9O3OP36R22wsTaLMdWQzyGSJNH2+0ppzzBkxpn9J++rdbJ3k32kKi0CYQWUkOSVYP9I6N20Fz6qyES5TgAy5wvHuL4qZCvOQ66o492vmL5lvwDlT8WUv7G6x8wa1wCkTBl9cjQD4Q/TmmCClyKOGPFECK2nPgo1uWzlRnqpEXLhAn5PnsUYdGLE97ICLzYxS1TczNkAGP+RjDnEN1lQdNz0kvL/GgpmoCNPN4leCIncOaHBWC+0k47nwCOUfwNIR6eKNMqzsVS8D1w5E3CNl4qyQMWDZW728ZsrBXLAd02lHA1Q8uc5wq4fbwvwAabPSUSNQE8WIOzLp8SqFSZz7obA+US8oqtM+QLUzPxUr5uqAHiSlwjAr+7+pu+X5TmMURMdPjAh7FTwJLjMvpcW8ZGVqLxAblMjDPzdL3PzUZS+BBVFYDdbmrAeaZ10ECKI4nVsZt2wKPAQMz/9q7YVQkhaU+tceQnGXLUbxtNAUijjvoHrs7TlczfyOThTAwIt91r4UGFvptVml2+9Gx/OvZfDBM+FIjWgyf0CxcB6riZzL4qS3I5qUYG/ZK/fJalTPaGBScy8QBBqDFB28GXPgNlIrvtjodDxwz1Me7HVe25zNQ7EYQoXpyEOecHONP2n/P2E1sGn80hjs9zyo9lnNiFkgz5WGfwY4MbMmTmSBdb5yYP0UVcZbJ7OKhJa9ZWurEd4a/PYjiFIUc0I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(4744005)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008)(156123004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TpiiKx0JOxCPutfKRnvxCWGrGZ7x3tGvB3J47/083a4ruTKkOhVMOBjxfyDgjE/LdvYWQQBEt5vq+h8Ms2RYLXJ80hpn4de4EFD99wDJ1jWdVamhlvfxKI379XM817JGRuv9xAUICtEK51obDaVwYvzRh8YcAlLqaCwmBEDHY3m3/XNUl2kogn3rceEalz9+GDM+0n1OO+Nkv47gt1O22uHtPxDYY7GkdZDJ+MRFkNHeQWrua3d7UwMbFFIadE7i9LMdGUbd06hN6LZO08WftJZA7w+RQokNabE9GukwG7+R3ylK28wHCOPNC/8kJoMij7rU84O6bE9d5ODIfHQsynspPK8yd7h+oPHx826rafOmir4sIV1lDLj6VWUpMlucEPxF4YsAk2Sq3ew8LrhvB0TcmKI69qzKGh08Bcjk7dE+58zreZ3DvIUYYvNAV8IAXlGCFpwGuwpTQGLKYxbTM2rUBVmctBYyr2ADdIAbnxQ/kNqB/HJPM2rMaBiEEuB8bjJ5q6ZHgUSd50CLzfdVhrz8rDS4Gjm7YjlQbCC1776NLRN5EHPcRfCdKoyM0ONinTNlMq4nNhYEUockGtCksPz6LvHH3kk7wCcAcIs97tXsw/HnG9wPAAQK4e1ixWbDwNpqucUfdjRlkGlHk5TByotwfj3FAqh/NRRMW8jNuuF9KT1H0qGmsewmcRxXTs/s/NcEBJ33/xbt6xIqkwxHiMqZl2yLKauGL2d5mjUvUPzYzfn/GPwTqm4kDlVLSF+HF4Q3y82JaLqI2/aoZ0eesNo9dNQrUfVvYR82Stz9eyUYSukmlytW7qh9yUa4VmuxljKQAyfsrEtHO2FwPjtj64k3F1tfZEo+r4RJblKVx1/c0oVLQK9ncl6n2Peq7Rz/GdZn/SaPEZsyyYRPX1qGhGtUpMeUc0ox+ZMhFP1b1Rrnp56Qgu0zOewF+WBu46fLGq/6S3Bgf+NX1jDt0YKGHfyRvpqb1ond6ag9TPyZoKzbwLkYDbpXUUHrwHlPHiAmY5H2ISFSvzo4t/vuVDPq6NX+T7pfMaL8DQ1H1kSzH1Uz0RApA8XZpArXlxqNt1eD9VmfrnjNRo1NhQdpKd4qJyWqKXLA6bNGcFRhz+ZTlX1to2bQSard+rQ1AGw4GG/ly4ArjuEveie3AvJcFo0l2URWUX3hku3z9wsz4F0XBw+DKUKtlw9VUt02akiVGWov/s+34zG7yf3aVTefLe2YetJvzM+GTl21qUylyx9gabZLKEetHzELLCn4aAF5dfwjGRc2x9PvQFusxf5BYiPeZ9zfly6oLZdxNBplx9rAbhul/dDibgvubK7KiowrtoRA X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26954e48-d3eb-4841-86cf-08d981a918f3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:31.9144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cwtPGI55edFFnJ2Ejd/3s+ijNrfJxL5PvyFbJJObZZ4GE/Vs+1eAXa0rALS32MwAq/dl3SCxwaAj9wSH0qo2MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean dm_mdio_post_probe used to be vulnerable after truncation, but has been patched by commit 398e7512d8d7 ("net: Fix Covarity Defect 244093"). Nonetheless, we can use strlcpy like the rest of the code base now, which yields the same result. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried --- net/mdio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c index 1b687765b8ca..e74e34f78f9c 100644 --- a/net/mdio-uclass.c +++ b/net/mdio-uclass.c @@ -101,7 +101,7 @@ static int dm_mdio_post_probe(struct udevice *dev) pdata->mii_bus->write = mdio_write; pdata->mii_bus->reset = mdio_reset; pdata->mii_bus->priv = dev; - strncpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN - 1); + strlcpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN); return mdio_register(pdata->mii_bus); }