From patchwork Mon Sep 27 11:21:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1533281 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=LQ40o1uc; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HJ0hD6xLxz9tkM for ; Mon, 27 Sep 2021 21:26:20 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E58FA8363C; Mon, 27 Sep 2021 13:26:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="LQ40o1uc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 97719835F3; Mon, 27 Sep 2021 13:23:13 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on061b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::61b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 20AF783626 for ; Mon, 27 Sep 2021 13:22:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NfCsLX2u5Fu90tffLnkKe2YZHq7NT3GtGIGFhk5l0/XsFph1dcHMHcrWUAcy0x/fGZBeL05Bmabvlrp9FKutBOUN+4JCuYk7sLMrmPjArNHFcKqTiw9gfvlwvGQ9Nu1AG+AFXM4ZfDVnUcckEhOrZZXs0/QM1wmduzB+LwLPO5ralf8+uBFOMLDINUYbiQTGcEhh6zJFR1w07g82XQ6/kXe+mRQHRgWUV/m4R6P+CIjnxeaLz0bPmNpuv1cMAu6CeKRnfDXGMNiPYEsGz85DUwPmxUVYGiZnHmNObWdw1nczER9hwtLtqE3ZdloW+hXYhb81GtOrZzcmpBcixWZL+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y2ayc/VR3qNx9dq/03UI4uaDgPTJUSmE6foa9siRFbA=; b=VeT+CXF8ym3ni6bVVydbljkiLju9sxBNAmMvQVOGUgP9rvhhFJg7sShoJ8K6gccqIbP9sjcIMxu9L3Oy2XyEkfEJ0sZI29q7POi9bteaFQls2Fs3iSeQHUHCfDZeOE4bWL1+1rRpUQvy6RQUwz3wB3UQVttXL5Wu9Pm64lL2HQMohpmPNogKqqjz3PE4A1V9O4CXAvs0nXZ/lf8kvbydHzMKyLeqR7Stids4xV9/g+EKd3fysvj2FBgumXfxPfS36skCE9QaIqzZrIn6wuh+Bl8S59TWA+zmIEE+zrq0WoL17vUw9IeAxiGmYd6yNjvYs5z8BKjFyjseLllHupNCPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2ayc/VR3qNx9dq/03UI4uaDgPTJUSmE6foa9siRFbA=; b=LQ40o1uc0hHLGNhIlzuoPBqxHS8HBu29vijHZTnww1nbJYkyNPqXl0TY2a0AVN3yf1sRb0kh1DAc7DFiyWKoIf6O5TMYkbnxu7Xh7zKwMAKqplDm7WoIm5hLSY3I7A2VwNDu1S057i2NnKFsd7WIi1zQYVKoD0B0KTC1mnAqaHc= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:31 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:31 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 19/25] net: qe: uec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:59 +0300 Message-Id: <20210927112205.301876-20-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2629cf48-4b96-4431-5390-08d981a9186d X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bqhW1YWQ5nvwqnHbbVo0YJjg5AVEJF2bK1XKWtq5Dt4u820IUIw3mr8IrHf5dCMo9THz5L7gJkMmzLVGnjWn9fmFdxEHttfS+VuMEWw0gAewRHLyKeuxBOaPKEyRVfNpwYiliguY22rIi01J7zuHQb6DocAt8JRqLiaz4C76ldFf4XilNj7teB3nHE/9mC1oj6Kfts5eZEayqq0D+pce63FJVAcK4KyQiXanvbqC7XRi2I/Jdo0Xorb1TSNLB0gYnL1VH5skPcMUwwhDR0ND8U7tgmUbm063fa1bAx2OnUuc2e7Wa1qwfYQMfmqeHJOs/3WsFFqGkcopuMo+bUXq0D7LnVXlW4qJXxHK9VA1K55nj0SrRjFBaBFzkugIloakcOtJupz0xQ47RcKbyzfog2lDOy1/z6W2iizwhTVTfN391OwcW/91JM/orYd2BP+TQPBzMAs1X4+EM4/rHPcZjvPXCH0kFJT5/AGrjljE0TfA8K+EA2Z19wuVhCgkTYsMY8Icznk8Ei1MvmfxcT++prkoul7FY/PaWDGM01PWxYdtHX4YkAz3adhucNcHQ2iKHrvVjA0ydLR5F9gHtf0iaZ3V5LRgo1yP6yTHWketUXZ+CFXzvwGsOxOTMVAZfBt3AgOb5M6Ty8HAzc1E+J5KiVxcyIuqBDpC2qzGdmLA4uxEa2uhKNawSQxX/2wSB6j4CTyooyCkQwi6dyNlXZbMfg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gU3qcgxMFngMWABLCD4VQpQ+ROdHkxmDajO9yUErqXr96eeR2zrxiDBQnxXSQ3Iscd4R42myjPJ/aGREC3n8w5fTYinKr/Ab56mHEUkxGHz8nUMscFYiTiisbWgkl+gtX9TQswvlW1TGMFUOH6clzF1V8totaDafCc9fzOsnrL5kEFo9jTaHcDqru/keR0rfzEqa9WNTSsHI2IfjvuiI3ZYTIuTVuC/ghjcTbBzPrV1lOiK51AGyjZ8pMgK0/XrBC7p2im8szdKRRgD9QuRgBeTR1kV4Ea6PQdgrUvqQyS+66JuNiO8BXELi5CITyT+kiTnAZUbSYazHH7bJMrlrbXz+dmCxEVHKmw2nMwaQ1CJV/5f7dBgmYB6Q/COaz5SKefa7k4q9NATlggnDxxjkXrf0ado+tUw+F28euJgdEmbtmm4WD0yLYrqASdsU1WpsTBzbW1ZRxHoQ9NoQUAO7+mnJF5Ti3OqyjIzr+NSqs+d/RkLh2raonARDbNO6qn48u1tl2zNPNY+wmcfjNu6PGb+VwG91oi3tGs5v6D4w9/JZZa6UpTTPzLMnK3ilj8ZKbY4wb8HutuDpf25azYunhI/s1Cbu8+R6NFVF4SMFVR07qhT1clhjibOoQejv/RWfpQDBl7LvWiy2zO7wLACCa33yeGZwcrEr42GCsNnFvWboQLcsRYkVS4QIx7D3F1K3qDN6U2HOukjDtofCJIfErjrkSMKZpG88x/w3igDnzSw4XzwdWTakCuMUAZdpTGnEaVWzWZnzpMdr710RYxLqWy3+pgSEGhVCG4BIQ7VEfvBJH2TO/JuxE71B3sfXlWWxlrUMeNPrLSY4+KO4lUBzHV6YrNI+y/NfhPBayn96qtC/LcEQVFv3CtRm91N/JSPkBGCjo37zgnH+nCu+suVu1j35oxWas/tCXnAC9GtA8QmlasKVTxm0mAdxcR7GlP0qb2I1kk5+VEScKyDX2PId5uYQtUFpZusPnSOC8vyZajlK2+GFb+D7mp94kmEl4GpSUCLPgv44FmLJq8ofLGguhQHJ5DlTYaBPaolkvArCLYjxk+rE3uVTOdGxDdDYJaSadYJN1PGR4F+5QtryAaXosazlhr531kvmm+4o80RS1Fl1TuMZRb5ucDCXczegl790+vtJr97lNymPFf7/Ve0obujPJjuAGdxc2GHe5/EC547j9SP1ogrjaa9xfMxFQ/hQ8RCg4+q9oRLc/EVyF4DKy0oyIajxIESIOoWzi72+Id4iFZYRnrZQ+Y+B17h80ult8x/zZdrKfhLIoBbUPKUleXLUdBiSnmlzYHeqVovgSwFgh6J1ycErL8LhbWF83x07 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2629cf48-4b96-4431-5390-08d981a9186d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:31.0978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 36Q8BdwBvByNLfXVXZXisSQwErspD2Ix3LCnRLbHH7If5z6oOJeO8em/qiiBPbEdkOYwlpSQzBBA4C6Jqgrm2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried --- drivers/qe/uec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c index 5da971ddc0af..c4bd5c4a147f 100644 --- a/drivers/qe/uec.c +++ b/drivers/qe/uec.c @@ -1407,7 +1407,7 @@ int uec_initialize(struct bd_info *bis, struct uec_inf *uec_info) if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = uec_miiphy_read; mdiodev->write = uec_miiphy_write;