diff mbox series

[u-boot-marvell,v2,3/6] arm: a37xx: pci: Do not automatically enable bus mastering on PCI Bridge

Message ID 20210925225446.1872-4-kabel@kernel.org
State Accepted
Commit 95e101e86ae9d4dbc29ab82bcf1cfa8820a7ba4a
Delegated to: Stefan Roese
Headers show
Series A3720 PCIe enhancements | expand

Commit Message

Marek Behún Sept. 25, 2021, 10:54 p.m. UTC 
From: Pali Rohár <pali@kernel.org>

Now that PCI Bridge is working for the PCIe Root Port, U-Boot's PCI_PNP
code automatically enables memory access and bus mastering when needed.

We do not need to enable it when setting the HW up.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
---
 drivers/pci/pci-aardvark.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stefan Roese Oct. 8, 2021, 6:21 a.m. UTC | #1 
On 26.09.21 00:54, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
> 
> Now that PCI Bridge is working for the PCIe Root Port, U-Boot's PCI_PNP
> code automatically enables memory access and bus mastering when needed.
> 
> We do not need to enable it when setting the HW up.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 692210ded9..8c025dc45d 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -910,12 +910,6 @@ static int pcie_advk_setup_hw(struct pcie_advk *pcie)
>   	if (pcie_advk_wait_for_link(pcie))
>   		return -ENXIO;
>   
> -	reg = advk_readl(pcie, PCIE_CORE_CMD_STATUS_REG);
> -	reg |= PCIE_CORE_CMD_MEM_ACCESS_EN |
> -		PCIE_CORE_CMD_IO_ACCESS_EN |
> -		PCIE_CORE_CMD_MEM_IO_REQ_EN;
> -	advk_writel(pcie, reg, PCIE_CORE_CMD_STATUS_REG);
> -
>   	return 0;
>   }
>   
> 


Viele Grüße,
Stefan
diff mbox series

Patch

diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
index 692210ded9..8c025dc45d 100644
--- a/drivers/pci/pci-aardvark.c
+++ b/drivers/pci/pci-aardvark.c
@@ -910,12 +910,6 @@  static int pcie_advk_setup_hw(struct pcie_advk *pcie)
 	if (pcie_advk_wait_for_link(pcie))
 		return -ENXIO;
 
-	reg = advk_readl(pcie, PCIE_CORE_CMD_STATUS_REG);
-	reg |= PCIE_CORE_CMD_MEM_ACCESS_EN |
-		PCIE_CORE_CMD_IO_ACCESS_EN |
-		PCIE_CORE_CMD_MEM_IO_REQ_EN;
-	advk_writel(pcie, reg, PCIE_CORE_CMD_STATUS_REG);
-
 	return 0;
 }