Message ID | 20210925003055.759305-6-sjg@chromium.org |
---|---|
State | Superseded |
Delegated to: | Heinrich Schuchardt |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=KJn1IsLL; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HGVLR6Y9tz9t4b for <incoming@patchwork.ozlabs.org>; Sat, 25 Sep 2021 10:35:43 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 952B4834E7; Sat, 25 Sep 2021 02:34:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KJn1IsLL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 57CA283536; Sat, 25 Sep 2021 02:32:10 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA8B08350C for <u-boot@lists.denx.de>; Sat, 25 Sep 2021 02:31:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-oi1-x22a.google.com with SMTP id s24so14264431oij.8 for <u-boot@lists.denx.de>; Fri, 24 Sep 2021 17:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0OG8BmhYwXGZOXMEQs9G4xd3OcBUA8lIQ7pyelErFN0=; b=KJn1IsLLJwrZghKz0V04xMvSwI6PaxCnDr4Gzd50osk4FMLthq7GmVmHFf8x5qtkNU ZVE4lq8uteeDi8GOEtjnHLI6abOTabsBQyOYfDbao1l+FI4P5oTYBQZNpan35RP9lD7S 98Bu3xndQAfRZfk5gWHkyWIeTL+ZA75cjtz+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0OG8BmhYwXGZOXMEQs9G4xd3OcBUA8lIQ7pyelErFN0=; b=1BJ9XDtHgK3NH1EG4PaUkM5SrWpClMWYnDRw9UvEIUcZSLHJA6MI4YiwLj7y881EbT UGzfcNZj9ONZ1cbrts8jDWY4QVqqWJFTdu6RDJ7T+msnnd4VsR+FjKMD2DOKIkmOrpRZ n++oB/mB6DIB68Jatcyw1IuFjw5+s6iWHEv5QVfBv+N1m86dGHxdQYxxJ9kHvMv+txGP 1o4x/h4IHBbp/WMsUXYucLSIc/RIBzatVP1mWoFb1E4oVEtfL2t6Ctv9tlo8NjwVu9M2 zyy3sm4quuHt5ywm0BMIdJhk4NbhkqiNSbMghKt+CExUxTkv1nA+pjDpRGPIQunkFmlr dLOg== X-Gm-Message-State: AOAM531VL5YCdd20GjxmzoWdtRcd9uFoX+KDYHBtBlbcCbbBrvlxQ5Uw jdbajlI3CQn4tbJNvwt+8y4fZy2xiMz7sg== X-Google-Smtp-Source: ABdhPJwqr/ZfSN03wMnpTxU87paEfPe0QOv4dRyzPpi8woRkhxeGjZt4paLfZj0eHfLwQmrL6Zqn6Q== X-Received: by 2002:a05:6808:2d2:: with SMTP id a18mr3746622oid.99.1632529877904; Fri, 24 Sep 2021 17:31:17 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id y83sm2491462oia.47.2021.09.24.17.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 17:31:17 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>, Bin Meng <bmeng.cn@gmail.com>, Christian Melki <christian.melki@t2data.com>, Tom Rini <trini@konsulko.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>, Simon Glass <sjg@chromium.org> Subject: [PATCH v2 18/39] patman: Use a ValueError exception if tools.Run() fails Date: Fri, 24 Sep 2021 18:30:34 -0600 Message-Id: <20210925003055.759305-6-sjg@chromium.org> X-Mailer: git-send-email 2.33.0.685.g46640cef36-goog In-Reply-To: <20210925003055.759305-1-sjg@chromium.org> References: <20210925003055.759305-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean |
Series |
efi: Improvements to U-Boot running on top of UEFI
|
expand
|
diff --git a/tools/patman/tools.py b/tools/patman/tools.py index 877e37cd8da..23ddb124804 100644 --- a/tools/patman/tools.py +++ b/tools/patman/tools.py @@ -348,7 +348,7 @@ def Run(name, *args, **kwargs): result = command.RunPipe([all_args], capture=True, capture_stderr=True, env=env, raise_on_error=False, binary=binary) if result.return_code: - raise Exception("Error %d running '%s': %s" % + raise ValueError("Error %d running '%s': %s" % (result.return_code,' '.join(all_args), result.stderr)) return result.stdout
The Exception base class is a very vague and could be confusing to the test system. Use the more specific ValueError exception instead. Signed-off-by: Simon Glass <sjg@chromium.org> --- (no changes since v1) tools/patman/tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)