| Message ID | 20210925003055.759305-5-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | efi: Improvements to U-Boot running on top of UEFI | expand |
On 9/25/21 02:30, Simon Glass wrote: > For the EFI app, we must embed the devicetree in the ELF file since that > is the only thing that is run by UEFI. Drop the warning to avoid > confusion. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - Add new patch to drop the OF_EMBED warning for EFI > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index a09f48f84b2..784efd4ef6e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1087,7 +1087,7 @@ endif > ifeq ($(CONFIG_DEPRECATED),y) > $(warning "You have deprecated configuration options enabled in your .config! Please check your configuration.") > endif > -ifeq ($(CONFIG_OF_EMBED),y) > +ifeq ($(CONFIG_OF_EMBED)$(CONFIG_EFI_APP),y) > @echo >&2 "===================== WARNING ======================" > @echo >&2 "CONFIG_OF_EMBED is enabled. This option should only" > @echo >&2 "be used for debugging purposes. Please use" There are 47 defconfigs and 5 include/configs/*.h using CONFIG_OF_EMBED. doc/board/intel/slimbootloader.rst and doc/board/coreboot/coreboot.rst require to use it for building U-Boot. Is there a migration requirement and plan? Best regards Heinrich
Hi Heinrich, On Sat, 23 Oct 2021 at 05:42, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > On 9/25/21 02:30, Simon Glass wrote: > > For the EFI app, we must embed the devicetree in the ELF file since that > > is the only thing that is run by UEFI. Drop the warning to avoid > > confusion. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > Changes in v2: > > - Add new patch to drop the OF_EMBED warning for EFI > > > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index a09f48f84b2..784efd4ef6e 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1087,7 +1087,7 @@ endif > > ifeq ($(CONFIG_DEPRECATED),y) > > $(warning "You have deprecated configuration options enabled in your .config! Please check your configuration.") > > endif > > -ifeq ($(CONFIG_OF_EMBED),y) > > +ifeq ($(CONFIG_OF_EMBED)$(CONFIG_EFI_APP),y) > > @echo >&2 "===================== WARNING ======================" > > @echo >&2 "CONFIG_OF_EMBED is enabled. This option should only" > > @echo >&2 "be used for debugging purposes. Please use" > > There are 47 defconfigs and 5 include/configs/*.h using CONFIG_OF_EMBED. > doc/board/intel/slimbootloader.rst and doc/board/coreboot/coreboot.rst > require to use it for building U-Boot. > > Is there a migration requirement and plan? Actually people were never supposed to use it. I sent a series today which cleans this up quite a bit, so that I think many of the boards using OF_EMBED can drop it. TBD though. Regards, Simon
diff --git a/Makefile b/Makefile index a09f48f84b2..784efd4ef6e 100644 --- a/Makefile +++ b/Makefile @@ -1087,7 +1087,7 @@ endif ifeq ($(CONFIG_DEPRECATED),y) $(warning "You have deprecated configuration options enabled in your .config! Please check your configuration.") endif -ifeq ($(CONFIG_OF_EMBED),y) +ifeq ($(CONFIG_OF_EMBED)$(CONFIG_EFI_APP),y) @echo >&2 "===================== WARNING ======================" @echo >&2 "CONFIG_OF_EMBED is enabled. This option should only" @echo >&2 "be used for debugging purposes. Please use"
For the EFI app, we must embed the devicetree in the ELF file since that is the only thing that is run by UEFI. Drop the warning to avoid confusion. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Add new patch to drop the OF_EMBED warning for EFI Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)