| Message ID | 20210920121503.40151-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | Accepted |
| Commit | 001615386aff815a8721f8acffefbc82e9dfd149 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v2,1/1] fs: avoid superfluous messages | expand |
On Mon, 20 Sept 2021 at 06:15, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote: > > Output like the following is quite irritating: > > => bootefi hello > Scanning disk mmc2.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc1.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc0.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > > Albeit a whole disk may be formatted with a filesystem in most cases > a partition table is used and the whole disk (partition number 0) doesn't > contain a filesytem. Some partitions may only contain a blob. Not seeing a > filesytem on the whole disk or on any partition is only worth a debug > message. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > v2: > Explicitly mention in the commit message that a whole disk may > carry a filesystem. > --- > fs/fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, Sep 20, 2021 at 02:15:03PM +0200, Heinrich Schuchardt wrote: > Output like the following is quite irritating: > > => bootefi hello > Scanning disk mmc2.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc1.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc0.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > > Albeit a whole disk may be formatted with a filesystem in most cases > a partition table is used and the whole disk (partition number 0) doesn't > contain a filesytem. Some partitions may only contain a blob. Not seeing a > filesytem on the whole disk or on any partition is only worth a debug > message. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/fs/fs.c b/fs/fs.c index 7c682582c8..023f89cafe 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY; static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc, struct disk_partition *fs_partition) { - log_err("** Unrecognized filesystem type **\n"); + log_debug("Unrecognized filesystem type\n"); return -1; }
Output like the following is quite irritating: => bootefi hello Scanning disk mmc2.blk... No valid Btrfs found Bad magic number for SquashFS image. ** Unrecognized filesystem type ** Scanning disk mmc1.blk... No valid Btrfs found Bad magic number for SquashFS image. ** Unrecognized filesystem type ** Scanning disk mmc0.blk... No valid Btrfs found Bad magic number for SquashFS image. ** Unrecognized filesystem type ** Albeit a whole disk may be formatted with a filesystem in most cases a partition table is used and the whole disk (partition number 0) doesn't contain a filesytem. Some partitions may only contain a blob. Not seeing a filesytem on the whole disk or on any partition is only worth a debug message. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- v2: Explicitly mention in the commit message that a whole disk may carry a filesystem. --- fs/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)