diff mbox series

[06/11] pci: pci_write_config can be static

Message ID 20210917121130.526216-7-vladimir.oltean@nxp.com
State Accepted
Commit f98aa78ee4617dcaacb8f5ce1a91cb4afe7e7434
Delegated to: Tom Rini
Headers show
Series Drive-by PCI W=1 cleanups | expand

Commit Message

Vladimir Oltean Sept. 17, 2021, 12:11 p.m. UTC 
To avoid W=1 build warnings, declare this function as static, since it
is not used outside of this translation module.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/pci/pci-uclass.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bin Meng Sept. 18, 2021, 6:55 a.m. UTC | #1 
On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/pci/pci-uclass.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tom Rini Oct. 3, 2021, 11:33 p.m. UTC | #2 
On Fri, Sep 17, 2021 at 03:11:25PM +0300, Vladimir Oltean wrote:

> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index ce2eb5da2ca5..20bddb597588 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -304,8 +304,8 @@  int pci_bus_clrset_config32(struct udevice *bus, pci_dev_t bdf, int offset,
 	return pci_bus_write_config(bus, bdf, offset, val, PCI_SIZE_32);
 }
 
-int pci_write_config(pci_dev_t bdf, int offset, unsigned long value,
-		     enum pci_size_t size)
+static int pci_write_config(pci_dev_t bdf, int offset, unsigned long value,
+			    enum pci_size_t size)
 {
 	struct udevice *bus;
 	int ret;