diff mbox series

[03/11] pci: pci_bar_show can be static

Message ID 20210917121130.526216-4-vladimir.oltean@nxp.com
State Accepted
Commit f5164f6b255a16c856af91b21f432292b8ac8542
Delegated to: Tom Rini
Headers show
Series Drive-by PCI W=1 cleanups | expand

Commit Message

Vladimir Oltean Sept. 17, 2021, 12:11 p.m. UTC 
To avoid W=1 build warnings, declare this function as static, since it
is not used outside of this translation module.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 cmd/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Sept. 18, 2021, 6:55 a.m. UTC | #1 
On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  cmd/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tom Rini Oct. 3, 2021, 11:33 p.m. UTC | #2 
On Fri, Sep 17, 2021 at 03:11:22PM +0300, Vladimir Oltean wrote:

> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/cmd/pci.c b/cmd/pci.c
index af75a6cfff4a..ebe7c0fc5377 100644
--- a/cmd/pci.c
+++ b/cmd/pci.c
@@ -59,7 +59,7 @@  static void pci_show_regs(struct udevice *dev, struct pci_reg_info *regs)
 	}
 }
 
-int pci_bar_show(struct udevice *dev)
+static int pci_bar_show(struct udevice *dev)
 {
 	u8 header_type;
 	int bar_cnt, bar_id, mem_type;