| Message ID | 20210912142243.9912-2-samuel@sholland.org |
|---|---|
| State | Accepted |
| Commit | 6617894b6903e1cfc829add1558143be75d6bcd0 |
| Delegated to: | Andre Przywara |
| Headers | show |
| Series | phy: sun4i-usb: Support VBUS detection via power supply | expand |
On Sun, 12 Sep 2021 09:22:40 -0500 Samuel Holland <samuel@sholland.org> wrote: > Both of these messages log the GPIO number of the ID detection GPIO, > which is not terribly useful, especially in the VBUS detection function. > > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > drivers/phy/allwinner/phy-sun4i-usb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index 82713b83815..5302b809ee6 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -393,8 +393,6 @@ int sun4i_usb_phy_vbus_detect(struct phy *phy) > struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; > int err, retries = 3; > > - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); > - > if (usb_phy->gpio_vbus_det < 0) > return usb_phy->gpio_vbus_det; > > @@ -417,8 +415,6 @@ int sun4i_usb_phy_id_detect(struct phy *phy) > struct sun4i_usb_phy_data *data = dev_get_priv(phy->dev); > struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; > > - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); > - > if (usb_phy->gpio_id_det < 0) > return usb_phy->gpio_id_det; >
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index 82713b83815..5302b809ee6 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -393,8 +393,6 @@ int sun4i_usb_phy_vbus_detect(struct phy *phy) struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; int err, retries = 3; - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); - if (usb_phy->gpio_vbus_det < 0) return usb_phy->gpio_vbus_det; @@ -417,8 +415,6 @@ int sun4i_usb_phy_id_detect(struct phy *phy) struct sun4i_usb_phy_data *data = dev_get_priv(phy->dev); struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); - if (usb_phy->gpio_id_det < 0) return usb_phy->gpio_id_det;
Both of these messages log the GPIO number of the ID detection GPIO, which is not terribly useful, especially in the VBUS detection function. Signed-off-by: Samuel Holland <samuel@sholland.org> --- drivers/phy/allwinner/phy-sun4i-usb.c | 4 ---- 1 file changed, 4 deletions(-)