| Message ID | 20210802133754.2379453-1-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | e679f39f7fc3eb083b2f957d748f81bbdc28f28c |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | dtoc: Correct the intarray-widening test case | expand |
Hi Simon, On 8/2/21 10:37 AM, Simon Glass wrote: > This case was intended to check that widening an int array with an int > does nothing. Fix it. > > Reported-by: Walter Lozano <walter.lozano@collabora.com> > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > tools/dtoc/test_fdt.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/dtoc/test_fdt.py b/tools/dtoc/test_fdt.py > index 1119e6b7847..d104f3c7745 100755 > --- a/tools/dtoc/test_fdt.py > +++ b/tools/dtoc/test_fdt.py > @@ -425,7 +425,7 @@ class TestProp(unittest.TestCase): > > # Widen an array of ints with an int (should do nothing) > prop = self.node.props['intarray'] > - prop2 = node2.props['intarray'] > + prop2 = node2.props['intval'] > self.assertEqual(Type.INT, prop.type) > self.assertEqual(3, len(prop.value)) > prop.Widen(prop2) Thanks for the fix! Reviewed-by: Walter Lozano <walter.lozano@collabora.com> Regards, Walter
Hi Simon, On 8/2/21 10:37 AM, Simon Glass wrote: > This case was intended to check that widening an int array with an int > does nothing. Fix it. > > Reported-by: Walter Lozano <walter.lozano@collabora.com> > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > tools/dtoc/test_fdt.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks!
diff --git a/tools/dtoc/test_fdt.py b/tools/dtoc/test_fdt.py index 1119e6b7847..d104f3c7745 100755 --- a/tools/dtoc/test_fdt.py +++ b/tools/dtoc/test_fdt.py @@ -425,7 +425,7 @@ class TestProp(unittest.TestCase): # Widen an array of ints with an int (should do nothing) prop = self.node.props['intarray'] - prop2 = node2.props['intarray'] + prop2 = node2.props['intval'] self.assertEqual(Type.INT, prop.type) self.assertEqual(3, len(prop.value)) prop.Widen(prop2)
This case was intended to check that widening an int array with an int does nothing. Fix it. Reported-by: Walter Lozano <walter.lozano@collabora.com> Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/dtoc/test_fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)