diff mbox series

x86: crownbay: Adjust VGA rom address

Message ID 20210727133002.217059-1-bmeng.cn@gmail.com
State Accepted
Commit e7a61c5cc0d13e66f18765b7c428ce4f6d60cf9a
Delegated to: Bin Meng
Headers show
Series x86: crownbay: Adjust VGA rom address | expand

Commit Message

Bin Meng July 27, 2021, 1:30 p.m. UTC
binman complains when binary blobs are present:

  Node '/binman/rom/intel-vga': Offset 0xfff90000 (4294508544) overlaps
  with previous entry '/binman/rom/u-boot-dtb-with-ucode' ending at
  0xfff9204c (4294516812)

Adjust VGA rom address to 0xfffa0000 so that u-boot.rom image can be
successfully built again.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 configs/crownbay_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass July 31, 2021, 1:35 a.m. UTC | #1
On Tue, 27 Jul 2021 at 07:30, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> binman complains when binary blobs are present:
>
>   Node '/binman/rom/intel-vga': Offset 0xfff90000 (4294508544) overlaps
>   with previous entry '/binman/rom/u-boot-dtb-with-ucode' ending at
>   0xfff9204c (4294516812)
>
> Adjust VGA rom address to 0xfffa0000 so that u-boot.rom image can be
> successfully built again.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  configs/crownbay_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng July 31, 2021, 1:58 a.m. UTC | #2
On Sat, Jul 31, 2021 at 9:35 AM Simon Glass <sjg@chromium.org> wrote:
>
> On Tue, 27 Jul 2021 at 07:30, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > binman complains when binary blobs are present:
> >
> >   Node '/binman/rom/intel-vga': Offset 0xfff90000 (4294508544) overlaps
> >   with previous entry '/binman/rom/u-boot-dtb-with-ucode' ending at
> >   0xfff9204c (4294516812)
> >
> > Adjust VGA rom address to 0xfffa0000 so that u-boot.rom image can be
> > successfully built again.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  configs/crownbay_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index 0258f31089..af8fb0d805 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -10,6 +10,7 @@  CONFIG_VENDOR_INTEL=y
 CONFIG_TARGET_CROWNBAY=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
+CONFIG_VGA_BIOS_ADDR=0xfffa0000
 CONFIG_GENERATE_PIRQ_TABLE=y
 CONFIG_GENERATE_MP_TABLE=y
 CONFIG_FIT=y