Message ID | 20210727123642.2474-3-ashok.reddy.soma@xilinx.com |
---|---|
State | Superseded |
Delegated to: | Michal Simek |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-xilinx-onmicrosoft-com header.b=a959n++a; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GYxBX4C3dz9s5R for <incoming@patchwork.ozlabs.org>; Tue, 27 Jul 2021 22:37:08 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20E2E8347F; Tue, 27 Jul 2021 14:37:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="a959n++a"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 17E968347A; Tue, 27 Jul 2021 14:36:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::60e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 23A1982EB1 for <u-boot@lists.denx.de>; Tue, 27 Jul 2021 14:36:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ashokred@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhDSDAyiHJvRo++4dXNYEsIaoBe9M+hXiXFp/NLJZfi8IL7GK9Nt7Xjb0eUMxyjKK7lg1+yCk7xsY16EmGM6xRAWLsJcEnZhoR6YiZe84anV002LzVsHjJAwSugWgl9YSvSIwwrDq0haDNoQA9ROHWKY5EvdCnZOhhM6BfRFOIcxVwjRBLJRrkvkRx8dsMif+nVerNCtw0l+aVM/RTd1lwnaldHbQmjVnzssJBeayZSM7rYsx43NU+Zi234qP+54UicfOLdHf2Q/i5b3+1GVKbnabRDpTrvM1og58ovzTMPrlOoO166d/U0dXTiv6kea0Qafv6ZfakAu6tRtOb/Qtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vuEg/PS0CzD8e34cjNS67m56qMbevqJKuW4bNIX8hEQ=; b=hYxpXyd/WRKZVxTe/G1v3Dz1wLPhTrtdwwssTNYNd7oeoorSp4AbRgHmR+ZcZMApBaD77nZ7KOML6Z16f0monP9ou7DOBazjHmydJDYD5HKrRVg+NoeLNdYe3RjCI4sQYOXodzpab+YjAnXrPV3XQmIR0qLZW9LCgHbPM2IgCZfTFvsOI81S57T5lOW0uFBwImZvctmi2CIlkGMqBe+PHPhMjZTSOkKRxXiu5AXwJrKGNHpANWg4waZTB9uzvVaVcbzAGnWIQBi/I3tdT24/U9fTIuxQPYNWgXqRSi24gEhu/gYu8Yhqin45bgbnTab7kvh+GZIQpz6GNuJrZ2Yzvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=chromium.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vuEg/PS0CzD8e34cjNS67m56qMbevqJKuW4bNIX8hEQ=; b=a959n++aomduuJkBGP33lDwj3AWJO0QDLT6Jb5oM/PNbn+XU0XaWrsb+WSG6F8oxloC3pwsfRBs5rbfA8ejpMBM20a1vVUB1LSvV2hUT9icNdwxkb2RVJcQV94fzbrZH4Fi3JkqLlDo3954OhGaOk7ivWNUWDKBwu4UL2h+1Ss8= Received: from DM6PR05CA0050.namprd05.prod.outlook.com (2603:10b6:5:335::19) by BL0PR02MB4356.namprd02.prod.outlook.com (2603:10b6:208:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Tue, 27 Jul 2021 12:36:48 +0000 Received: from DM3NAM02FT029.eop-nam02.prod.protection.outlook.com (2603:10b6:5:335:cafe::2f) by DM6PR05CA0050.outlook.office365.com (2603:10b6:5:335::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.7 via Frontend Transport; Tue, 27 Jul 2021 12:36:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT029.mail.protection.outlook.com (10.13.4.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4352.24 via Frontend Transport; Tue, 27 Jul 2021 12:36:48 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Jul 2021 05:36:46 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 27 Jul 2021 05:36:46 -0700 Envelope-to: git@xilinx.com, sjg@chromium.org, somaashokreddy@gmail.com, u-boot@lists.denx.de, monstr@monstr.eu, peng.fan@nxp.com, jh80.chung@samsung.com, faiz_abbas@ti.com, michael@walle.cc Received: from [10.140.6.65] (port=38278 helo=xhdashokred41.localdomain) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from <ashok.reddy.soma@xilinx.com>) id 1m8MKD-000CNd-Ls; Tue, 27 Jul 2021 05:36:45 -0700 Received: by xhdashokred41.localdomain (Postfix, from userid 2896) id DAF7D10254C; Tue, 27 Jul 2021 06:36:44 -0600 (MDT) From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> To: <u-boot@lists.denx.de> CC: <peng.fan@nxp.com>, <jh80.chung@samsung.com>, <faiz_abbas@ti.com>, <sjg@chromium.org>, <michael@walle.cc>, <git@xilinx.com>, <monstr@monstr.eu>, <somaashokreddy@gmail.com>, Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> Subject: [PATCH v2 2/8] mmc: sdhci: Change prototype of set_delay to return errors Date: Tue, 27 Jul 2021 06:36:36 -0600 Message-ID: <20210727123642.2474-3-ashok.reddy.soma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210727123642.2474-1-ashok.reddy.soma@xilinx.com> References: <20210727123642.2474-1-ashok.reddy.soma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cb016eb-fea8-437d-e9dd-08d950fb33cb X-MS-TrafficTypeDiagnostic: BL0PR02MB4356: X-Microsoft-Antispam-PRVS: <BL0PR02MB4356B6616294B50A7A5629CDBAE99@BL0PR02MB4356.namprd02.prod.outlook.com> X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7qLF1bJnRDpcy3LL6qP22su4EC+rkIs7UWvJ9OSWG0IWHticVOQ1xPHj8K5tZPna38b25Iw6PTT5GRDXkqVzmsBpSjnmVnvBAlvuAJ2ZJRq3YEYOLjw5VPbxAqYckeFmRRrNbtmfB9cK4RNv1yE9jAeOgCkhgmzZhAkWEkoa5+Xf16KazidPoB9ACuEIVirzBnMK6xcvogZGoVdtijwfVHMvwssmTPJ7vQU37pUp0GI1Bnvzepwt3DP+PE6Xhp44FtQE/GCI17QeBmqL+5r9pJXM/wQ+v2O6evRIxJCjglD5WiyOhELFlU8mo6ZnoI6NbFx2l3tlN4RBDQpIkhBK5XYisx36n4BwxnI+lRF+VnzvfFrAEgGL1GJOxcVW2D9y2SgToQ6/2ozJsKaFyk5vce09lUotSqeYVDLHEfYVL/yaYyuu23oSG38AtjD4tKNusNhwMrdsFhM91X2jJ6Wurrb1RsaTJfmQR7L5sMBSTPp1NVJ3jf7NKKXKiv0J7KsaewZOXWbT37JesIHArghMVHGfISzPs8jPsEMeHd4YRdUZj0iIq9L2DzRwrBtDw/0vI2X46NG5RO+hlOc0HRZL8Pt9HxhOJFCx1bNs/bIFRF4zA8rESbxYxlbWbEirpjh6WinnoZMlmrTxVnNK2oKsXhkvjVc+dk2PRrENI6NHdT5BrHOnyJFUM4f3pphn89vyOR2HMaRTrJQlp791ddb5KA== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(46966006)(36840700001)(316002)(6266002)(47076005)(70206006)(70586007)(2616005)(5660300002)(54906003)(83380400001)(103116003)(26005)(2906002)(8936002)(1076003)(36906005)(336012)(186003)(4326008)(6666004)(42186006)(82310400003)(6916009)(7636003)(36756003)(36860700001)(8676002)(478600001)(82740400003)(356005)(107886003); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 12:36:48.4731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb016eb-fea8-437d-e9dd-08d950fb33cb X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4356 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean |
Series |
Arasan sdhci driver updates
|
expand
|
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index d9ab6a0a83..a99014236a 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -366,6 +366,7 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) { struct sdhci_host *host = mmc->priv; unsigned int div, clk = 0, timeout; + int ret; /* Wait max 20 ms */ timeout = 200; @@ -386,8 +387,13 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) if (clock == 0) return 0; - if (host->ops && host->ops->set_delay) - host->ops->set_delay(host); + if (host->ops && host->ops->set_delay) { + ret = host->ops->set_delay(host); + if (ret) { + printf("%s: Error while setting tap delay\n", __func__); + return ret; + } + } if (SDHCI_GET_VERSION(host) >= SDHCI_SPEC_300) { /* diff --git a/include/sdhci.h b/include/sdhci.h index 0ae9471ad7..44a0d84e5a 100644 --- a/include/sdhci.h +++ b/include/sdhci.h @@ -268,7 +268,7 @@ struct sdhci_ops { int (*set_ios_post)(struct sdhci_host *host); void (*set_clock)(struct sdhci_host *host, u32 div); int (*platform_execute_tuning)(struct mmc *host, u8 opcode); - void (*set_delay)(struct sdhci_host *host); + int (*set_delay)(struct sdhci_host *host); int (*deferred_probe)(struct sdhci_host *host); };
set_delay() has return type as void. If there are any errors while setting tapdelay's it won't be able to return them. Change the prototype of set_delay() in sdhci_ops structure and return the errors from wherever it is called. Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> --- Changes in v2: - This is the second patch that has been split from 1/7 - This covers changes for sdhci driver separately - Added a debug print in case of error from set_delay() drivers/mmc/sdhci.c | 10 ++++++++-- include/sdhci.h | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-)