| Message ID | 20210725142558.336738-1-johan.gunnarsson@gmail.com |
|---|---|
| State | Accepted |
| Commit | 475bb949ed191bc00e08781a56a4a1e83fd76242 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: Fix u-boot-rockchip.bin build | expand |
On Sun, 25 Jul 2021 at 08:26, Johan Gunnarsson <johan.gunnarsson@gmail.com> wrote: > > Currently there are a few arm32 rockchip board configs that don't > generate u-boot-rockchip.bin when running make because CONFIG_BINMAN > is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select > CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64. > > Example builds that don't generate u-boot-rockchip.bin without this > patch: > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make kylin-rk3036_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make rock_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make tinker-rk3288_defconfig > make > > Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com> > --- > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
Johan Gunnarsson <johan.gunnarsson@gmail.com> 于2021年7月26日周一 上午7:32写道： > > Currently there are a few arm32 rockchip board configs that don't > generate u-boot-rockchip.bin when running make because CONFIG_BINMAN > is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select > CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64. > > Example builds that don't generate u-boot-rockchip.bin without this > patch: > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make kylin-rk3036_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make rock_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make tinker-rk3288_defconfig > make > > Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 9de97cc101..5a8672cdd6 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1791,7 +1791,7 @@ config ARCH_STM32MP > config ARCH_ROCKCHIP > bool "Support Rockchip SoCs" > select BLK > - select BINMAN if SPL_OPTEE > + select BINMAN if SPL_OPTEE || (SPL && !ARM64) > select DM > select DM_GPIO > select DM_I2C > -- > 2.25.1 >
On 2021/7/25 下午10:25, Johan Gunnarsson wrote: > Currently there are a few arm32 rockchip board configs that don't > generate u-boot-rockchip.bin when running make because CONFIG_BINMAN > is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select > CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64. > > Example builds that don't generate u-boot-rockchip.bin without this > patch: > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make kylin-rk3036_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make rock_defconfig > make > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- > make tinker-rk3288_defconfig > make > > Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 9de97cc101..5a8672cdd6 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1791,7 +1791,7 @@ config ARCH_STM32MP > config ARCH_ROCKCHIP > bool "Support Rockchip SoCs" > select BLK > - select BINMAN if SPL_OPTEE > + select BINMAN if SPL_OPTEE || (SPL && !ARM64) > select DM > select DM_GPIO > select DM_I2C
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 9de97cc101..5a8672cdd6 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1791,7 +1791,7 @@ config ARCH_STM32MP config ARCH_ROCKCHIP bool "Support Rockchip SoCs" select BLK - select BINMAN if SPL_OPTEE + select BINMAN if SPL_OPTEE || (SPL && !ARM64) select DM select DM_GPIO select DM_I2C
Currently there are a few arm32 rockchip board configs that don't generate u-boot-rockchip.bin when running make because CONFIG_BINMAN is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64. Example builds that don't generate u-boot-rockchip.bin without this patch: export ARCH=arm export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- make kylin-rk3036_defconfig make export ARCH=arm export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- make rock_defconfig make export ARCH=arm export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf- make tinker-rk3288_defconfig make Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com> --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)