| Message ID | 20210622033421.29625-1-wesley.sheng@amd.com |
|---|---|
| State | Accepted |
| Commit | 859b33c948945f7904f60a2c12a3792d356d51ad |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | nvme: Correct the prps per page calculation method | expand |
On Tue, Jun 22, 2021 at 11:34 AM Wesley Sheng <wesley.sheng@amd.com> wrote: > > From: Wesley Sheng <wesleyshenggit@sina.com> > > Each prp is 8 bytes, calculate the number of prps > per page should just divide page size by 8 > there is no need to minus 1 > > Signed-off-by: Wesley Sheng <wesleyshenggit@sina.com> > --- > drivers/nvme/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Wed, Jun 23, 2021 at 4:53 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Tue, Jun 22, 2021 at 11:34 AM Wesley Sheng <wesley.sheng@amd.com> wrote: > > > > From: Wesley Sheng <wesleyshenggit@sina.com> > > > > Each prp is 8 bytes, calculate the number of prps > > per page should just divide page size by 8 > > there is no need to minus 1 > > > > Signed-off-by: Wesley Sheng <wesleyshenggit@sina.com> > > --- > > drivers/nvme/nvme.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..622bb378c0 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -79,7 +79,7 @@ static int nvme_setup_prps(struct nvme_dev *dev, u64 *prp2, u64 *prp_pool; int length = total_len; int i, nprps; - u32 prps_per_page = (page_size >> 3) - 1; + u32 prps_per_page = page_size >> 3; u32 num_pages; length -= (page_size - offset);