diff mbox series

[07/11] imx: ventana: put LTC3676 regulators in continuous mode

Message ID 20210611194628.5572-7-tharvey@gateworks.com
State Accepted
Commit 0545b17b695e03ad5ea7bd9736b9cdfc49530af5
Delegated to: Stefano Babic
Headers show
Series [01/11] imx: ventana: remove USB_KEYBOARD support | expand

Commit Message

Tim Harvey June 11, 2021, 7:46 p.m. UTC
In the default pulse-skipping mode regulators that are very lightly
loaded can fail to regulate properly. Switching them to always use
continuous mode causes only around 10mW of overall system power
difference in a lightly loaded system that isn't already operating
them in continuous mode.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 board/gateworks/gw_ventana/common.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stefano Babic July 10, 2021, 3:54 p.m. UTC | #1
> In the default pulse-skipping mode regulators that are very lightly
> loaded can fail to regulate properly. Switching them to always use
> continuous mode causes only around 10mW of overall system power
> difference in a lightly loaded system that isn't already operating
> them in continuous mode.
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
Stefano Babic July 10, 2021, 7:37 p.m. UTC | #2
> In the default pulse-skipping mode regulators that are very lightly
> loaded can fail to regulate properly. Switching them to always use
> continuous mode causes only around 10mW of overall system power
> difference in a lightly loaded system that isn't already operating
> them in continuous mode.
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
index b5a0162c5e..adbc6791b3 100644
--- a/board/gateworks/gw_ventana/common.c
+++ b/board/gateworks/gw_ventana/common.c
@@ -1688,6 +1688,12 @@  void setup_pmic(void)
 			/* set SW3 (VDD_ARM) */
 			pmic_reg_write(p, LTC3676_DVB3A, 0x1f);
 		}
+
+		/* put all switchers in continuous mode */
+		pmic_reg_write(p, LTC3676_BUCK1, 0xc0);
+		pmic_reg_write(p, LTC3676_BUCK2, 0xc0);
+		pmic_reg_write(p, LTC3676_BUCK3, 0xc0);
+		pmic_reg_write(p, LTC3676_BUCK4, 0xc0);
 	}
 }