| Message ID | 20210611151049.13475-3-zhengxunli.mxic@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | Add Xilinx clock wizard driver support | expand |
On 6/11/21 11:10 AM, Zhengxun wrote: > Add the devicetree binding for the xilinx clocking wizard. > > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> > --- > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt Should this be .yml? In general, I believe we only need to document bindings in U-Boot if they differ from Linux. In Linux, I see that Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. Will you be upstreaming this conversion to yaml? --Sean > > diff --git a/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt > new file mode 100644 > index 0000000000..e0e73ec723 > --- /dev/null > +++ b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt > @@ -0,0 +1,43 @@ > +Xilinx clocking wizard bindings > + > +description: > + The clocking wizard is a soft ip clocking block of Xilinx versal. It > + reads required input clock frequencies from the devicetree and acts as > + clock output. > + > +properties: > + compatible: > + const: xlnx,clocking-wizard > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > + clocks: > + items: > + - description: clock input > + > + clock-names: > + items: > + - const: clk_in1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + clkwizard@43c20000 { > + compatible = "xlnx,clocking-wizard"; > + reg = <0x43c20000 0x10000>; > + #clock-cells = <1>; > + clock-names = "clk_in1"; > + clocks = <&clkc 18>; > + }; >
On 6/15/21 1:21 PM, Zhengxun Li wrote: > Hi Michal, > > Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道： >> >> >> >> On 6/11/21 11:10 AM, Zhengxun wrote: >> > Add the devicetree binding for the xilinx clocking wizard. >> > >> > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> >> > --- >> > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ >> > 1 file changed, 43 insertions(+) >> > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt >> >> Should this be .yml? In general, I believe we only need to document >> bindings in U-Boot if they differ from Linux. In Linux, I see that >> Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. Because the binding is documented in Linux, we do not need to document it in U-Boot. >> Will you be upstreaming this conversion to yaml? This patch documents the binding in yaml. However, the version in Linux is in old-style txt. Will you be sending a patch to Linux to convert this binding to yaml? --Sean > > Can you give some suggestions? > > Thanks, > Zhengxun >
Hi Michal, Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道： > > > > On 6/11/21 11:10 AM, Zhengxun wrote: > > Add the devicetree binding for the xilinx clocking wizard. > > > > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> > > --- > > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt > > Should this be .yml? In general, I believe we only need to document > bindings in U-Boot if they differ from Linux. In Linux, I see that > Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. > Will you be upstreaming this conversion to yaml? Can you give some suggestions? Thanks, Zhengxun
Hi, On 6/16/21 5:26 PM, Zhengxun Li wrote: > Hi Sean, > > Thank you for your reply. > > Sean Anderson <sean.anderson@seco.com> 於 2021年6月15日 週二 下午2:52寫道： >> >> >> >> On 6/15/21 1:21 PM, Zhengxun Li wrote: >> > Hi Michal, >> > >> > Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道： >> >> >> >> >> >> >> >> On 6/11/21 11:10 AM, Zhengxun wrote: >> >> > Add the devicetree binding for the xilinx clocking wizard. >> >> > >> >> > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> >> >> > --- >> >> > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ >> >> > 1 file changed, 43 insertions(+) >> >> > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt >> >> >> >> Should this be .yml? In general, I believe we only need to document >> >> bindings in U-Boot if they differ from Linux. In Linux, I see that >> >> Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. >> >> Because the binding is documented in Linux, we do not need to document >> it in U-Boot. >> >> >> Will you be upstreaming this conversion to yaml? >> >> This patch documents the binding in yaml. However, the version in Linux >> is in old-style txt. Will you be sending a patch to Linux to convert >> this binding to yaml? > > In linux, I saw Shubhrajyoti Datta do this, although it has not been > accepted yet. The link is below. > > https://patchwork.kernel.org/project/linux-clk/patch/1617886723-27117-2-git-send-email-shubhrajyoti.datta@xilinx.com/ > > Should I do this again? I prefer not to do it. Linux binding will be reviewed by Rob and that should be enough. Thanks, Michal
Hi Sean, Thank you for your reply. Sean Anderson <sean.anderson@seco.com> 於 2021年6月15日 週二 下午2:52寫道： > > > > On 6/15/21 1:21 PM, Zhengxun Li wrote: > > Hi Michal, > > > > Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道： > >> > >> > >> > >> On 6/11/21 11:10 AM, Zhengxun wrote: > >> > Add the devicetree binding for the xilinx clocking wizard. > >> > > >> > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> > >> > --- > >> > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ > >> > 1 file changed, 43 insertions(+) > >> > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt > >> > >> Should this be .yml? In general, I believe we only need to document > >> bindings in U-Boot if they differ from Linux. In Linux, I see that > >> Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. > > Because the binding is documented in Linux, we do not need to document > it in U-Boot. > > >> Will you be upstreaming this conversion to yaml? > > This patch documents the binding in yaml. However, the version in Linux > is in old-style txt. Will you be sending a patch to Linux to convert > this binding to yaml? In linux, I saw Shubhrajyoti Datta do this, although it has not been accepted yet. The link is below. https://patchwork.kernel.org/project/linux-clk/patch/1617886723-27117-2-git-send-email-shubhrajyoti.datta@xilinx.com/ Should I do this again? Thanks, Zhengxun
Hi, Michal Simek <michal.simek@xilinx.com> 於 2021年6月16日 週三 上午10:05寫道： > > Hi, > > On 6/16/21 5:26 PM, Zhengxun Li wrote: > > Hi Sean, > > > > Thank you for your reply. > > > > Sean Anderson <sean.anderson@seco.com> 於 2021年6月15日 週二 下午2:52寫道： > >> > >> > >> > >> On 6/15/21 1:21 PM, Zhengxun Li wrote: > >> > Hi Michal, > >> > > >> > Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道： > >> >> > >> >> > >> >> > >> >> On 6/11/21 11:10 AM, Zhengxun wrote: > >> >> > Add the devicetree binding for the xilinx clocking wizard. > >> >> > > >> >> > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> > >> >> > --- > >> >> > .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ > >> >> > 1 file changed, 43 insertions(+) > >> >> > create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt > >> >> > >> >> Should this be .yml? In general, I believe we only need to document > >> >> bindings in U-Boot if they differ from Linux. In Linux, I see that > >> >> Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists. > >> > >> Because the binding is documented in Linux, we do not need to document > >> it in U-Boot. > >> > >> >> Will you be upstreaming this conversion to yaml? > >> > >> This patch documents the binding in yaml. However, the version in Linux > >> is in old-style txt. Will you be sending a patch to Linux to convert > >> this binding to yaml? > > > > In linux, I saw Shubhrajyoti Datta do this, although it has not been > > accepted yet. The link is below. > > > > https://patchwork.kernel.org/project/linux-clk/patch/1617886723-27117-2-git-send-email-shubhrajyoti.datta@xilinx.com/ > > > > Should I do this again? > > I prefer not to do it. Linux binding will be reviewed by Rob and that > should be enough. Thank you for your reply. Thanks, Zhengxun
diff --git a/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt new file mode 100644 index 0000000000..e0e73ec723 --- /dev/null +++ b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt @@ -0,0 +1,43 @@ +Xilinx clocking wizard bindings + +description: + The clocking wizard is a soft ip clocking block of Xilinx versal. It + reads required input clock frequencies from the devicetree and acts as + clock output. + +properties: + compatible: + const: xlnx,clocking-wizard + + reg: + maxItems: 1 + + "#clock-cells": + const: 1 + + clocks: + items: + - description: clock input + + clock-names: + items: + - const: clk_in1 + +required: + - compatible + - reg + - "#clock-cells" + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + clkwizard@43c20000 { + compatible = "xlnx,clocking-wizard"; + reg = <0x43c20000 0x10000>; + #clock-cells = <1>; + clock-names = "clk_in1"; + clocks = <&clkc 18>; + };
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com> --- .../clock/xlnx,clocking-wizard.txt | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt