From patchwork Mon May 31 15:21:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Z.Q. Hou" X-Patchwork-Id: 1485718 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=pYj0KMRl; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FtzL014kLz9sVb for ; Tue, 1 Jun 2021 01:12:21 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D8A0E82E7B; Mon, 31 May 2021 17:12:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="pYj0KMRl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3971182D61; Mon, 31 May 2021 17:12:13 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on061f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::61f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AFBE082D61 for ; Mon, 31 May 2021 17:12:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=zhiqiang.hou@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R/4b3N+H5cnNOPYkVek8Zq1snrRnIfklbMuIvTBOleird69FbUobxA1RK1l1i9PUm3TOLqY1AyUAM4cqZXIvgzpm2ok62MpB+1+dkvQ+CTAtoVR6UE78Zffu0pIHuKVqAU/TP0i7aa5U27tkv7srf5q95ui2uOxU9QzSq5RXh4wBiokNdSuWiXK2lhfkXkJ2jmO5zf/XAcolDNAaOSFIYbNKih/gOgBW+ekNuBFxB7dQFQLRE5rC6rZpWOVWpRaoiQ+JB0hPgwSHGwSoPJGNpwL0JwQvmBLwx1OfzO6C9lpa7GUFssRAQLbIHFzG4+SAd4xulq7u35Tbz+nODwbjtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gH4VtG7/4YQbhe1caY5TMfBDZlM+Hsgy6Z103Ot48TU=; b=HY7p7QSlS3C0yzGJWCYWDQE58w+S+XVdf7cTVMAwnK8Ch4wUqT4IQ3KdlPACYwFGrw+BbAT5rUMu3uj/r2vU879PFnyHSysC+zvMu6jdngjxcE8uA2SeHuhCzNRlIXEdYSyx+nE/A984dM9XvnR+nauUxU01oyNo0imNklmc0RpHH3iUMRrWprDyhmHrrUNF9Lyt6jyxa24wei1rwfl3c25ZrQd56r9gzXzNuEaYS7LYUX9eLg09xNIoNd4Ot0TGJoQ65/+MaaAwn1x1OLPUewKgqavcrzxtj0LaDIQnk/KOZ+iTi0b4X3jy8YYuY3u8/SHaU5NL7t4FZ+4PHyMIfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gH4VtG7/4YQbhe1caY5TMfBDZlM+Hsgy6Z103Ot48TU=; b=pYj0KMRlbkp8q6LkGP8nfsskgF+xOXfGnNe283SStMYZZWts6ZCseTbb2VlE/BiPHQt1nmHRMORcPZkyovNB3y9DwiMf7BNINhJxl45GKKQ2eEgghfqv+hlTVj+AWihimjFuCyFiXN4CBN1EYE1HS/n4fHFNCPxVDB4xkmzrO+E= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) by HE1PR0401MB2459.eurprd04.prod.outlook.com (2603:10a6:3:82::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.29; Mon, 31 May 2021 15:12:09 +0000 Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::3c4c:2dd2:3b01:34b0]) by HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::3c4c:2dd2:3b01:34b0%7]) with mapi id 15.20.4173.029; Mon, 31 May 2021 15:12:09 +0000 From: Zhiqiang Hou To: joe.hershberger@ni.com, rfried.dev@gmail.com, u-boot@lists.denx.de Cc: Hou Zhiqiang Subject: [PATCH] net: e1000: Fix Unchecked return value coverity Date: Mon, 31 May 2021 23:21:32 +0800 Message-Id: <20210531152132.25663-1-Zhiqiang.Hou@nxp.com> X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.73] X-ClientProxiedBy: SG2P153CA0007.APCP153.PROD.OUTLOOK.COM (2603:1096::17) To HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.73) by SG2P153CA0007.APCP153.PROD.OUTLOOK.COM (2603:1096::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.3 via Frontend Transport; Mon, 31 May 2021 15:12:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1b4c02d-0f6b-4678-a7da-08d9244675ca X-MS-TrafficTypeDiagnostic: HE1PR0401MB2459: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jELck26b+gUXQQojqeG+pWWUBvWbyiaotbPHBA27GBIhlio18J3MKMTa9WQ/4ieEcTQ/FyPHcAUDLbM59vFMKBca25wc1TJqzTEVSFDRPEh8/487U4A6fUpnw/sALRW5E0rblFUoTNyg3OMFuAgQcxwtHGNyYfwvitn4KmrXlOQLbjEWBPWrq+/SQzvH1R5SPtFMjES3qJwRaukL26x/j5xzL+9AAtVfyfL8pEhGNqxYjWqmp+4G7BV6j5/9p8zjNHCWoYLit6LmwjG+i0x7+UTxC6HUq8awXrdzCJA8+RGhkuqyMIeAcoAQmdOCf0JjQw92gAK2LqZUmJo6zq8cxbzHyU07J5IeXD95jP7DezH03PYZ3O8GKzY+M1LbxILfM+lrR9VT9jadwy2f/HxUE/DZWy1fCkMmVhT5QQE4EYnjSu6Cx/DRhdkuNS97NM9TcFP669wiZpHdgHRnP53/UZzUL55hNzbWr2hyst7jQdHP0fM3cN48lioNoL6ZcMvHi3jJeLBoZ1IwkI78yc2WPeehwaiKylzVFDmiG0D1d5w2fNSz5YWKr77LywXIsSqYSqaILjgf19/YzZfPi8ywMsPUD4A89/e9nwOHQ/GqcVSBrIrlURoihLhUl3ltH1EOz6ve8MduF1XbtYE5t1kNANbjd4fAsMsS2UZ5inwJXcyGT5pahevXaq64jjRIxhdd X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0402MB3371.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(396003)(346002)(366004)(376002)(4744005)(6666004)(38100700002)(86362001)(66556008)(66476007)(83380400001)(66946007)(6486002)(8676002)(6512007)(36756003)(478600001)(2616005)(8936002)(1076003)(38350700002)(4326008)(6506007)(16526019)(186003)(316002)(2906002)(5660300002)(26005)(52116002)(956004)(69590400013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: bSmVyImcfk8ZsnY8Ud7Y/X+LpkyYp2CAss5A5vOV5cK5VZKxmcqFQusokw7OV9gvMl/FAn79yKsba6/2sk2FfU8np7RUyVLzkJT5LkOVd8c9DWU8auSSaDvavN71RFJZKr7Q2RLSGBAp6NebE2oX3G+LFBbpbY0Kl+P4T0cfHWR66iWSFr1Uxp9BmnWALuSL7kFMhdkrAVyionwsp+a3kvwwGjy747R2b3MWh+uPjJ4spsYnoCU7UnoWwdr1je6Knqroa0urDLNA5jYBUl//hB9QNeoSQIgS+pIK5GkZQtVX7ZHATRDpiXRjjHCWV4sUL7qdWUaRK91q+d7srlPp35eyPdSIAho9/rUPvg609BVS8E1Fcl7P3ZJlnNwodE2bAglkAm8FEp+O7mGbzo1M65VcQKq6NqAAoZId7YfDcnokFuquXhfVQ4IEs5Bor/vIY+ReMYsF4NvESLAvpYG/z61CfegTTKRXexyk1WDfiI/hIGkcNr0knrPtqCoJLwtAiyEqtlEHgNJ+5C3jbYEFmCfCEuboKrMQsyamYKjZDXZLOG7GiusQwyZybINSbhJpvGzTxB1uNWAoUoGxiheLMBXTqCI4IQtCBdu3soUNAz2BYCngnEKxPDQ8XvAc+IpJGKxbi8iS+9Go7Cp/a1QArMku3f9UkcBcj8bmzrwykqrdaIpF6tREApnuKKlT2xrNKT5vzk2GuTpKX1adNxpPj3ReXSiC6sSKdiMR4Lzl8yU2cF0ybka5C9/ccM1CH1vVrr7A2EL9gy5FGcW887o4lkKGMzChTg/JGgOeVRekWZU7nYcCZ9cDhh2d0KydLSGPScgJEQprb6EE5eo5AeqyX8ivVdpAAAN502CwztJwR4uwEsZLK9kLZXLpOma4qcJY1fkAx0rZhTXptbwN0TiWA8fyqNEn1B242IySsXHAOAhxlg2yNM9bcU+aXiAylojVlK6hH+JjSioslzFGZOuIk6bHMXJpy679QKoIfwzlHYo2ZG6jbbTwIkoeuATxsKP9U8jBcBdsI8cL7OEltYfF6OHV6CF4tURst6kB+1dBQNdpymWkHm4++ic4dms1Xxsduqul7AIk/erHMkPb6+wFM1fBoyWhnpinGawyMwq8hPI4fwwt+e5Xu0dWRJemmzk1P34WBobs6s/w6Jswj8pyn0oGEQsrbK50BK1XmEoS5UxbHdY6YhZL9iVhu0lTJuypqKNlwduKZVR2aP5BrJAwBT2Cb9QDTc7q9+0jQD+3/BjG9QR6HbExs51n92XKjWDfESlG6UCQQkAjvwUMHmA66G6Laf8ezOPJbhM0sBvLu94P63h3OdPrnQIDJYp0wZV4 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1b4c02d-0f6b-4678-a7da-08d9244675ca X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3371.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2021 15:12:09.5450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1qRKfTRe/OGzPMwTgylGNPr47MP5++mbT9bVLyEzlUmoUevucJCsgWlmTXYAt+oUa70HprhEMf4rZYhpRMolDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2459 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean From: Hou Zhiqiang Added check for return value of e1000_read_phy_reg(). Signed-off-by: Hou Zhiqiang --- drivers/net/e1000.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 694114eca7..1f0d559415 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -4738,12 +4738,16 @@ e1000_phy_init_script(struct e1000_hw *hw) uint16_t fused, fine, coarse; /* Move to analog registers page */ - e1000_read_phy_reg(hw, - IGP01E1000_ANALOG_SPARE_FUSE_STATUS, &fused); + if (e1000_read_phy_reg(hw, + IGP01E1000_ANALOG_SPARE_FUSE_STATUS, + &fused)) + return; if (!(fused & IGP01E1000_ANALOG_SPARE_FUSE_ENABLED)) { - e1000_read_phy_reg(hw, - IGP01E1000_ANALOG_FUSE_STATUS, &fused); + if (e1000_read_phy_reg(hw, + IGP01E1000_ANALOG_FUSE_STATUS, + &fused)) + return; fine = fused & IGP01E1000_ANALOG_FUSE_FINE_MASK; coarse = fused