diff mbox series

[PATCHv2,2/3] pci: pcie_dw_rockchip: Drop the unused variable warning

Message ID 20210521165949.15909-2-linux.amoon@gmail.com
State Changes Requested
Delegated to: Kever Yang
Headers show
Series [PATCHv2,1/3] pci: pcie_dw_rockchip: Fixed the below compilation error | expand

Commit Message

Anand Moon May 21, 2021, 4:59 p.m. UTC
Drop the unused variable warning below.

drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable
			'val' [-Wunused-variable]
  161 |  u32 val;
      |      ^~~

Cc: Patrick Wildt <patrick@blueri.se>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/pci/pcie_dw_rockchip.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Neil Armstrong May 31, 2021, 8:42 a.m. UTC | #1
On 21/05/2021 18:59, Anand Moon wrote:
> Drop the unused variable warning below.
> 
> drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable
> 			'val' [-Wunused-variable]
>   161 |  u32 val;
>       |      ^~~
> 
> Cc: Patrick Wildt <patrick@blueri.se>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  drivers/pci/pcie_dw_rockchip.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index 3ac2434b69..4e448c0a3d 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg,
>   */
>  static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed)
>  {
> -	u32 val;
> -
>  	dw_pcie_dbi_write_enable(&pci->dw, true);
>  
>  	clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
diff mbox series

Patch

diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
index 3ac2434b69..4e448c0a3d 100644
--- a/drivers/pci/pcie_dw_rockchip.c
+++ b/drivers/pci/pcie_dw_rockchip.c
@@ -158,8 +158,6 @@  static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg,
  */
 static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed)
 {
-	u32 val;
-
 	dw_pcie_dbi_write_enable(&pci->dw, true);
 
 	clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,