| Message ID | 20210517224030.408911-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | e2017ef6edcbab4d644579fb59429259d33b815a |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB | expand |
On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote: > > Uncompressed aarch64 kernel Image are rather large, increase the bootm > size limit to 64 MiB to cater for that. > > Signed-off-by: Marek Vasut <marex@denx.de> Marek, thanks for your fix! There is a typo in the comment message: "kernel Image are rather large" probably should be either "kernel Images are rather large" or "kernel Image is rather large". With that: Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Cc: Max Krummenacher <max.krummenacher@toradex.com> > Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> > --- > include/configs/verdin-imx8mm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h > index e2a817891c2..7be5e5ddf11 100644 > --- a/include/configs/verdin-imx8mm.h > +++ b/include/configs/verdin-imx8mm.h > @@ -16,6 +16,8 @@ > #define CONFIG_SYS_UBOOT_BASE \ > (QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512) > > +#define CONFIG_SYS_BOOTM_LEN SZ_64M > + > #ifdef CONFIG_SPL_BUILD > #define CONFIG_SPL_STACK 0x920000 > #define CONFIG_SPL_BSS_START_ADDR 0x910000 > -- > 2.30.2 >
On 5/18/21 9:37 AM, Oleksandr Suvorov wrote: > On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote: >> >> Uncompressed aarch64 kernel Image are rather large, increase the bootm >> size limit to 64 MiB to cater for that. >> >> Signed-off-by: Marek Vasut <marex@denx.de> > > Marek, thanks for your fix! > > There is a typo in the comment message: > "kernel Image are rather large" probably should be either "kernel > Images are rather large" or "kernel Image is rather large". The Image is the filename (aarch64 image) and it is plural, so I think its neither of the options.
On Tue, May 18, 2021 at 11:45 AM Marek Vasut <marex@denx.de> wrote: > > On 5/18/21 9:37 AM, Oleksandr Suvorov wrote: > > On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote: > >> > >> Uncompressed aarch64 kernel Image are rather large, increase the bootm > >> size limit to 64 MiB to cater for that. > >> > >> Signed-off-by: Marek Vasut <marex@denx.de> > > > > Marek, thanks for your fix! > > > > There is a typo in the comment message: > > "kernel Image are rather large" probably should be either "kernel > > Images are rather large" or "kernel Image is rather large". > > The Image is the filename (aarch64 image) and it is plural, so I think > its neither of the options. Oh, I didn't notice the capital letter "I" :) Sorry about that. Reviewed w/o conditions :)
> Uncompressed aarch64 kernel Image are rather large, increase the bootm > size limit to 64 MiB to cater for that. > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Cc: Max Krummenacher <max.krummenacher@toradex.com> > Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> > Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h index e2a817891c2..7be5e5ddf11 100644 --- a/include/configs/verdin-imx8mm.h +++ b/include/configs/verdin-imx8mm.h @@ -16,6 +16,8 @@ #define CONFIG_SYS_UBOOT_BASE \ (QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512) +#define CONFIG_SYS_BOOTM_LEN SZ_64M + #ifdef CONFIG_SPL_BUILD #define CONFIG_SPL_STACK 0x920000 #define CONFIG_SPL_BSS_START_ADDR 0x910000
Uncompressed aarch64 kernel Image are rather large, increase the bootm size limit to 64 MiB to cater for that. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com> Cc: Max Krummenacher <max.krummenacher@toradex.com> Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> --- include/configs/verdin-imx8mm.h | 2 ++ 1 file changed, 2 insertions(+)