diff mbox series

[v5,08/10] configs: CHIP: add support for DIP detect functionality

Message ID 20210504173130.22869-9-kory.maincent@bootlin.com
State Accepted
Commit 77115a5526f0893f55041e217a1ce36bb1e596b1
Delegated to: Tom Rini
Headers show
Series Add support for extension boards detection and DT overlays application | expand

Commit Message

Kory Maincent May 4, 2021, 5:31 p.m. UTC
This commit enables using the extension board detection mechanism on
CHIP boards

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
---
 configs/CHIP_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Andre Przywara May 13, 2021, 11:03 a.m. UTC | #1
On Tue,  4 May 2021 19:31:28 +0200
Kory Maincent <kory.maincent@bootlin.com> wrote:

> This commit enables using the extension board detection mechanism on
> CHIP boards
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> Acked-by: Maxime Ripard <maxime@cerno.tech>

Acked-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

P.S. Out of curiosity: what is the story for the CHIP Pro here? Does it
not work there or is it just not tested?

> ---
>  configs/CHIP_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig
> index a70ee31d40..8d40da090b 100644
> --- a/configs/CHIP_defconfig
> +++ b/configs/CHIP_defconfig
> @@ -1,6 +1,7 @@
>  CONFIG_ARM=y
>  CONFIG_ARCH_SUNXI=y
>  CONFIG_SPL=y
> +CONFIG_CHIP_DIP_SCAN=y
>  CONFIG_MACH_SUN5I=y
>  CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y
>  CONFIG_USB0_VBUS_PIN="PB10"
Tom Rini May 13, 2021, 7:06 p.m. UTC | #2
On Tue, May 04, 2021 at 07:31:28PM +0200, Kory Maincent wrote:

> This commit enables using the extension board detection mechanism on
> CHIP boards
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> Acked-by: Maxime Ripard <maxime@cerno.tech>
> Acked-by: Andre Przywara <andre.przywara@arm.com>

Applied to u-boot/master, thanks!
Kory Maincent May 17, 2021, 10:19 a.m. UTC | #3
Hello Andre,

On Thu, 13 May 2021 12:03:05 +0100
Andre Przywara <andre.przywara@arm.com> wrote:

> On Tue,  4 May 2021 19:31:28 +0200
> Kory Maincent <kory.maincent@bootlin.com> wrote:
> 
> > This commit enables using the extension board detection mechanism on
> > CHIP boards
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > Acked-by: Maxime Ripard <maxime@cerno.tech>  
> 
> Acked-by: Andre Przywara <andre.przywara@arm.com>
> 
> Cheers,
> Andre
> 
> P.S. Out of curiosity: what is the story for the CHIP Pro here? Does it
> not work there or is it just not tested?

The CHIP PRO design is not compatible with the DIPs in the market.
I do not have heard about DIPs for CHIP PRO pinout, maybe Maxime has
more information about it.

Regards,
Köry
diff mbox series

Patch

diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig
index a70ee31d40..8d40da090b 100644
--- a/configs/CHIP_defconfig
+++ b/configs/CHIP_defconfig
@@ -1,6 +1,7 @@ 
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_SPL=y
+CONFIG_CHIP_DIP_SCAN=y
 CONFIG_MACH_SUN5I=y
 CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y
 CONFIG_USB0_VBUS_PIN="PB10"