Message ID | 20210503231136.744283-2-sjg@chromium.org |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=S4JJbpad; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FYzJW5pxQz9sCD for <incoming@patchwork.ozlabs.org>; Tue, 4 May 2021 09:12:09 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6E30782B08; Tue, 4 May 2021 01:11:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="S4JJbpad"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E110A82AFC; Tue, 4 May 2021 01:11:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D4E0382AC3 for <u-boot@lists.denx.de>; Tue, 4 May 2021 01:11:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x136.google.com with SMTP id y10so4942049ilv.0 for <u-boot@lists.denx.de>; Mon, 03 May 2021 16:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BaqJ1u3f0nZafWazlifp4sMPjGbvV5Pc2PmeG14QEQA=; b=S4JJbpadXFtvxo1VVA/v8qGFodtuTRuu3Z9fqPoFmLewKkQgcwwX1r4HGSi0cvIWeJ aJ6FVQdtpuZaYhX9Lq8wMpnva0Ntwfu/WW939m9uFwL1VbEcxBpi4a0JysbAnSWfqJ+b G+6ZxpZ3m7wQSwFJLwKOz77/vpRt5jCLJ9BBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BaqJ1u3f0nZafWazlifp4sMPjGbvV5Pc2PmeG14QEQA=; b=aJvTreGuOk1MEb5/C/tKCc8oToMH98yhA9T0PWSIy+Y/5p58h1YZhvk2jtobjxYE3q gM968PZ0yjModt0xPJWnmpEZZCqZBvnrFQbmiYfLLzJQCwcxm3cuVeZURXBJLaPHbrI7 iOzTawLbymmBM751qAypkpk8hRIeeCrwLHNv6poLO1AI63hsjRvcJwL5OF8UDICueN9Y eAwz99z/Z/SOONPavkxvSE/lHGMojPkCxr2f9tG/f1dijJW1pMrPnhYydj9AktL9J2mi K2xxD2wXlu3Brqxt4pdsEWquv1EUBtAcfkR9WZdxs7h92TAhYq9dxjxndJUkVMMO8cZG 0fXQ== X-Gm-Message-State: AOAM531HWywF/+//Ym79Z5LpMNroz+4Eu/2zmV9ubzl6ZDH0YDcBiD5L FASbqyYciqIEE/JMBN9uk0JDLt+BVe8Bpw== X-Google-Smtp-Source: ABdhPJyLmBHu0xZBY8adI3dWSXdBJqxTMkXE1rwmTHif1PFNeSJKDkSY/A1MqyTexJ9bZrB+MzeJ7g== X-Received: by 2002:a05:6e02:685:: with SMTP id o5mr8249323ils.93.1620083508497; Mon, 03 May 2021 16:11:48 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id o6sm422727ioa.21.2021.05.03.16.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 16:11:47 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Tom Rini <trini@konsulko.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, Bin Meng <bmeng.cn@gmail.com>, Robert Marko <robert.marko@sartura.hr>, Andre Przywara <andre.przywara@arm.com>, Masahiro Yamada <masahiroy@kernel.org>, Simon Glass <sjg@chromium.org>, Sebastian Reichel <sebastian.reichel@collabora.com>, Stefan Roese <sr@denx.de> Subject: [PATCH 02/49] compiler: Add a comment to host_build() Date: Mon, 3 May 2021 17:10:49 -0600 Message-Id: <20210503231136.744283-2-sjg@chromium.org> X-Mailer: git-send-email 2.31.1.527.g47e6f16901-goog In-Reply-To: <20210503231136.744283-1-sjg@chromium.org> References: <20210503231136.744283-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean |
Series |
image: Reduce #ifdefs and ad-hoc defines in image code
|
expand
|
On 04/05/2021 01.10, Simon Glass wrote: > This function should have a comment explaining what it does. Add one. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > (no changes since v1) > > include/compiler.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/compiler.h b/include/compiler.h > index 27b9843497a..ec0d600e71a 100644 > --- a/include/compiler.h > +++ b/include/compiler.h > @@ -151,6 +151,11 @@ typedef unsigned long int uintptr_t; > #define MEM_SUPPORT_64BIT_DATA 0 > #endif > > +/** > + * host_build() - check if we are building for the host > + * > + * @return true if building for the hose, false if for a target spello, hose->host
diff --git a/include/compiler.h b/include/compiler.h index 27b9843497a..ec0d600e71a 100644 --- a/include/compiler.h +++ b/include/compiler.h @@ -151,6 +151,11 @@ typedef unsigned long int uintptr_t; #define MEM_SUPPORT_64BIT_DATA 0 #endif +/** + * host_build() - check if we are building for the host + * + * @return true if building for the hose, false if for a target + */ static inline bool host_build(void) { #ifdef USE_HOSTCC return true;
This function should have a comment explaining what it does. Add one. Signed-off-by: Simon Glass <sjg@chromium.org> --- (no changes since v1) include/compiler.h | 5 +++++ 1 file changed, 5 insertions(+)