diff mbox series

[1/1] efi_loader: memory leak in efi_capsule_scan_dir()

Message ID 20210411045804.85436-1-xypron.glpk@gmx.de
State Accepted, archived
Commit e8287b0fb2be8acf8d0412be3b4174768fef348c
Delegated to: Heinrich Schuchardt
Headers show
Series [1/1] efi_loader: memory leak in efi_capsule_scan_dir() | expand

Commit Message

Heinrich Schuchardt April 11, 2021, 4:58 a.m. UTC 
If realloc() fails, we should free the old buffer.

Fixes: c74cd8bd08d1: ("efi_loader: capsule: add capsule_on_disk support")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_capsule.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.30.2
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
index 9df9c35084..691eda5e0d 100644
--- a/lib/efi_loader/efi_capsule.c
+++ b/lib/efi_loader/efi_capsule.c
@@ -756,8 +756,11 @@  static efi_status_t efi_capsule_scan_dir(u16 ***files, unsigned int *num)
 		tmp_size = dirent_size;
 		ret = EFI_CALL((*dirh->read)(dirh, &tmp_size, dirent));
 		if (ret == EFI_BUFFER_TOO_SMALL) {
+			struct efi_file_info *old_dirent = dirent;
+
 			dirent = realloc(dirent, tmp_size);
 			if (!dirent) {
+				dirent = old_dirent;
 				ret = EFI_OUT_OF_RESOURCES;
 				goto err;
 			}