Message ID | 20210409021313.433558-4-seanga2@gmail.com |
---|---|
State | Accepted |
Commit | 598a06dcb47db8101a19d26c0d65572fbe8e71f6 |
Delegated to: | Andes |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=fDdmYVCz; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FGhXg6H2mz9sSC for <incoming@patchwork.ozlabs.org>; Fri, 9 Apr 2021 12:14:43 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A0E2280407; Fri, 9 Apr 2021 04:13:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fDdmYVCz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E6CE78021F; Fri, 9 Apr 2021 04:13:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F0CA800D3 for <u-boot@lists.denx.de>; Fri, 9 Apr 2021 04:13:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x730.google.com with SMTP id c3so4450597qkc.5 for <u-boot@lists.denx.de>; Thu, 08 Apr 2021 19:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j+U5oNIG06cyZQv+M6O4c6XXR27bfBRoUzdNqAS7kdc=; b=fDdmYVCzCW9tU9YldW5QANojn/hGmf9VhIiUUodg+igMmQQ+HAGWG/xh4CdsPog39g Ch1clZ8ogqoftH5+moAvuHrZcaWLpQgPDWM6RgcoBgstFRf+zGzCMRNYQrtnvcLkgjub xiIUFiWMdqiiB213TCrA/R5Br/rRqx4H7nWygftceLEMClxFeSgiv3HTe4M85HUUZo+x qa/AzycFEWO862nPCduPGcr0+FrLWOYEUCFXHaeHNeGJ29zTSQjV4n5gTqAqIpODiKJs DJ8o5aWx/OEF40LMBnF7LGV6YyLZgS/qJ3eJVv9FT8QUhFkltMO1craILlB7K5YRCfXx Wz6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j+U5oNIG06cyZQv+M6O4c6XXR27bfBRoUzdNqAS7kdc=; b=FY2LMDCre8WQJ+XcUA5Tm0PBHjkxNwXA2EGE2ChVdZSqAx8VvhqnvxRISzHCzOhKk+ DWzp8FIM28JFmXVeOjKLle70lgoH8i9MukVMKw4/7BgAjjKntBqloIDyk+zS+UKH/d2x thTjSzccp6OSUbgvzSm9BbJwvAk3m9nNy44mSuB7EALJWMUZzFmkh47mXo7UWCx3n07x VUJ899H5YiVoYDg2lwN6RjIXxBdZT1qUGmX7T5gNZ2PvtXhL0XoiVlqKw7MQvIyVUUmx 4PMdnMxpPCYWWXe2pxm6lUrldz3ScoQnmep4ndsVu2caad+xXYDcO7gDjL9UswJGz0Za TqXQ== X-Gm-Message-State: AOAM533vgqUsYeWAfkckvr7PCJaiEtSgAe09V4kxKxRqHcgAiHJc6qHX Ua4FC8YowylDSQrNzneV2RJrd9/HR+8= X-Google-Smtp-Source: ABdhPJzKrK/mZVsIsy6dQ7+l900ZcJ8XaMbesAR0XyqqJTQAGwPT+bsIyWkAtgfLLq5y95iJb+idhQ== X-Received: by 2002:a05:620a:108f:: with SMTP id g15mr11810837qkk.298.1617934405846; Thu, 08 Apr 2021 19:13:25 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-51-35-162.washdc.fios.verizon.net. [108.51.35.162]) by smtp.gmail.com with ESMTPSA id h8sm951678qta.53.2021.04.08.19.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 19:13:25 -0700 (PDT) From: Sean Anderson <seanga2@gmail.com> To: u-boot@lists.denx.de Cc: Bin Meng <bmeng.cn@gmail.com>, Leo Liang <ycliang@andestech.com>, Rick Chen <rickchen36@gmail.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, Sean Anderson <seanga2@gmail.com>, Damien Le Moal <Damien.LeMoal@wdc.com>, Lukasz Majewski <lukma@denx.de> Subject: [PATCH v3 03/11] clk: k210: Fix PLL enable always getting taken Date: Thu, 8 Apr 2021 22:13:05 -0400 Message-Id: <20210409021313.433558-4-seanga2@gmail.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210409021313.433558-1-seanga2@gmail.com> References: <20210409021313.433558-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean |
Series |
riscv: k210: Enable use of AI ram bank
|
expand
|
diff --git a/drivers/clk/kendryte/pll.c b/drivers/clk/kendryte/pll.c index f198920113..d46fd0ebbf 100644 --- a/drivers/clk/kendryte/pll.c +++ b/drivers/clk/kendryte/pll.c @@ -512,7 +512,8 @@ static int k210_pll_enable(struct clk *clk) struct k210_pll *pll = to_k210_pll(clk); u32 reg = readl(pll->reg); - if ((reg | K210_PLL_PWRD) && !(reg | K210_PLL_RESET)) + if ((reg & K210_PLL_PWRD) && (reg & K210_PLL_EN) && + !(reg & K210_PLL_RESET)) return 0; reg |= K210_PLL_PWRD;
This conditional always evaluated as false, regardless of the value of reg. Fix it so that it properly tests the bits in the PLL register. Also test PLL_EN, now that we set it. Reported-by: Damien Le Moal <Damien.LeMoal@wdc.com> Signed-off-by: Sean Anderson <seanga2@gmail.com> --- (no changes since v2) Changes in v2: - New drivers/clk/kendryte/pll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)