diff mbox series

[03/16] ARM: dts: imxrt1020: add alias to osc

Message ID 20210407190304.1478921-4-giulio.benetti@benettiengineering.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series Fix i.MXRT1020/50 | expand

Commit Message

Giulio Benetti April 7, 2021, 7:02 p.m. UTC
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 arch/arm/dts/imxrt1020.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam May 3, 2021, 2 p.m. UTC | #1
Hi Giulio,

On Wed, Apr 7, 2021 at 4:03 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  arch/arm/dts/imxrt1020.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/imxrt1020.dtsi b/arch/arm/dts/imxrt1020.dtsi
> index 97f3cec9f3..0a3a3b451a 100644
> --- a/arch/arm/dts/imxrt1020.dtsi
> +++ b/arch/arm/dts/imxrt1020.dtsi
> @@ -36,7 +36,7 @@
>                         clock-frequency = <0>;
>                 };
>
> -               osc {
> +               osc: osc {

Nit: what you are adding here is a "node label", not an "alias".

It would be nice to always add a commit log, even if it is a short one.
Giulio Benetti May 3, 2021, 5:51 p.m. UTC | #2
Hi Gabio,

> Il giorno 3 mag 2021, alle ore 16:01, Fabio Estevam <festevam@gmail.com> ha scritto:
> 
> Hi Giulio,
> 
>> On Wed, Apr 7, 2021 at 4:03 PM Giulio Benetti
>> <giulio.benetti@benettiengineering.com> wrote:
>> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> arch/arm/dts/imxrt1020.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm/dts/imxrt1020.dtsi b/arch/arm/dts/imxrt1020.dtsi
>> index 97f3cec9f3..0a3a3b451a 100644
>> --- a/arch/arm/dts/imxrt1020.dtsi
>> +++ b/arch/arm/dts/imxrt1020.dtsi
>> @@ -36,7 +36,7 @@
>>                        clock-frequency = <0>;
>>                };
>> 
>> -               osc {
>> +               osc: osc {
> 
> Nit: what you are adding here is a "node label", not an "alias".
Thank you, you’re right.
> 
> It would be nice to always add a commit log, even if it is a short one.

Ok, is it ok if it even repeats the first line? Because I don’t know what write more than that.

Best regards
Giulio Benetti
Fabio Estevam May 3, 2021, 6:21 p.m. UTC | #3
On Mon, May 3, 2021 at 2:52 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:

> Ok, is it ok if it even repeats the first line? Because I don’t know what write more than that.

Yes, that would be fine.
Giulio Benetti May 3, 2021, 7:03 p.m. UTC | #4
> Il giorno 3 mag 2021, alle ore 20:21, Fabio Estevam <festevam@gmail.com> ha scritto:
> 
> On Mon, May 3, 2021 at 2:52 PM Giulio Benetti
> <giulio.benetti@benettiengineering.com> wrote:
> 
>> Ok, is it ok if it even repeats the first line? Because I don’t know what write more than that.
> 
> Yes, that would be fine.

Ok thank you. This was a doubt I always had.

Giulio
diff mbox series

Patch

diff --git a/arch/arm/dts/imxrt1020.dtsi b/arch/arm/dts/imxrt1020.dtsi
index 97f3cec9f3..0a3a3b451a 100644
--- a/arch/arm/dts/imxrt1020.dtsi
+++ b/arch/arm/dts/imxrt1020.dtsi
@@ -36,7 +36,7 @@ 
 			clock-frequency = <0>;
 		};
 
-		osc {
+		osc: osc {
 			u-boot,dm-spl;
 			compatible = "fsl,imx-osc", "fixed-clock";
 			#clock-cells = <0>;